May 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR5570: win32u: Some more refactor in preparation for vulkan-only GPU enumeration.
by Rémi Bernon May 28, 2024

May 28, 2024

In order to implement the patch discussed in https://gitlab.winehq.org/wine/wine/-/merge_requests/5491#note_67907 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5570

3 8

[PATCH v3 0/2] MR2724: wined3d: Submit command buffers that are built for longer than 2 ms.
by Zebediah Figura (＠zfigura) May 28, 2024

May 28, 2024

This improves performance for the game "Grounded", on a AMD Radeon RX 6700 XT, with radv from Mesa 22.3.6. Testing was done with the "cb_access_map_w" option enabled, which also improves performance with the game by itself. >From my testing, it's possible to raise the threshold from 2 ms up to 5 ms or so, before the driver or GPU seems to reclock back to the lower power level. However, this measurement is questionable for several reasons. It seems to vary depending on the scene being rendered, and of course this will be specific to the game and driver and GPU in question anyway. The game also has a weird approach to vsync that seems to involve it presenting stale frames (and hence artificially inflating the FPS), which I'm not fully sure I accounted for while measuring. And of course, it's hard to be sure that 5 ms is actually the threshold for how long the driver will go before powering down the GPU. In any case, it seems better to err on the side of submitting more often, to make sure the fix affects more drivers. While submission isn't cheap, it seems to me that submitting every 2 ms is unlikely to cause a bottleneck [consider that this is at most 8 (more) submissions per frame]. The maximum of 4 concurrent periodically submitted buffers was chosen arbitrarily. Removing the maximum altogether does not measurably affect performance for this game either way. Credit goes to Philip Rebohle and his work on DXVK for helping me to notice that periodic submission might make a difference. -- v3: wined3d: Submit command buffers after 512 draw or dispatch commands. wined3d: Retrieve the VkCommandBuffer from wined3d_context_vk after executing RTV barriers. https://gitlab.winehq.org/wine/wine/-/merge_requests/2724

4 4

[PATCH v3 0/1] MR5589: ntdll: Don't restore PC from LR after unwinding through frame switches.
by Billy Laws (＠bylaws) May 28, 2024

May 28, 2024

Fixes unwinds from within a consolidation callback on ARM64EC, as the context frame could be x64 with UNWOUND_TO_CALL set, in which case LR contains garbage. See: https://github.com/dotnet/runtime/blob/71abc26cf8f14f5d15665d7f580365ddfa29… -- v3: ntdll: Don't restore PC from LR after unwinding through frame switches. https://gitlab.winehq.org/wine/wine/-/merge_requests/5589

2 2

Re: [PATCH v2 0/1] MR5580: ntdll/unix: Fix building on musl by explicitly including asm/ioctls.h
by Fotios Valasiadis (＠fvalasiad) May 28, 2024

May 28, 2024

@zfigura Whoops, my bad! I see Alexandre fixed it for me, thanks! Best of luck! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5580#note_69737

1 0

[PATCH v3 0/10] MR5559: include: Fix another 13 typoed GUIDs
by Alfred Agrell (＠Alcaro) May 28, 2024

May 28, 2024

Same bug class as https://gitlab.winehq.org/wine/wine/-/merge_requests/5550. None of them are referenced by anything (not counting mfplat/main.c's debugstr_attr(), which names the two in mfapi.h - better debug output, yay I guess). -- v3: include: Fix a typoed GUID include: Fix a typoed GUID include: Fix two typoed GUIDs include: Fix two typoed GUIDs include: Fix two typoed GUIDs include: Fix a typoed GUID include: Fix a typoed GUID include: Fix a typoed GUID include: Fix a typoed GUID include: Fix a typoed GUID https://gitlab.winehq.org/wine/wine/-/merge_requests/5559

3 13

Re: [PATCH v2 0/1] MR5587: ntdll: Allocate wow64 environment block within the 32-bit AS. - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5587

1 0

Re: [PATCH v2 0/1] MR5581: include: Fix name conflict with access modifier in mfmediaengine.idl. - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5581

1 0

Re: [PATCH v2 0/1] MR5580: ntdll/unix: Fix building on musl by explicitly including asm/ioctls.h - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5580

1 0

[PATCH 0/1] MR5580: ntdll/unix: Fix building on musl by explicitlyy including asm/ioctls.h
by Fotios Valasiadis (＠fvalasiad) May 28, 2024

May 28, 2024

After commit 898ab8dab19d498c17859f39a55e317ee7e367a5 wine would no longer build on musl. Issue is that apparently TCSETS2 isn't defined when including sys/ioctl.h. A little digging shows that glibc goes ahead and includes asm/ioctls.h in sys/ioctl.h, providing said macro. Musl on the other hand doesn't and relies on bits/ioctl.h, which lacks said macro. Since there is no mention in the manpage about the need to include asm/ioctls.h, uncertain if that's an issue with musl or the manpage, would like some help on that front so I can go open PRs to fix that respectively. Signed-off-by: Fotios Valasiadis <fvalasiad(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5580

3 3

[PATCH v34 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon May 28, 2024

May 28, 2024

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v34: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

2 16