May 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v8 0/2] MR5178: winewayland.drv: set wayland app-id from the process name
by Shmerl (＠shmerl) May 28, 2024

May 28, 2024

On Sat Mar 23 08:48:29 2024 +0000, Rémi Bernon wrote: > It's perhaps instead that approval only show up if the person is > assigned as a reviewer, or that it was overlooked. Any plans to merge this? It missed the Wine release. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_67063

1 0

[PATCH v4 0/1] MR5188: Draft: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows.
by Tim Clem (＠tclem) May 28, 2024

May 28, 2024

This is a change from the default behavior in macdrv for as long as it's existed, as far as I can tell. Previously, gaining a dock icon was a one-way path. However, that doesn't jive with the way taskbar entries work on Windows; if an app has no windows, it doesn't appear in the taskbar. This patch attempts to remedy cases where an app winds up with superfluous dock icons for exe's that no longer have windows (looking at you, basically every launcher and Steam). The major concern I can see with this is that if an app closes all of its windows but does not exit, there will be no indication that it is still running. Two thoughts on that: 1. That *should* be an anomalous case, such as the app hanging on exit. 2. Effectively the same behavior would happen on Windows. I would love to hear any other thoughts about this change. I'm open (though I would not prefer it) to defaulting the registry key to false if that would alleviate any concerns. -- v4: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

2 2

[PATCH 0/1] MR5467: ntdll: Return STATUS_NO_YIELD_PERFORMED from NtYieldExecution() on Linux if no yield was performed.
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5467

3 3

Re: [PATCH v3 0/5] MR4565: winex11: Use helpers to attach / detach / destroy client windows. - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4565

1 0

Re: [PATCH v2 0/1] MR5466: winemac.drv: Show the window after setting layered attributes. - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5466

1 0

[PATCH 0/3] MR5462: Ucrtbase's stderr is now always unbuffered.
by eric pouech (＠epo) May 28, 2024

May 28, 2024

Starting with late Windows 10 version, in ucrtbase, stderr is now unbuffered whatever the type of the underlying fd (previously, native only set it to unbuffered when attached to character fd (console, NUL...)). This serie adds also tests for msvcrt & ucrtbase to show the discrepancies. Note: ucrtbase's tests also include a reversed engineered structure layout for FILE. _get_stream_buffer_pointers already gives base, ptr and cnt, and toying with setvbuf gave easily the rest of the fields. Didn't spend time in guessing the flags meaning: which look different from msvcrt's. Related to https://bugs.winehq.org/show_bug.cgi?id=56459 @piotr: I can share the details (the access to the test result in the bug report is limited). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5462

3 7

Re: [PATCH v6 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

Please use your full name in the git commit info. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_67033

1 0

[PATCH 0/1] MR5296: mf/session: Keep previously allocated sample with the transform streams.
by Rémi Bernon May 28, 2024

May 28, 2024

When using a video sample allocator, the session will allocate samples from it, then try to get some output from a transform, and if there's no output to be pulled, release the sample immediately. This will trigger the sample allocator notify callback, which will then trigger another try at pulling samples, ending up in a callback loop that can starve other working threads. Another option here would be to keep the last returned status, and only re-try to pull samples from the allocator notify callback if we previously failed to process output because of a failed allocation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5296

3 10

Re: [PATCH v2 0/2] MR5421: gdiplus: Search microsoft platform names first in load_ttf_name_id(). - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5421

1 0

Re: [PATCH v2 0/1] MR5453: wined3d: Require ARB_texture_non_power_of_two. - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5453

1 0