June 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/1] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Zhiyi Zhang (＠zhiyi) June 26, 2024

June 26, 2024

> It fails on asserting return value of sending LVM_GETNEXTITEM message In that case, please also add a test checking the same thing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_74512

1 0

[PATCH v7 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) June 26, 2024

June 26, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v7: comclt32: Allow hotkeys for propsheet navigation. comctl32/tests: Add test for propsheet hotkey navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

4 5

[PATCH 0/2] MR5937: Fix hotpatch prologue in GetProcAddress().
by Paul Gofman (＠gofman) June 26, 2024

June 26, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5937

3 3

[PATCH v3 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) June 26, 2024

June 26, 2024

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v3: winegstreamer: Set MAX_THREADS to 4 for i386. winegstreamer: Use thread_count to determine 'max-threads' value. winegstreamer: Use process affinity to calculate thread_count. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

2 8

Re: [PATCH v2 0/1] MR5936: mscoree: Update Wine Mono to 9.2.0. - approved
by Alexandre Julliard (＠julliard) June 26, 2024

June 26, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5936

1 0

Re: [PATCH v4 0/7] MR5912: win32u: Create a shared memory object for message queue and read active hooks bitmap from it. - approved
by Alexandre Julliard (＠julliard) June 26, 2024

June 26, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5912

1 0

Re: [PATCH v2 0/5] MR5932: Cmd engine rewrite (part X) - approved
by Alexandre Julliard (＠julliard) June 26, 2024

June 26, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5932

1 0

Re: [PATCH v5 0/6] MR5870: mmdevapi: Implement loopback capture with winepulse backend. - approved
by Alexandre Julliard (＠julliard) June 26, 2024

June 26, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5870

1 0

Re: [PATCH v2 0/1] MR5928: msado15: Support interface ADOCommandConstruction in _Command - approved
by Alexandre Julliard (＠julliard) June 26, 2024

June 26, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5928

1 0

Re: [PATCH v3 0/2] MR5927: quartz: Implement IVMRWindowlessControl::GetNativeVideoSize(). - approved
by Alexandre Julliard (＠julliard) June 26, 2024

June 26, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5927

1 0

[PATCH 0/1] MR5936: mscoree: Update Wine Mono to 9.2.0.
by Esme Povirk (＠madewokherd) June 26, 2024

June 26, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5936

3 2

Re: [PATCH v2 0/1] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Ilia Docin (＠IDocin) June 26, 2024

June 26, 2024

On Wed Jun 26 07:26:50 2024 +0000, Zhiyi Zhang wrote: > This looks correct at first glance. Do you have an application affected > by this? It seems to me changing this only reduces some time and -1 will > be returned if it's the last item. Yes, I have. It fails on asserting return value of sending LVM_GETNEXTITEM message. I agree about aftereffect of this fix. Anyway, for me it doesn't make sense to handle ahead of time incorrect item (== infoPtr->nItemCount). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_74482

1 0

Re: [PATCH v5 0/1] MR5706: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper
by Ilia Docin (＠IDocin) June 26, 2024

June 26, 2024

On Wed Jun 26 07:15:20 2024 +0000, Zhiyi Zhang wrote: > Do you have a link to the software you used to demonstrate? No. It's a commercial software. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_74478

1 0

[PATCH v2 0/6] MR5926: ntdll: Always fill the 32-bit IOSB when performing I/O on overlapped handles.
by Elizabeth Figura (＠zfigura) June 26, 2024

June 26, 2024

Previously it was assumed that synchronous I/O fills the 64-bit IOSB, and asynchronous I/O fills the 32-bit IOSB. As the ntdll:wow64 tests show, this is incorrect. I/O on an overlapped handle, whether it is synchronous or not, fills the 32-bit IOSB, and I/O on a non-overlapped handle always fills the 64-bit IOSB. The first half is important, since completion can be signaled before we even return from the initial I/O call [NtReadFile() etc.] Filling the IOSB after signaling completion is the cause of bug 56389. This patch series fixes that. The second discrepancy does not cause any bugs, as far as I can see, and is a bit harder to fix anyway. It is therefore not addressed by this patch series. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56389 -- v2: ntdll: Always fill the 32-bit iosb for overlapped handles, for regular read/write. ntdll: Always fill the 32-bit iosb for overlapped handles, in set_async_direct_result(). ntdll: Always fill the 32-bit iosb for overlapped handles, in file_complete_async(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5926

2 7

[PATCH 0/10] MR5934: ntdll: Improvements related to preferred UI languages
by Piotr Caban (＠piotr) June 26, 2024

June 26, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5934

2 10

[PATCH v4 0/6] MR5870: mmdevapi: Implement loopback capture with winepulse backend.
by Paul Gofman (＠gofman) June 26, 2024

June 26, 2024

-- v4: mmdevapi/tests: Add test for capturing render loopback. winepulse.drv: Implement pulse_get_loopback_capture_device(). winepulse.drv: Factor out wait_pa_operation_complete(). mmdevapi: Stub AUDCLNT_STREAMFLAGS_LOOPBACK support. mmdevapi: Adjust timing after main loop start in client_Initialize(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5870

4 9

[PATCH 0/6] MR5926: ntdll: Always fill the 32-bit IOSB when performing I/O on overlapped handles.
by Elizabeth Figura (＠zfigura) June 26, 2024

June 26, 2024

Previously it was assumed that synchronous I/O fills the 64-bit IOSB, and asynchronous I/O fills the 32-bit IOSB. As the ntdll:wow64 tests show, this is incorrect. I/O on an overlapped handle, whether it is synchronous or not, fills the 32-bit IOSB, and I/O on a non-overlapped handle always fills the 64-bit IOSB. The first half is important, since completion can be signaled before we even return from the initial I/O call [NtReadFile() etc.] Filling the IOSB after signaling completion is the cause of bug 56389. This patch series fixes that. The second discrepancy does not cause any bugs, as far as I can see, and is a bit harder to fix anyway. It is therefore not addressed by this patch series. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56389 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5926

3 7

[PATCH 0/5] MR5932: Cmd engine rewrite (part X)
by eric pouech (＠epo) June 26, 2024

June 26, 2024

This is part X of cmd engine rewrite. This serie: - tackles some other variable expansion issues, - attaches redirections to CMD_NODE (where it belongs) (eg. "> foo (IF 1==1 echo a)" is a valid command), - preparing for next serie. Next serie will activate he updated lexer and parser. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5932

2 5

[PATCH v3 0/3] MR5915: include: Tweak atexit and cpuid declarations, guard DECLSPEC_UUID definition.
by Rémi Bernon June 26, 2024

June 26, 2024

IIUC atexit isn't exported by ucrtbase, but still exists (maybe as a builtin) and is resolved to a module-local symbol which can be used to register functions executed on module process detach. It is called implicitly by C++ compilers to register static destructors. -- v3: include: Define __cpuid(ex) as intrinsics when _MSC_VER is defined. include: Don't import atexit when building with ucrtbase. include: Guard rpcndr.h DECLSPEC_UUID definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/5915

1 4

[PATCH v2 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) June 26, 2024

June 26, 2024

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v2: winegstreamer: Set MAX_THREADS to 4 for i386. winegstreamer: Use thread_count to determine 'max-threads' value. winegstreamer: Provide thread_count to init_gstreamer. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

4 11

[PATCH 0/5] MR5865: win32u: Move some invisible surface conditions out of the drivers.
by Rémi Bernon June 26, 2024

June 26, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5865

2 18

[PATCH 0/5] MR5878: winex11, wineandroid: Stop clipping window surfaces with the virtual screen rect.
by Rémi Bernon June 26, 2024

June 26, 2024

Doing this first, instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/5865, this will let us move surface rect computation to win32u and then provide the previous surface as a default, before unifying the surface visibility conditions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5878

3 9

Re: [PATCH v2 0/1] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Zhiyi Zhang (＠zhiyi) June 26, 2024

June 26, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/listview.c: > { > if ((infoPtr->uView == LV_VIEW_LIST) || (infoPtr->uView == LV_VIEW_DETAILS)) > { > - while (nItem < infoPtr->nItemCount) > + while (nItem < infoPtr->nItemCount - 1) This looks correct at first glance. Do you have an application affected by this? It seems to me changing this only reduces some time and -1 will be returned if it's the last item. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_74440

1 0

Re: [PATCH v5 0/1] MR5706: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper
by Zhiyi Zhang (＠zhiyi) June 26, 2024

June 26, 2024

On Wed Jun 26 07:15:20 2024 +0000, Ilia Docin wrote: > To reproduce it, I moved gripper left and right to hide some buttons, > then brought it back. On the first image chevron didn't disappear as > expected. On the second one chevron went away as I applied fix. Do you have a link to the software you used to demonstrate? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_74439

1 0

Re: [PATCH v5 0/1] MR5706: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper
by Zhiyi Zhang (＠zhiyi) June 26, 2024

June 26, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/rebar.c: > lpBand->rcChild.top, lpBand->rcChild.right + CHEVRON_WIDTH, Please also change the commit message title to "comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper.". Note the dot at the end of the title. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_74438

1 0