June 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/5] MR5818: d3d11/tests: Other tests for NV12 textures. - approved
by Alexandre Julliard (＠julliard) June 27, 2024

June 27, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5818

1 0

Re: [PATCH v2 0/6] MR5815: wined3d: Feed FFP shader constants through push constant buffers, part 1. - approved
by Alexandre Julliard (＠julliard) June 27, 2024

June 27, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5815

1 0

Re: [PATCH v4 0/1] MR5351: wined3d: Compile the clear compute shaders with D3DCompile(). - approved
by Alexandre Julliard (＠julliard) June 27, 2024

June 27, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5351

1 0

Re: [PATCH v2 0/7] MR5930: win32u: Factor surface rect computation out of the drivers. - approved
by Alexandre Julliard (＠julliard) June 27, 2024

June 27, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5930

1 0

Re: [PATCH v2 0/1] MR5939: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) June 27, 2024

June 27, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5939

1 0

[PATCH v2 0/2] MR5937: Fix hotpatch prologue in GetProcAddress().
by Paul Gofman (＠gofman) June 27, 2024

June 27, 2024

-- v2: kernelbase: Remove 0x48 prologue from GetProcAddress() on x64. kernel32: Remove 0x48 prologue from GetProcAddress() on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/5937

2 5

[PATCH 0/1] MR5944: wpcap: Handle different layout of the native packet header structure on 32-bit.
by Hans Leidekker (＠hans) June 27, 2024

June 27, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56871 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5944

3 2

[PATCH v2 0/1] MR5816: wined3d: Implement wined3d_check_device_format_conversion().
by Elizabeth Figura (＠zfigura) June 27, 2024

June 27, 2024

This should reflect what we actually support, while still being a superset of what native drivers actually support. Native driver support varies, but, as the comments document, native drivers (at least as of windows 10) support only RGB -> RGB, YUV -> RGB, and BC -> RGB conversions. The actual formats supported are a more limited subset than exposed (despite that the video cards should be perfectly capable of supporting more conversions) but erring on the side of overreporting seems safer. -- v2: wined3d: Implement wined3d_check_device_format_conversion(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5816

4 4

[PATCH 0/4] MR5933: opengl32: Add default implementation for wglChoosePixelFormatARB.
by Alexandros Frantzis (＠afrantzis) June 27, 2024

June 27, 2024

This MR adds a default implementation for `wglChoosePixelFormatARB` (in opengl32.dll) which will be used automatically if the driver populates the wgl_pixel_format ARB fields. Thus winex11 automatically uses this, and this MR removes the driver internal implementation. The second part of this MR adds `WGL_ARB_pixel_format` support for winewayland (we can move this to a separate MR, but I wanted to have another implementation to better assess the behavior). The `wglChoosePixelFormatARB` behavior is loosely modeled after the the AMD driver as discussed in https://gitlab.winehq.org/wine/wine/-/merge_requests/5388. I tried to keep things simple to begin with, and the results I am getting in various apps/games are sensible, but please try this out so we can refine further. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5933

4 10

[PATCH 0/1] MR5892: wined3d: Recheck whether a query is active after wined3d_context_vk_get_command_buffer().
by Elizabeth Figura (＠zfigura) June 27, 2024

June 27, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5892

3 2

[PATCH v2 0/2] MR5872: ddraw: Preserve d3d device state in ddraw_surface_create().
by Paul Gofman (＠gofman) June 27, 2024

June 27, 2024

-- v2: ddraw: Preserve d3d device state in ddraw_surface_create(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5872

4 6

[PATCH 0/2] MR5943: jscript: Fix PROP_DELETED handling in delete_prop.
by Jacek Caban (＠jacek) June 27, 2024

June 27, 2024

Also use designated initializers for builtin_info_t in preparation for further refactoring. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5943

2 2

[PATCH 0/3] MR5942: Cmd engine rewrite (part XI)
by eric pouech (＠epo) June 27, 2024

June 27, 2024

This is part XI of cmd engine rewrite. This serie moves the IF and FOR instruction into the new CMD_NODE structure. I'm fully aware it's a large change (commit #1). It touches simultaneously at several components: - lexer is no longer trying to handle nested instructions; this is now handled over to parser which will take care of it in a recursive fashion - moving the IF and FOR instructions into CMD_NODE; this impacts the parser and the execution part These three parts are so tightly linked that I can't figure out a simple way to split first commit in smaller bits. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5942

2 3

[PATCH v4 0/5] MR5818: d3d11/tests: Other tests for NV12 textures.
by Giovanni Mascellani (＠giomasce) June 27, 2024

June 27, 2024

-- v4: d3d11/tests: Test UpdateSubresource() for NV12 textures. d3d11/tests: Test NV12 textures without render target. d3d11/tests: Do not check pitches. d3d11/tests: Check for NV12 texture support before testing them. d3d11/tests: Check the result of compiling HLSL shaders. https://gitlab.winehq.org/wine/wine/-/merge_requests/5818

4 8

[PATCH 0/6] MR5815: wined3d: Feed FFP shader constants through push constant buffers, part 1.
by Elizabeth Figura (＠zfigura) June 27, 2024

June 27, 2024

This is another step towards getting render states out of wined3d_state. The idea here is similar to the "push constant buffers" used for d3d8/9 flat constants, and reuses the same infrastructure. That is, we pack all of the constants directly into a wined3d_buffer which is bound directly to the wined3d_state as a normal constant buffer. For SPIR-V this buffer is placed in the GPU, and the shader can simply access it directly, with no renderer-specific changes needed other than to determine the buffer's location. Currently this buffer is still stored on the CPU for GLSL, and the contents are pulled back from the sysmem resource pointer, instead of being pulled from state->render_states. Eventually, at least for Vulkan, the idea will be to write a FFP replacement shader which takes structured data (which, given the constraints of SPIR-V, is broadly necessary; we cannot simply upload individual named uniforms as we can with GLSL). In fact this will take the form of an HLSL shader compiled to Shader Model 2 bytecode. This allows us to, once again, reuse pretty much all of the existing infrastructure and avoid writing more backend-specific code, and has the effect that this FFP replacement works not only with SPIR-V but also with GLSL, allowing us to eventually remove the existing GLSL FFP pipeline, and enabling me to develop the HLSL FFP pipeline mainly using the GL renderer [which is useful since the Vulkan renderer is still missing a few other features]. The full branch is available at [1], and passes all tests when using the GL renderer. [1] https://gitlab.winehq.org/zfigura/wine/-/tree/himavant8 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5815

3 7

[PATCH 0/1] MR5367: gitlab: Add gdb to the docker images.
by Rémi Bernon June 27, 2024

June 27, 2024

I'm currently, very unsuccessfully, tracking down a crash on the unix side that only happens on Gitlab, and although I'm still unable to reproduce it, it then would be useful to have gdb to attach on segfault when I will. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5367

2 4

[PATCH v3 0/1] MR5351: wined3d: Compile the clear compute shaders with D3DCompile().
by Giovanni Mascellani (＠giomasce) June 27, 2024

June 27, 2024

-- v3: wined3d: Compile the clear compute shaders at runtime. https://gitlab.winehq.org/wine/wine/-/merge_requests/5351

4 3

[PATCH v6 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) June 27, 2024

June 27, 2024

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v6: winegstreamer: Set MAX_THREADS to 4 for i386. winegstreamer: Use thread_count to determine 'max-threads' value. winegstreamer: Use process affinity to calculate thread_count. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

3 5

[PATCH 0/1] MR5941: xcopy: Handle switch options concatenated with path.
by Piotr Caban (＠piotr) June 27, 2024

June 27, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5941

2 1

[PATCH 0/7] MR5930: win32u: Factor surface rect computation out of the drivers.
by Rémi Bernon June 27, 2024

June 27, 2024

This clips surface rects which are larger than the virtual screen, keeping full window surfaces for one which are smaller. This makes sure that off-screen windows have valid pixels on overviews like macOS Exposé, or similarly, GNOME shell activities view. Supersedes both https://gitlab.winehq.org/wine/wine/-/merge_requests/5865 and https://gitlab.winehq.org/wine/wine/-/merge_requests/5878. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5930

2 8

Re: [PATCH v5 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Rémi Bernon June 27, 2024

June 27, 2024

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.c: > return true; > } > > +static ULONG popcount( ULONG val ) > +{ > +#if defined(__MINGW32__) > + return __builtin_popcount( val ); > +#else > + val -= val >> 1 & 0x55555555; > + val = (val & 0x33333333) + (val >> 2 & 0x33333333); > + return ((val + (val >> 4)) & 0x0f0f0f0f) * 0x01010101 >> 24; > +#endif > +} > + Well, now the __builtin_popcount path is never taken, because on the unix side it's not built with MinGW. There's a compiler check available already though. (Also mind the style change to match winegstreamer) ```suggestion:-10+0 static ULONG popcount(ULONG val) { #if HAVE___BUILTIN_POPCOUNT return __builtin_popcount(val); #else val -= val >> 1 & 0x55555555; val = (val & 0x33333333) + (val >> 2 & 0x33333333); return ((val + (val >> 4)) & 0x0f0f0f0f) * 0x01010101 >> 24; #endif } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5923#note_74516

1 0

Re: [PATCH v5 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Rémi Bernon June 27, 2024

June 27, 2024

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.c: > return STATUS_UNSUCCESSFUL; > } > > + if (SUCCEEDED(NtQueryInformationProcess( GetCurrentProcess(), > + ProcessAffinityMask, &process_mask, sizeof(process_mask), NULL ))) > + thread_count = popcount(process_mask); > + else > + thread_count = 0; ```suggestion:-4+0 if (!NtQueryInformationProcess(GetCurrentProcess(), ProcessAffinityMask, &process_mask, sizeof(process_mask), NULL))) thread_count = popcount(process_mask); else thread_count = 0; ``` SUCCEEDED is for HRESULT, Nt API returns NTSTATUS and we often just check that it's 0. Also note the style fixes (no space in paren here, continuation indent is 8 spaces). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5923#note_74517

1 0

[PATCH 0/1] MR5939: po: Update Lithuanian translation.
by Aurimas Fišeras June 27, 2024

June 27, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5939

1 1

Re: [PATCH v5 0/6] MR5870: mmdevapi: Implement loopback capture with winepulse backend.
by Davide Beatrici (＠davidebeatrici) June 26, 2024

June 26, 2024

On Thu Jun 27 01:41:40 2024 +0000, Davide Beatrici wrote: > Agreed. We may eventually want to make use of something like [clang-format](https://clang.llvm.org/docs/ClangFormat.html). https://gitlab.winehq.org/wine/wine/-/merge_requests/5938 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5870#note_74514

1 0

[PATCH 0/1] MR5938: Draft: Add clang-format configuration file
by Davide Beatrici (＠davidebeatrici) June 26, 2024

June 26, 2024

I tried to follow https://wiki.winehq.org/Wine_Developer%27s_Guide/Coding_Practice as closely as possible. Known issues: - No break before brace for assignments. Upstream issue: https://github.com/llvm/llvm-project/issues/79054 - `ContinuationIndentWidth` affects everything. Instead, we want it to be 8 for function arguments and 4 for assignments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5938

2 1