June 2024 - Wine-GitLab - list.winehq.org

[PATCH v4 0/2] MR5625: Fixes for GCC 14 warnings (in winedump)
by Aida Jonikienė July 12, 2024

July 12, 2024

The `-Wstringop-overread` fix feels a bit questionable (so I'll add Eric as a reviewer to clarify the MSC structs details) -- v4: winedump: Initialize size variable in dump_dir_exceptions(). winedump: Use offsetof() for string position calculations. https://gitlab.winehq.org/wine/wine/-/merge_requests/5625

4 6

[PATCH v2 0/2] MR5044: ntdll: Fix some threadpool races.
by Paul Gofman (＠gofman) July 10, 2024

July 10, 2024

That seems to fix some (difficult to reproduce) crashes in EA Desktop / CEF, usually on shutdown but sometimes during starting up. Currently TpSetWait can set (or clear) the event, while waitqueue_thread_proc() gets woken from NtWaitForMultipleObjects by previously set wait object and call the callback as if new set (or cleared) wait object is signaled. The crashes I was reproducing were always happening when RtlDeregisterWaitEx call is racing with waking the wait and calling the callback. -- v2: ntdll: Make sure wakeups from already unset events are ignored in waitqueue_thread_proc(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5044

3 5

[PATCH v4 0/4] MR5237: Use futexes on macOS for thread-ID alerts.
by Marc-Aurel Zent (＠mzent) July 10, 2024

July 10, 2024

This also bumps the minimum supported version of macOS to 10.12 to unconditionally assume the ulock syscalls are present. As discussed with @Gcenx this shouldn't be an issue, as the current minimum support version of 10.8 does not work anyways at the moment with only 10.10+ being useable and even then virtually no-one using wine on versions < 10.12 (and also being unsupported by the prebuilt binaries). Bumping to 10.12 would also have the side-benefit of allowing some cleanup of deprecated functions or legacy codepaths (like `mach_continuous_time` vs `mach_absolute_time` and probably much more). In my testing ulock futexes are about 2x faster for synchronization than kevents. Using the syscall wrappers here should provide protection against changing syscall numbers, and given that ulock is also directly used by libc++, the probability of an incompatible API change here is basically zero imo. By default ulock is also process-private, similar to the current linux implementation, cross-process synchronization would require darwin 19+ (macOS 10.15+) with `UL_COMPARE_AND_WAIT_SHARED`. The diff is a bit bigger than it actually is in effect, since https://gitlab.winehq.org/mzent/wine/-/commit/28a8a991c165f0d37dbf78ca3cdee… is only moving some code around and not actually changing anything. -- v4: ntdll: Implement futex_wait() and futex_wake_one() on macOS. ntdll: Simplify futex interface from futex_wake() to futex_wake_one(). ntdll: Use USE_FUTEX to indicate futex support. ntdll: Prefer futex for thread-ID alerts over kqueue. https://gitlab.winehq.org/wine/wine/-/merge_requests/5237

3 6

[PATCH 0/7] MR3606: winegstreamer: Introduce a new wg_source internal interface.
by Rémi Bernon July 10, 2024

July 10, 2024

This is the first batch of a series implementing faster media source resolution required to workaround an Unreal Engine race condition present in some games, and deterministic stream ordering that decodebin / parsebin cannot provide, which is required to expose the streams in native order, for compatibility in several other applications. I pushed the full series as a branch here: https://gitlab.winehq.org/rbernon/wine/-/commits/mr/wg-source-part-one Note that this full series is also a first step in the direction of having a simpler demuxer interface, which will be required in the future for compatibility with applications that build MF or DirectShow pipelines directly and expect the relevant components to behave as a demuxer and expose compressed media types. For now it only delays the use of wg_parser to whenever the media source is started, and matches the non-ordered streams using their media types and tags. This is a best effort solution but I don't think we can do much better for the moment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3606

5 29

[PATCH v2 0/7] MR5138: winegstreamer: Support and expose generic audio/video MFT decoders.
by Rémi Bernon July 10, 2024

July 10, 2024

-- v2: winegstreamer: Expose the generic video decoder transform. winegstreamer: Introduce a generic audio decoder transform. winegstreamer: Rename aac_decoder to audio_decoder. winegstreamer: Translate generic unknown audio / video media types. winegstreamer: Support generic audio / video unknown formats. winegstreamer: Call gst_video_info_from_caps for all video formats. winegstreamer: Call gst_audio_info_from_caps for all audio formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/5138

3 12

[PATCH v10 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) July 10, 2024

July 10, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v10: comclt32: Allow hotkeys for propsheet navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

3 4

[PATCH 0/1] MR5619: win32u: Use FT_LOAD_PEDANTIC on first load try in freetype_get_glyph_outline().
by Paul Gofman (＠gofman) July 8, 2024

July 8, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5619

4 9

[PATCH v6 0/2] MR5869: winewayland.drv: Add mouse rawinput support
by Grigory Vasilyev (＠h0tc0d3) July 8, 2024

July 8, 2024

Adds the registry key HKEY_CURRENT_USER\\Software\\Wine\\Wayland Driver\\rawinput witch allows mouse raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing mouse DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, but sensitivity curves in libinput are more difficult to calculate than mouse sensitivity in the games. Implementation of ideas written in the comments: https://gitlab.winehq.org/wine/wine/-/merge_requests/4698 -- v6: winewayland.drv: Add mouse rawinput support https://gitlab.winehq.org/wine/wine/-/merge_requests/5869

3 4

[PATCH v2 0/1] MR5687: ddraw: Set dwMaxVertexCount to 2048.
by Stefan Dösinger July 5, 2024

July 5, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44863 The bug has been fixed already by moving ddraw4 vertex buffers into system memory. Changing this value makes the game create a smaller buffer, which makes the game fast on video memory buffers. I think we should stay close to what Windows drivers report even though we mitigated the original issue in a different way. -- v2: ddraw: Set dwMaxVertexCount to 2048. https://gitlab.winehq.org/wine/wine/-/merge_requests/5687

2 3

[PATCH v6 0/1] MR5706: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper
by Ilia Docin (＠IDocin) July 5, 2024

July 5, 2024

-- v6: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper. https://gitlab.winehq.org/wine/wine/-/merge_requests/5706

4 4