June 2024 - Wine-GitLab - list.winehq.org

[PATCH v2 0/4] MR5830: dxgi: Fix some d3d12 swapchain issues.
by Conor McCarthy (＠cmccarthy) June 21, 2024

June 21, 2024

The last commit fixes glitches in Horizon Zero Dawn with vsync on, for reasons stated in the comment there. The wined3d implementation already blocks the client's call to `Present()` when `vkAcquireNextImageKHR()` blocks, so is roughly equivalent to this when frame latency and buffer count are equal. It has a frame latency implementation which unblocks after calling `vkQueuePresentKHR()`, rather than waiting for its execution to complete. I think the d3d12 implementation is supposed to do the latter, though using `KHR_present_wait` may be unnecessary overkill. Waiting on queue execution comes with a performance cost either way, so without a compelling reason for a strict implementation, something similar to wined3d makes sense. Another potential issue is after the call to `ID3D12CommandQueue_Signal()` in `d3d12_swapchain_present()`, the client is free to enqueue more commands when `Present()` returns, so by the time the signal is executed and the swapchain worker blits the image and calls `vkQueuePresentKHR()`, these commands are not necessarily enqueued immediately after the `Signal()`. This may not always be harmless. -- v2: dxgi: Wait for completion of a pending read of the next buffer before returning from d3d12_swapchain_Present(). dxgi: Wake the condition variable after leaving the critical section in d3d12_swapchain_resize_buffers(). dxgi: Wake the condition variable after leaving the critical section in d3d12_swapchain_present(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5830

2 4

[PATCH 0/2] MR5895: ntdll: Don't write partial strings with RTL_QUERY_REGISTRY_DIRECT.
by Alex Henrie (＠alexhenrie) June 21, 2024

June 21, 2024

The new tests revealed only one case where too-small buffers were not already being handled correctly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5895

3 3

[PATCH 0/5] MR5894: ntdll: Do not fill the IOSB or signal completion on failure.
by Elizabeth Figura (＠zfigura) June 21, 2024

June 21, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5894

2 5

Re: [PATCH v2 0/1] MR5886: maintainers: Remove myself as a winegstreamer maintainer.
by Alfred Agrell (＠Alcaro) June 20, 2024

June 20, 2024

Huh. Okay. I've seen some of those discussions, and something in them did indeed feel strange. (I never understood the context well enough to determine exactly what, and it's not my place to question that, anyways.) I'll miss you 💔 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5886#note_73870

1 0

Re: [PATCH v2 0/2] MR5877: winex11: Create a global vulkan instance for xrandr. - approved
by Alexandre Julliard (＠julliard) June 20, 2024

June 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5877

1 0

Re: [PATCH v2 0/4] MR5887: mshtml: Add support for using apply and call on (legacy) builtin function objects. - approved
by Alexandre Julliard (＠julliard) June 20, 2024

June 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5887

1 0

Re: [PATCH v43 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos. - approved
by Alexandre Julliard (＠julliard) June 20, 2024

June 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

1 0

Re: [PATCH v2 0/4] MR5889: Cmd engine rewrite (part VII) - approved
by Alexandre Julliard (＠julliard) June 20, 2024

June 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5889

1 0

Re: [PATCH v4 0/2] MR5879: winegstreamer: Implement stubs for h264 encoder. - approved
by Alexandre Julliard (＠julliard) June 20, 2024

June 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879

1 0

Re: [PATCH v2 0/1] MR5886: maintainers: Remove myself as a winegstreamer maintainer. - approved
by Alexandre Julliard (＠julliard) June 20, 2024

June 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5886

1 0