July 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v7 0/1] MR6133: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
by Đorđe Mančić July 24, 2024

July 24, 2024

On Wed Jul 24 16:08:05 2024 +0000, Elizabeth Figura wrote: > Gitlab seems to claim that when it's actually not true, unfortunately. I > don't know if there's anything we can do about it. > I don't think merge requests need to be rebased unless there are > actually merge conflicts. I see, thanks for letting me know about that! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6133#note_76955

1 0

Re: [PATCH v7 0/1] MR6133: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
by Elizabeth Figura (＠zfigura) July 24, 2024

July 24, 2024

On Wed Jul 24 10:05:49 2024 +0000, Đorđe Mančić wrote: > My bad, sorry. I'm new to contributing to Wine and the GitLab site said > that the merge request can't be approved if I don't rebase, so that's > why I did it. Gitlab seems to claim that when it's actually not true, unfortunately. I don't know if there's anything we can do about it. I don't think merge requests need to be rebased unless there are actually merge conflicts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6133#note_76952

1 0

[PATCH v11 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) July 24, 2024

July 24, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v11: comclt32: Allow hotkeys for propsheet navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

3 5

[PATCH 0/2] MR6093: user32/tests: Test repeated AttachThreadInput() calls.
by Zhiyi Zhang (＠zhiyi) July 24, 2024

July 24, 2024

For example, attaching thread A and B twice but detach them only once, then these two threads should still be attached. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6093

4 8

Re: [PATCH v7 0/1] MR6133: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
by Đorđe Mančić July 24, 2024

July 24, 2024

On Wed Jul 24 10:05:49 2024 +0000, Fabian Maurer wrote: > FWIW, I don't think you need to rebase it, unless there is conflicts. My bad, sorry. I'm new to contributing to Wine and the GitLab site said that the merge request can't be approved if I don't rebase, so that's why I did it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6133#note_76935

1 0

Re: [PATCH v7 0/1] MR6133: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
by Fabian Maurer (＠DarkShadow44) July 24, 2024

July 24, 2024

FWIW, I don't think you need to rebase it, unless there is conflicts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6133#note_76934

1 0

[PATCH 0/5] MR6148: include/codecapi.h: Add encoder defines.
by Ziqing Hui (＠zhui) July 24, 2024

July 24, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6148

3 6

[PATCH 0/3] MR6121: propsys: Initially implement VariantToPropVariant.
by Ziqing Hui (＠zhui) July 24, 2024

July 24, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6121

3 8

[PATCH 0/1] MR6147: wineboot: Downgrade the wineprefix update message to a trace.
by Francois Gouget (＠fgouget) July 23, 2024

July 23, 2024

There is no reason for Wine to unconditionally pollute stderr. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6147

2 1

[PATCH v2 0/8] MR6040: d3dx9: Use shared code for loading cube textures from files.
by Connor McAdams (＠cmcadams) July 23, 2024

July 23, 2024

Also some patches to address comments made on the last MR. :) -- v2: d3dx9: Add support for loading non-square cubemap DDS files into cube textures. d3dx9: Add support for specifying which array layer to get pixel data from to d3dx_image_get_pixels(). d3dx9: Use d3dx_image structure inside of D3DXCreateCubeTextureFromFileInMemoryEx(). d3dx9: Cleanup texture value argument handling in D3DXCreateCubeTextureFromFileInMemoryEx(). d3dx9: Refactor texture creation and cleanup in D3DXCreateCubeTextureFromFileInMemoryEx(). d3dx9/tests: Add more D3DXCreateCubeTextureFromFileInMemory{Ex}() tests. d3dx9/tests: Reorder test structure members. d3dx9/tests: Make some test structures static const. https://gitlab.winehq.org/wine/wine/-/merge_requests/6040

4 15