July 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/5] MR6033: include: Fix another 5 typoed GUIDs - approved
by Alexandre Julliard (＠julliard) July 10, 2024

July 10, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6033

1 0

[PATCH v4 0/8] MR6031: Draft: wine: Use atomic locks insted pthread_mutex.
by Grigory Vasilyev (＠h0tc0d3) July 10, 2024

July 10, 2024

I'm not sure about the need for this solution, so it's a **DRAFT**. For me it is an academic interest to check whether atomic locks will give advantages over pthread_mutex in games. First impressions are that games have become smoother, but need to think about tests that can actually be measured. Before build need define `WINE_USE_ATOMIC_LOCKS`. ```bash export CFLAGS="${CFLAGS} -DWINE_USE_ATOMIC_LOCKS" ``` -- v4: ws2_32: Add atomic lock support. wine32u: Add atomic lock support. winevulkan: Add atomic lock support. ntdll: Add atomic lock support. winewayland: Add atomic lock support. include: Define custom mutex macroses. https://gitlab.winehq.org/wine/wine/-/merge_requests/6031

5 14

Re: [PATCH v11 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) July 10, 2024

July 10, 2024

On Wed Jul 10 19:12:40 2024 +0000, Fabian Maurer wrote: > Is there a specific reason those two functions are separate instead of > RegGetValueA calling RegGetValueW? I don't know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5969#note_75808

1 0

[PATCH v9 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) July 10, 2024

July 10, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v9: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

2 1

[PATCH v3 0/8] MR6031: Draft: wine: Use atomic locks insted pthread_mutex.
by Grigory Vasilyev (＠h0tc0d3) July 10, 2024

July 10, 2024

I'm not sure about the need for this solution, so it's a **DRAFT**. For me it is an academic interest to check whether atomic locks will give advantages over pthread_mutex in games. First impressions are that games have become smoother, but need to think about tests that can actually be measured. Before build need define `WINE_USE_ATOMIC_LOCKS`. ```bash export CFLAGS="${CFLAGS} -DWINE_USE_ATOMIC_LOCKS" ``` -- v3: ws2_32: Add atomic lock support. wine32u: Add atomic lock support. winevulkan: Add atomic lock support. ntdll: Add atomic lock support. winewayland: Add atomic lock support. include: Define custom mutex macroses. https://gitlab.winehq.org/wine/wine/-/merge_requests/6031

4 12

[PATCH v3 0/5] MR6023: winegstreamer/wg_transform: Support creating encoder transform.
by Ziqing Hui (＠zhui) July 10, 2024

July 10, 2024

-- v3: winegstreamer/wg_transform: Support creating encoder transform. winegstreamer/wg_transform: Introduce transform_create_converter_elements. winegstreamer/wg_transform: Introduce transform_create_decoder_elements. https://gitlab.winehq.org/wine/wine/-/merge_requests/6023

5 9

[PATCH 0/4] MR6045: server: Reimplement mailslots using server-side I/O.
by Elizabeth Figura (＠zfigura) July 10, 2024

July 10, 2024

This fixes various corner cases. This is not motivated by any particular application. However, the server-side code seems at least as simple as the existing client-side code, is more accurate, and removes a potential source of complication from any future work involving asyncs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6045

3 5

[PATCH v2 0/2] MR5044: ntdll: Fix some threadpool races.
by Paul Gofman (＠gofman) July 10, 2024

July 10, 2024

That seems to fix some (difficult to reproduce) crashes in EA Desktop / CEF, usually on shutdown but sometimes during starting up. Currently TpSetWait can set (or clear) the event, while waitqueue_thread_proc() gets woken from NtWaitForMultipleObjects by previously set wait object and call the callback as if new set (or cleared) wait object is signaled. The crashes I was reproducing were always happening when RtlDeregisterWaitEx call is racing with waking the wait and calling the callback. -- v2: ntdll: Make sure wakeups from already unset events are ignored in waitqueue_thread_proc(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5044

3 5

[PATCH v4 0/4] MR5237: Use futexes on macOS for thread-ID alerts.
by Marc-Aurel Zent (＠mzent) July 10, 2024

July 10, 2024

This also bumps the minimum supported version of macOS to 10.12 to unconditionally assume the ulock syscalls are present. As discussed with @Gcenx this shouldn't be an issue, as the current minimum support version of 10.8 does not work anyways at the moment with only 10.10+ being useable and even then virtually no-one using wine on versions < 10.12 (and also being unsupported by the prebuilt binaries). Bumping to 10.12 would also have the side-benefit of allowing some cleanup of deprecated functions or legacy codepaths (like `mach_continuous_time` vs `mach_absolute_time` and probably much more). In my testing ulock futexes are about 2x faster for synchronization than kevents. Using the syscall wrappers here should provide protection against changing syscall numbers, and given that ulock is also directly used by libc++, the probability of an incompatible API change here is basically zero imo. By default ulock is also process-private, similar to the current linux implementation, cross-process synchronization would require darwin 19+ (macOS 10.15+) with `UL_COMPARE_AND_WAIT_SHARED`. The diff is a bit bigger than it actually is in effect, since https://gitlab.winehq.org/mzent/wine/-/commit/28a8a991c165f0d37dbf78ca3cdee… is only moving some code around and not actually changing anything. -- v4: ntdll: Implement futex_wait() and futex_wake_one() on macOS. ntdll: Simplify futex interface from futex_wake() to futex_wake_one(). ntdll: Use USE_FUTEX to indicate futex support. ntdll: Prefer futex for thread-ID alerts over kqueue. https://gitlab.winehq.org/wine/wine/-/merge_requests/5237

3 6

[PATCH 0/7] MR6041: Cmd engine rewrite (part XIX)
by eric pouech (＠epo) July 10, 2024

July 10, 2024

This is part XIX of cmd engine rewrite. It's the last MR (for now) for setting success/failure return code on internal commands. The remaining todo in this area are due to: - incompletly implemented builtin (eg: TYPE not handling multiple files, not wildcards; CHOICE missing a bunch of features; ...), - some commands (like START) being implemented as external executables, hence forcing RETURN CODE = ERRORLEVEL which is not always wanted, -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6041

3 9