August 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Hans Leidekker (＠hans) Aug. 29, 2024

Aug. 29, 2024

You don't need a fallback if you have SQLBindParameter(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80374

1 0

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 29, 2024

Aug. 29, 2024

The current Postgresql ODBC driver exports both SQLBindParam and SQLBindParameter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80372

1 0

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback - closed
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 29, 2024

Aug. 29, 2024

This merge request was closed by Alistair Leslie-Hughes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394

1 0

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 29, 2024

Aug. 29, 2024

I'll close this until I can workout why I needed it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80371

1 0

[PATCH 0/1] MR6395: msiexec: Remove an obsolete fixme.
by Hans Leidekker (＠hans) Aug. 29, 2024

Aug. 29, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6395

2 1

[PATCH 0/1] MR6392: concrt140: Don't forward _IsSynchronouslyBlocked functions.
by Paul Gofman (＠gofman) Aug. 29, 2024

Aug. 29, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6392

4 4

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Rémi Bernon Aug. 29, 2024

Aug. 29, 2024

On Thu Aug 29 07:47:26 2024 +0000, Rémi Bernon wrote: > This is a huge amount of changes and it doesn't seem really justified? I > think you can do everything you need with DEV_BROADCAST_HDR already and > do not need any internal structs, or am I missing something? I mean, DEV_BROADCAST_HANDLE has a dbch_nameoffset which you can use to put the device name in it, and use that for filtering? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80369

1 0

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Rémi Bernon Aug. 29, 2024

Aug. 29, 2024

Rémi Bernon (@rbernon) commented about include/wine/dbt.h: > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#ifndef __WINE_WINE_DBT_H_ > +#define __WINE_WINE_DBT_H_ > + > +#include <wine/plugplay.h> > +#include <wine/debug.h> > + > +struct device_notification_details This is a huge amount of changes and it doesn't seem really justified? I think you can do everything you need with DEV_BROADCAST_HDR already and do not need any internal structs, or am I missing something? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80368

1 0

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Hans Leidekker (＠hans) Aug. 29, 2024

Aug. 29, 2024

SQLBindParameter() is a v2 function so I don't see why it would need a fallback. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80367

1 0

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 29, 2024

Aug. 29, 2024

On Thu Aug 29 07:07:25 2024 +0000, Hans Leidekker wrote: > Can you share a trace? I'd like to see how the app calls this function. I'm not able to find a currently log with a call to this function. All the logs to have show this function wasn't supported in the ODBC v2.0 driver. 0024:trace:odbc:load_function_table failed to load SQLBindParam This could of been another application I was testing at the time but I'm cannot remember which one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80366

1 0