August 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR6353: cmd: Run files with ShellExecute() if CreateProcess() fails.
by Elizabeth Figura (＠zfigura) Aug. 25, 2024

Aug. 25, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6353

3 5

[PATCH v4 0/1] MR6347: advpack: DelNode support the ADN_DEL_IF_EMPTY flag
by Anders Kjersem (＠anders) Aug. 25, 2024

Aug. 25, 2024

Fixes a bug where `rundll32.exe advpack.dll,DelNodeRunDLL32 "c:\test",1` is only supposed to delete "test" if the directory is empty. Also causes the [DelDirs Inf section](https://www.mdgx.com/INF_web/deldirs.htm) to work correctly. Notes: - I changed the code so it ignores the result of `SetFileAttributesW` because the user might not have FILE_WRITE_ATTRIBUTES even if they have DELETE rights. This seems to match Windows (XP NTFS). -- v4: advpack: DelNode support ADN_DEL_IF_EMPTY flag https://gitlab.winehq.org/wine/wine/-/merge_requests/6347

3 2

[PATCH v3 0/1] MR6347: advpack: DelNode support the ADN_DEL_IF_EMPTY flag
by Anders Kjersem (＠anders) Aug. 25, 2024

Aug. 25, 2024

Fixes a bug where `rundll32.exe advpack.dll,DelNodeRunDLL32 "c:\test",1` is only supposed to delete "test" if the directory is empty. Also causes the [DelDirs Inf section](https://www.mdgx.com/INF_web/deldirs.htm) to work correctly. Notes: - I changed the code so it ignores the result of `SetFileAttributesW` because the user might not have FILE_WRITE_ATTRIBUTES even if they have DELETE rights. This seems to match Windows (XP NTFS). -- v3: advpack: DelNode support ADN_DEL_IF_EMPTY flag https://gitlab.winehq.org/wine/wine/-/merge_requests/6347

5 11

[PATCH 0/1] MR6351: win32u: Use unsigned bitfields.
by Huw Davies (＠huw) Aug. 25, 2024

Aug. 25, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6351

2 1

[PATCH 0/1] MR6350: nsiproxy: Add linux guards for the IPv6 forward info.
by Huw Davies (＠huw) Aug. 25, 2024

Aug. 25, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6350

3 2

Re: [PATCH v2 0/1] MR4483: nsiproxy.sys: Reduce scope of a variable in process_monitor_event
by Huw Davies (＠huw) Aug. 25, 2024

Aug. 25, 2024

Superseded by !6350 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4483#note_79928

1 0

Re: [PATCH v2 0/1] MR4483: nsiproxy.sys: Reduce scope of a variable in process_monitor_event - closed
by Huw Davies (＠huw) Aug. 25, 2024

Aug. 25, 2024

This merge request was closed by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4483

1 0

[PATCH 0/1] MR6306: msxml3: Fix compilation errors with Clang 18.
by Grigory Vasilyev (＠h0tc0d3) Aug. 24, 2024

Aug. 24, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6306

4 7

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) Aug. 24, 2024

Aug. 24, 2024

On Sat Aug 24 19:23:49 2024 +0000, Vibhav Pant wrote: > Hm, the `BroadcastSystemMessage` calls wouldn't work since the > \`DBT_BROADCAST_DEVICEINTERFACE\` struct needs to be first constructed. > That being said, I have tried to added code that does that to 1/4. 1/4 > also shouldn't have any `DBT_DEVTYP_HANDLE` related code anymore, let me > know if that works. 1/4 also merges the old 1/4 commit, and has been split into 2 commits - for introducing `new_event` and friends. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79915

1 0

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) Aug. 24, 2024

Aug. 24, 2024

On Sat Aug 24 19:22:08 2024 +0000, Elizabeth Figura wrote: > Patch 1/4 still needs to be merged into 2/4. > The BroadcastSystemMessage() calls seem to have been inadvertently > removed in 2/4, and the split isn't quite complete—it still introduces > DBT_DEVTYP_HANDLE support in plugplay_send_event(). Ideally separating > the new_event() helper would also be a separate commit, so that you're > not moving code and changing it at the same time. Hm, the `BroadcastSystemMessage` calls wouldn't work since the \`DBT_BROADCAST_DEVICEINTERFACE\` struct needs to be first constructed. That being said, I have tried to added code that does that to 1/4. 1/4 also shouldn't have any `DBT_DEVTYP_HANDLE` related code anymore, let me know if that works. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79913

1 0