August 2024 - Wine-GitLab - list.winehq.org

[PATCH v4 0/6] MR6315: Draft: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) Aug. 19, 2024

Aug. 19, 2024

PnP device notifications/events are currently sent and received from the `plugplay` service as the raw-bytes for the `DBT_DEVTYP_DEVICEINTERFACE` struct that needs to be sent from the PnP code in `ntoskrnl.exe`. While simple, it does not support sending `DBT_DEVTYP_HANDLE` events, as they also include a `HANDLE` to the device the event comes from, which cannot simply be sent as raw bytes. This MR reworks how notifications are sent and received from the `plugplay` service, by: 1. Introducing new structs `DEVICE_BROADCAST_HANDLE` and `DEVICE_BROADCAST_DEVICEINTERFACE` in `plugplay.idl`. The structs are similar to their counterparts in `dbt.h` without the `devicetype` and `size` fields added for the header. 2. Re-write `plugplay_{send,get}_event` to use the newly added union `DEVICE_BROADCAST`, which uses the `devicetype` value as the discriminant. A deep copy of this union is then appended to the event queue of every registered listener. 3. Re-write `I_ScRegisterDeviceNotification` and `device_notify_proc` in `sechost/service.c` to use the newly added types instead. Additionally, add support for registering for `DBT_DEVTYPE_HANDLE` notifications, for which the `OBJECT_NAME_INFORMATION` value for the device `HANDLE` is used to filter notifications in order to correctly dispatch them to their registered callbacks. 4. Re-write the callbacks in `user32/input.c` to accept the `DEVICE_BROADCAST` union instead, and construct the appropriate `DEV_BROADCAST_*` struct from it, which gets sent to `SendMessageTimeoutW` as usual. Support for `DBT_DEVTYP_HANDLE` is needed for the Bluetooth driver stack I have been working on recently, which uses `DBT_DEVTYP_HANDLE` events to notify userspace about newly found Bluetooth devices during discovery and incoming authentication requests, as documented by MS [here](https://learn.microsoft.com/en-us/windows/win32/bluetooth/bluetooth-a…. -- v4: user32: Use the new plugplay definitions to registration device notifications, add support for DBT_DEVTYP_HANDLE events. sechost: Implement (un)registration of PnP events using the newly added types. ntoskrnl: Use the new plugplay definitions to send PnP events. plugplay: Use the newly added DEVICE_BROADCAST type to send and receive PnP events. include/wine: Add new header dbt.h from internal definitions used to implement PnP events. include/wine/plugplay: Separate device broadcast event types into their own structs. https://gitlab.winehq.org/wine/wine/-/merge_requests/6315

4 12

[PATCH v7 0/4] MR6260: mshtml: Misc improvements and fixes.
by Gabriel Ivăncescu Aug. 19, 2024

Aug. 19, 2024

-- v7: mshtml/tests: Accept rare return value from ReportResult on native. mshtml: Implement EmulateIE* modes for X-UA-Compatible. mshtml: Don't return default ports from location.host in IE10+ modes. mshtml: Avoid calling remove_target_tasks needlessly. https://gitlab.winehq.org/wine/wine/-/merge_requests/6260

2 7

[PATCH v3 0/6] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) Aug. 19, 2024

Aug. 19, 2024

PnP device notifications/events are currently sent and received from the `plugplay` service as the raw-bytes for the `DBT_DEVTYP_DEVICEINTERFACE` struct that needs to be sent from the PnP code in `ntoskrnl.exe`. While simple, it does not support sending `DBT_DEVTYP_HANDLE` events, as they also include a `HANDLE` to the device the event comes from, which cannot simply be sent as raw bytes. This MR reworks how notifications are sent and received from the `plugplay` service, by: 1. Introducing new structs `DEVICE_BROADCAST_HANDLE` and `DEVICE_BROADCAST_DEVICEINTERFACE` in `plugplay.idl`. The structs are similar to their counterparts in `dbt.h` without the `devicetype` and `size` fields added for the header. 2. Re-write `plugplay_{send,get}_event` to use the newly added union `DEVICE_BROADCAST`, which uses the `devicetype` value as the discriminant. A deep copy of this union is then appended to the event queue of every registered listener. 3. Re-write `I_ScRegisterDeviceNotification` and `device_notify_proc` in `sechost/service.c` to use the newly added types instead. Additionally, add support for registering for `DBT_DEVTYPE_HANDLE` notifications, for which the `OBJECT_NAME_INFORMATION` value for the device `HANDLE` is used to filter notifications in order to correctly dispatch them to their registered callbacks. 4. Re-write the callbacks in `user32/input.c` to accept the `DEVICE_BROADCAST` union instead, and construct the appropriate `DEV_BROADCAST_*` struct from it, which gets sent to `SendMessageTimeoutW` as usual. Support for `DBT_DEVTYP_HANDLE` is needed for the Bluetooth driver stack I have been working on recently, which uses `DBT_DEVTYP_HANDLE` events to notify userspace about newly found Bluetooth devices during discovery and incoming authentication requests, as documented by MS [here](https://learn.microsoft.com/en-us/windows/win32/bluetooth/bluetooth-a…. -- v3: user32: Use the new plugplay definitions to registration device notifications, add support for DBT_DEVTYP_HANDLE events. https://gitlab.winehq.org/wine/wine/-/merge_requests/6315

3 7

[PATCH 0/1] MR6312: win32u: Initialize parent_rect variables in window.c.
by Aida Jonikienė Aug. 19, 2024

Aug. 19, 2024

This fixes -Wmaybe-uninitialized warnings with GCC 14. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6312

2 2

[PATCH 0/6] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) Aug. 19, 2024

Aug. 19, 2024

PnP device notifications/events are currently sent and received from the `plugplay` service as the raw-bytes for the `DBT_DEVTYP_DEVICEINTERFACE` struct that needs to be sent from the PnP code in `ntoskrnl.exe`. While simple, it does not support sending `DBT_DEVTYP_HANDLE` events, as they also include a `HANDLE` to the device the event comes from, which cannot simply be sent as raw bytes. This MR reworks how notifications are sent and received from the `plugplay` service, by: 1. Introducing new structs `DEVICE_BROADCAST_HANDLE` and `DEVICE_BROADCAST_DEVICEINTERFACE` in `plugplay.idl`. The structs are similar to their counterparts in `dbt.h` without the `devicetype` and `size` fields added for the header. 2. Re-write `plugplay_{send,get}_event` to use the newly added union `DEVICE_BROADCAST`, which uses the `devicetype` value as the discriminant. A deep copy of this union is then appended to the event queue of every registered listener. 3. Re-write `I_ScRegisterDeviceNotification` and `device_notify_proc` in `sechost/service.c` to use the newly added types instead. Additionally, add support for registering for `DBT_DEVTYPE_HANDLE` notifications, for which the `OBJECT_NAME_INFORMATION` value for the device `HANDLE` is used to filter notifications in order to correctly dispatch them to their registered callbacks. 4. Re-write the callbacks in `user32/input.c` to accept the `DEVICE_BROADCAST` union instead, and construct the appropriate `DEV_BROADCAST_*` struct from it, which gets sent to `SendMessageTimeoutW` as usual. Support for `DBT_DEVTYP_HANDLE` is needed for the Bluetooth driver stack I have been working on recently, which uses `DBT_DEVTYP_HANDLE` events to notify userspace about newly found Bluetooth devices during discovery and incoming authentication requests, as documented by MS [here](https://learn.microsoft.com/en-us/windows/win32/bluetooth/bluetooth-a…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315

3 8

[PATCH v2 0/1] MR6305: odbccp32: SQLWritePrivateProfileStringW correctly hanndle ODBC_BOTH_DSN
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 19, 2024

Aug. 19, 2024

-- v2: odbccp32: SQLWritePrivateProfileStringW correctly hanndle ODBC_BOTH_DSN https://gitlab.winehq.org/wine/wine/-/merge_requests/6305

4 3

[PATCH 0/2] MR6313: kernel32: EnumCalendarInfo() should ignore CAL_RETURN_NUMBER flag.
by Dmitry Timoshkov (＠dmitry) Aug. 19, 2024

Aug. 19, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6313

2 2

[PATCH 0/1] MR6311: odbc32: Handle missing SQLSetConnect/EnvAttr().
by Hans Leidekker (＠hans) Aug. 19, 2024

Aug. 19, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6311

2 1

Re: [PATCH v20 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Ilia Docin (＠IDocin) Aug. 19, 2024

Aug. 19, 2024

On Mon Aug 19 09:19:13 2024 +0000, Zhiyi Zhang wrote: > There should be a test failing on Wine in this patch. Then you add a > todo_wine to make the test pass in this commit. Then in the next patch > after you've fixed the bug, the todo_wine should get removed. Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_79103

1 0

[PATCH v3 0/2] MR6300: Draft: wined3d: Don't reject cross-device blits.
by Aida Jonikienė Aug. 19, 2024

Aug. 19, 2024

I'm not sure this is 100% safe (maybe limiting those blits to sysmem textures would be better like stated in the original change?) -- v3: HACK: wined3d: Don't assert in CS thread check. https://gitlab.winehq.org/wine/wine/-/merge_requests/6300

1 2