September 2024 - Wine-GitLab

Re: [PATCH v2 0/1] MR6582: include: Add ISystemMediaTransportControls2 definition in windows.media.idl. - approved
by Alexandre Julliard (＠julliard) Sept. 30, 2024

Sept. 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6582

1 0

[PATCH 0/1] MR6585: win32u: Try the next top-level window if hit-testing the result window returns HTTRANSPARENT.
by Zhiyi Zhang (＠zhiyi) Sept. 30, 2024

Sept. 30, 2024

Fix clicking Toad for Oracle treeview nodes doesn't function. The left button click is sent to a top-level TSafeHintWindow, which returns HTTRANSPARENT when handling WM_NCHITTEST. Tests show that in such cases, the mouse message should be sent to the next top-level window in the z-order. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6585

4 3

Re: [PATCH v4 0/2] MR6443: comdlg32: allow entering a filter in the itemdlg file name field
by Charlotte Pabst (＠CharlottePabst) Sept. 30, 2024

Sept. 30, 2024

On Mon Sep 30 17:50:43 2024 +0000, Fabian Maurer wrote: > This introduced a regression: https://bugs.winehq.org/show_bug.cgi?id=57240 > Would you mind taking a look? I submitted a fix as !6589 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6443#note_83681

1 0

[PATCH v2 0/2] MR6584: wintab32: Improve wow64 support
by John Chadwick (＠jchw) Sept. 30, 2024

Sept. 30, 2024

wintab32 is currently broken in the new wow64 mode because the `tablet_get_packet` thunk in winex11.drv is not implemented. Since the structure it is copying is entirely internal to Wine, and the HCTX handle value is not actually read or written by the driver side, I found that simply padding the structure to keep the rest of it aligned was enough to make wow64 happy and allow wintab32 to function. This is somewhat a stopgap. What would be much better is to refactor the wintab code such that more of the logic is in the wintab32 implementation and not the driver. My goal is to accomplish this as part of trying to get my winewayland graphics tablet patch into an acceptable state for upstreaming. However, I think this is still a worthwhile improvement to have in the interim, if it is acceptable. -- v2: winex11: Remove stub tablet_get_packet wow64 thunk wintab32: Pad WTPACKET to align 32/64-bit archs https://gitlab.winehq.org/wine/wine/-/merge_requests/6584

3 7

[PATCH v2 0/2] MR6580: win32u: Correctly fill new foreground window TID in WM_ACTIVATEAPP.
by Paul Gofman (＠gofman) Sept. 30, 2024

Sept. 30, 2024

-- v2: win32u: Correctly fill new foreground window TID in WM_ACTIVATEAPP. win32u: Call set_active_window() helper directly from handle_internal_message(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6580

3 4

[PATCH 0/1] MR6580: win32u: Correctly fill new foreground window TID in WM_ACTIVATEAPP.
by Paul Gofman (＠gofman) Sept. 30, 2024

Sept. 30, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6580

5 10

[PATCH 0/1] MR6588: findstr: Preserve line endings.
by Hans Leidekker (＠hans) Sept. 30, 2024

Sept. 30, 2024

To preserve line endings we need to switch to binary mode which means we no longer get Unicode input. This is not a problem because native doesn't support it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6588

2 1

[PATCH 0/1] MR6587: ntdll: Return success for NtSetInformationProcess(ProcessPowerThrottlingState).
by Hans Leidekker (＠hans) Sept. 30, 2024

Sept. 30, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6587

2 1

[PATCH 0/1] MR6586: user32/tests: Test that DragDetect() uses client coordinates instead of screen coordinates.
by Zhiyi Zhang (＠zhiyi) Sept. 30, 2024

Sept. 30, 2024

Test that DragDetect() uses client coordinates instead of screen coordinates even though MSDN says that DragDetect() should use screen coordinates. This also means that Wine's current implementation is correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6586

3 2

[PATCH 0/2] MR6584: wintab32: Improve wow64 support
by John Chadwick (＠jchw) Sept. 30, 2024

Sept. 30, 2024

wintab32 is currently broken in the new wow64 mode because the `tablet_get_packet` thunk in winex11.drv is not implemented. Since the structure it is copying is entirely internal to Wine, and the HCTX handle value is not actually read or written by the driver side, I found that simply padding the structure to keep the rest of it aligned was enough to make wow64 happy and allow wintab32 to function. This is somewhat a stopgap. What would be much better is to refactor the wintab code such that more of the logic is in the wintab32 implementation and not the driver. My goal is to accomplish this as part of trying to get my winewayland graphics tablet patch into an acceptable state for upstreaming. However, I think this is still a worthwhile improvement to have in the interim, if it is acceptable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6584

3 3