September 2024 - Wine-GitLab

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering.
by Paul Gofman (＠gofman) Sept. 19, 2024

Sept. 19, 2024

> VK_KHR_present_wait isn't equivalent, because it signals the event on first pixel out, which is too soon. That's unfortunate, I was thinking VK_KHR_present_wait will solve these problems (which are real WRT games too in some cases) until we have a "direct composition" implementation. Are you sure that this is supposed and actual behaviour? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467#note_82701

1 0

[PATCH 0/1] MR6531: po: Update Lithuanian translation.
by Aurimas Fišeras Sept. 19, 2024

Sept. 19, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6531

1 1

Re: [PATCH v3 0/5] MR6524: tools: Replace sprintf with snprintf to avoid deprecation warnings on macOS. - approved
by Alexandre Julliard (＠julliard) Sept. 19, 2024

Sept. 19, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6524

1 0

Re: [PATCH v2 0/10] MR6529: desk.cpl: Introduce new control panel applet. - approved
by Alexandre Julliard (＠julliard) Sept. 19, 2024

Sept. 19, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6529

1 0

Re: [PATCH v4 0/1] MR6372: winewayland: Make the pointer protocols optional. - approved
by Alexandre Julliard (＠julliard) Sept. 19, 2024

Sept. 19, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6372

1 0

Re: [PATCH v2 0/1] MR6530: ntdll: Ensure Unix path strings are wrapped with debugstr_a in traces. - approved
by Alexandre Julliard (＠julliard) Sept. 19, 2024

Sept. 19, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6530

1 0

Re: [PATCH v2 0/1] MR6528: netapi32: Add a stub NetFreeAadJoinInformation function. - approved
by Alexandre Julliard (＠julliard) Sept. 19, 2024

Sept. 19, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6528

1 0

Re: [PATCH v4 0/7] MR6519: win32u: Get rid of NtUserIsWindowRectFullScreen calls. - approved
by Alexandre Julliard (＠julliard) Sept. 19, 2024

Sept. 19, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6519

1 0

Re: [PATCH v2 0/2] MR6525: Remove some pre-macOS 10.12 workarounds (clock_gettime and mach_continuous_time) - approved
by Alexandre Julliard (＠julliard) Sept. 19, 2024

Sept. 19, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6525

1 0

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering.
by Elizabeth Figura (＠zfigura) Sept. 19, 2024

Sept. 19, 2024

I don't think this architecture is going to work. It probably isn't evident from games testing, but there is a synchronization problem here. We can't simply do vkQueuePresent() and then copy from the corresponding X11 drawable, because vkQueuePresent() won't guarantee that the bits have reached the X11 drawable yet. For GLX this approach is fine, assuming we have GLX_OML_sync_control. In that case waiting for SBC is exactly what we need. Vulkan doesn't have an equivalent extension. VK_KHR_present_wait isn't equivalent, because it signals the event on first pixel out, which is too soon. This means we probably need to virtualize the whole swapchain, unfortunately, and either create a Vulkan swapchain on the relevant top-level window, or use DRI3 to interop between Vulkan and X11 without a swapchain. In this case vkQueuePresent() would of course not present directly. We could also try to invent an extension that lets us do what GLX_OML_sync_control does, but I fear that Mesa and/or Khronos will push back on this, and basically tell us to fix it on our end, by virtualizing the swapchain... There may be reasons we can't virtualize the swapchain that I'm not thinking of. I also have zero knowledge of Wayland and don't know how to fit that into anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467#note_82685

1 0