September 2024 - Wine-GitLab

Re: [PATCH v2 0/6] MR6491: mfsrcsnk: Initialize a stream map, sorted for specific mime types.
by Emil Velikov (＠xexaxo) Sept. 14, 2024

Sept. 14, 2024

Emil Velikov (@xexaxo) commented about dlls/winedmo/winedmo.spec: > @ cdecl winedmo_demuxer_check(str) > @ cdecl winedmo_demuxer_create(wstr ptr ptr ptr ptr ptr ptr) > @ cdecl winedmo_demuxer_destroy(ptr) > +@ cdecl winedmo_demuxer_stream_type(int64 ptr ptr) Unless I'm missing something, the arguments don't seem to match the declaration/definition. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6491#note_82220

1 0

[PATCH v2 0/5] MR6490: winsock: Avoid short writes on nonblocking sockets.
by Paul Gofman (＠gofman) Sept. 13, 2024

Sept. 13, 2024

-- v2: server: Correct STATUS_NOT_FOUND return from (cancel_async). ntdll: Don't cancel background socket sends. ntdll: Locally duplicated socket fd for background send. ntdll: Avoid short writes on nonblocking sockets. ws2_32/Tests: Add tests for send buffering. https://gitlab.winehq.org/wine/wine/-/merge_requests/6490

5 16

[PATCH v3 0/6] MR6446: ntdll: Support process instrumentation callback.
by Paul Gofman (＠gofman) Sept. 13, 2024

Sept. 13, 2024

-- v3: ntdll: Support old parameter layout for NtSetInformationProcess( ProcessInstrumentationCallback ). ntdll: Call instrumentation callback for KiUserModeCallback on x64. ntdll: Call instrumentation callback for LdrInitializeThunk on x64. ntdll: Call instrumentation callback for KiUserExceptionDispatcher on x64. ntdll: Call instrumentation callback from wine_syscall_dispatcher on x64. ntdll/tests: Add more tests for process instrumentation callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/6446

4 10

Re: [PATCH v7 0/5] MR6375: mshtml: Don't process tasks recursively. - approved
by Alexandre Julliard (＠julliard) Sept. 13, 2024

Sept. 13, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6375

1 0

Re: [PATCH v2 0/1] MR6493: gdiplus: Fix assignment of result in GdipCloneBrush. - approved
by Alexandre Julliard (＠julliard) Sept. 13, 2024

Sept. 13, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6493

1 0

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering. - approved
by Alexandre Julliard (＠julliard) Sept. 13, 2024

Sept. 13, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467

1 0

Re: [PATCH v2 0/6] MR6491: mfsrcsnk: Initialize a stream map, sorted for specific mime types. - approved
by Alexandre Julliard (＠julliard) Sept. 13, 2024

Sept. 13, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6491

1 0

Re: [PATCH v2 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Philipp Knechtges (＠d1saster) Sept. 13, 2024

Sept. 13, 2024

I am bit puzzled, why the rebased commits start failing the tests. Seems unrelated to the d2d1 fixes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_82178

1 0

Re: [PATCH v2 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Philipp Knechtges (＠d1saster) Sept. 13, 2024

Sept. 13, 2024

On Fri Sep 13 18:40:16 2024 +0000, Nikolay Sivov wrote: > It looks to me that there won't be any way to retroactively apply fill > mode later, once you have copied all the vertices. But I'm not sure > what's the correct way would be here. In my opinion the correct way would probably be populating a joint CDT from all the geometries and then erasing triangles depending on the fill_mode. However, this is a bigger undertaking and for the [bug](https://bugs.winehq.org/show_bug.cgi?id=51139) at hand it suffices to just concatenate all lists, since it seems the application uses the geometry groups for assembling glyphs to words and render them all at once. Due to the latter, there is no intersection between the different geometric entities. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_82177

1 0

Re: [PATCH v2 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Nikolay Sivov (＠nsivov) Sept. 13, 2024

Sept. 13, 2024

Nikolay Sivov (@nsivov) commented about dlls/d2d1/geometry.c: > HRESULT d2d_geometry_group_init(struct d2d_geometry *geometry, ID2D1Factory *factory, > D2D1_FILL_MODE fill_mode, ID2D1Geometry **geometries, unsigned int geometry_count) > { > - unsigned int i; > + unsigned int i, j; > + struct d2d_geometry *other_geom; > + D2D_MATRIX_3X2_F g, gplain; > + size_t f_vertex_count, f_face_count, f_bezier_vertex_count, f_arc_vertex_count; > + size_t o_vertex_count, o_face_count, o_bezier_count, o_bezier_face_count, o_arc_count, o_arc_face_count; > > + FIXME("Ignoring fill_mode=%#x!\n", fill_mode); It looks to me that there won't be any way to retroactively apply fill mode later, once you have copied all the vertices. But I'm not sure what's the correct way would be here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_82167

1 0