September 2024 - Wine-GitLab

[PATCH v4 0/4] MR2127: ntdll: Load known dlls from system directory
by Paul Gofman (＠gofman) May 15, 2025

May 15, 2025

The practical issue I am trying to solve is the following scenario (encountered with a game using some Uplay plugin) which has regressed with apisets implementation in Wine. The game imports ucrtbase.dll. Then, a plugin calls GetModuleHandle("api-ms-win-crt-runtime-l1-1-0.dll") and expects GetProcAddress("\_crt_atexit") to succeed on the returned handle. The problem is that the game has ucrtbase.dll in its .exe directory. That one currently gets loaded. Then, find_dll_file() resolves api-ms-win-crt-runtime-l1-1-0.dll to the ucrtbase with a full path in system32 and tries to find that one (this part matches Windows behaviour as far as tests show). Since we have ucrtbase loaded with another path this results in NULL module handle. Windows maintains the list of "Known DLLs" (probably aimed for speeding up processes startup by using pre-mapped dll images for commonly used system dlls). On Windows, known dlls have specifics in load path resolution when dll name doesn't contain path (relative or full): - they are loaded from system directory even if there is another dll with the same name in priority search path; - they are found even if library search paths do not contain system directory; Those "Known DLLs" are basically listed in HKLM\\System\\CurrentControlSet\\Control\\Session Manager\KnownDLLs registry key. But the actual list of "known dlls" is bigger (probably includes all dependencies of those listed under registry key). The full actual list of "known dlls" is in '\\KnownDlls\' directory object which contains image sections under dll names. Most notably, ucrtbase.dll (which is of the concern in the regression) is not listed in registry but is present in \\KnownDlls. Technically nothing prevents us from implementing these mechanics and creating directory object with mapped load dlls, also resolving the explicitly listed dlls' dependencies. But it is not apparent to me if that is going to improve load times noticably in Wine, and also that is worth the inherent complications until anything actually depends on that \\KnownDlls sections. So instead of implementing all of that throughout the loader I added a few missing dlls to registry. The current list in this pat chset corresponds to the contents of \\KnownDlls directory on an up to date Windows 10. -- v4: ntdll: Load known dlls from system directory. loader/wine.inf: Add known dlls key. ntdll: Factor out prepend_system_dir() function. kernel32/tests: Add tests for known dlls load specifics. https://gitlab.winehq.org/wine/wine/-/merge_requests/2127

4 8

[PATCH 0/1] MR4635: ntdll: Avoid abort process when internal string printing function used for debugging.
by 江仪陈 April 29, 2025

April 29, 2025

Description: The printing function (non-Windows application call) used by Wine developers is unnecessary to abort process when the string is super long. For example, the developer prints a long commandline of wwmapp.exe by MESSAGE. As a result, the process cannot be started, and the conference function cannot be used. Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: If06f0309f9745777f89b07dff8d302cb34b2a90e -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4635

3 2

[PATCH 0/2] MR5285: AMD Radeon Vega 7 Renoir pci-ids
by Carlos Rodriguez (＠mrdeathjr28) April 24, 2025

April 24, 2025

With this patch wine can recognize amd radeon vega 7 renoir (actually appears like radeon RX 5600) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5285

4 5

[PATCH v3 0/1] MR5013: msi: Properly select first feature
by Fabian Maurer (＠DarkShadow44) April 19, 2025

April 19, 2025

We need to select the first feature when all controls are created, otherwise they are not properly updated Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56290 -- v3: msi: Properly select first feature. https://gitlab.winehq.org/wine/wine/-/merge_requests/5013

2 4

[PATCH v2 0/2] MR5068: win32u: Fix rendering of the rotated and scaled text.
by Dmitry Timoshkov (＠dmitry) April 7, 2025

April 7, 2025

These patches make a test case attached to the bug https://bugs.winehq.org/show_bug.cgi?id=33190 work. -- v2: win32u: NtGdiExtTextOutW() should translate x,y from logical to device units at the last step. win32u: Fix device<->world width/height converters. https://gitlab.winehq.org/wine/wine/-/merge_requests/5068

4 16

[PATCH 0/1] MR4740: ntdll: Don't hardcode pagesize when allocating handles
by Fabian Maurer (＠DarkShadow44) April 2, 2025

April 2, 2025

Not really needed for 16k pages, but since the comment says "one page" the logic should reflect that. Not 100% sure about that since I don't know why it should use exactly one page, so please double check. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4740

2 2

[PATCH 0/2] MR4738: ntdll/unix: Don't hardcode page_size, page_shift and page_mask
by Fabian Maurer (＠DarkShadow44) March 31, 2025

March 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52715 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4738

3 4

[PATCH v2 0/1] MR4739: ntdll: Don't hardcode page size
by Fabian Maurer (＠DarkShadow44) March 31, 2025

March 31, 2025

While this is not needed for 16k pages to work, it does seem sensible. -- v2: ntdll: Don't hardcode page size https://gitlab.winehq.org/wine/wine/-/merge_requests/4739

3 3

[PATCH v2 0/1] MR3868: user32/tests: Account for some messages from dual-monitor setups.
by Esme Povirk (＠madewokherd) March 28, 2025

March 28, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54031 -- v2: user32/tests: Account for some messages from dual-monitor setups. https://gitlab.winehq.org/wine/wine/-/merge_requests/3868

3 2

[PATCH v67 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) March 25, 2025

March 25, 2025

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v67: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

8 21