September 2024 - Wine-GitLab

Re: [PATCH v4 0/2] MR6225: Populate ARM64 ID register registry keys using the SMBIOS.
by Billy Laws (＠bylaws) Sept. 6, 2024

Sept. 6, 2024

On Fri Sep 6 20:47:12 2024 +0000, Martin Storsjö wrote: > FYI, this isn't universally the case - Linux trapping and emulating them > hasn't been around since forever. > Linux v4.11 added `HWCAP_CPUID`, and if this hwcap is enabled, the > trapping is supported. (I'm not sure if there are kernels past 4.11 that > don't have it set, though.) I do run wine on arm64 on a couple of old > devboards that run Linux 4.4 kernels - although I haven't updated my > version of Wine on them for quite a while... > Anyway, ideally, we'd check `getauxval(AT_HWCAP) & HWCAP_CPUID` before > going ahead and trying to read these registers - even if few users today > really run older kernels. Ah yep, realised this earlier but forgot to address, will Mr a fix -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6225#note_81553

1 0

Re: [PATCH v4 0/2] MR6225: Populate ARM64 ID register registry keys using the SMBIOS.
by Martin Storsjö Sept. 6, 2024

Sept. 6, 2024

Martin Storsjö (@mstorsjo) commented about dlls/ntdll/unix/system.c: > + snprintf( path_buf, sizeof(path_buf), midr_el1_path, logical_thread_id ); > + if ((fp = fopen( path_buf, "r" ))) > + { > + fscanf( fp, "%lx", &value ); > + fclose( fp ); > + regs[regidx++] = (struct smbios_wine_id_reg_value_arm64){ 0x4000, value }; > + } > + > +#define STR(a) #a > +#define READ_ID_REG(reg_id) \ > + /* mrs x0, #reg_id */ \ > + __asm__ __volatile__( ".inst " STR(0xd5300000 | reg_id << 5) "\n\t" \ > + "mov %0, x0" : "=r"(value) :: "x0" ); \ > + regs[regidx++] = (struct smbios_wine_id_reg_value_arm64){ reg_id, value }; > + > + /* Linux traps reads to these ID registers and emulates them. They do not vary across cores, FYI, this isn't universally the case - Linux trapping and emulating them hasn't been around since forever. Linux v4.11 added `HWCAP_CPUID`, and if this hwcap is enabled, the trapping is supported. (I'm not sure if there are kernels past 4.11 that don't have it set, though.) I do run wine on arm64 on a couple of old devboards that run Linux 4.4 kernels - although I haven't updated my version of Wine on them for quite a while... Anyway, ideally, we'd check `getauxval(AT_HWCAP) & HWCAP_CPUID` before going ahead and trying to read these registers - even if few users today really run older kernels. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6225#note_81475

1 0

Re: [PATCH v3 0/3] MR6454: msvcrt: Some FIXME once stuff. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2024

Sept. 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6454

1 0

Re: [PATCH v2 0/1] MR6417: widl: Avoid using sprintf() to add a single character. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2024

Sept. 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6417

1 0

Re: [PATCH v2 0/1] MR6449: ntdll: Allow sending to port 0 on UDP socket to succeed. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2024

Sept. 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6449

1 0

Re: [PATCH v4 0/8] MR6441: quartz: Register the classes from their native DLLs. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2024

Sept. 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6441

1 0

Re: [PATCH v2 0/1] MR6432: winegstreamer: Allow application to drain queue. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2024

Sept. 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6432

1 0

Re: [PATCH v16 0/4] MR6304: comctl32/edit: Fix incorrect size for format rect. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2024

Sept. 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6304

1 0

Re: [PATCH v3 0/3] MR6451: odbc32: Load libodbc dynamically. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2024

Sept. 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6451

1 0

Re: [PATCH v4 0/2] MR6225: Populate ARM64 ID register registry keys using the SMBIOS. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2024

Sept. 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6225

1 0