January 2025 - Wine-GitLab - list.winehq.org

[PATCH v3 0/7] MR7174: rtworkq: Fix handling of platform startup and lock counts.
by Conor McCarthy (＠cmccarthy) Jan. 30, 2025

Jan. 30, 2025

Startup and lock counts in native Windows are separate, and the lock count does not decrease when an async result is freed if the platform has been started. -- v3: rtworkq: Do not unlock the platform when async result objects are freed if the platform is started. rtworkq: Introduce a platform startup count. rtworkq/tests: Test work queue. mfplat/tests: Test platform startup and lock counts. mfplat/tests: Test mixing of MF platform functions with their Rtwq equivalents. mfplat/tests: Introduce a helper to check the platform lock count. mfplat/tests: Release callback2 in test_event_queue(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7174

3 9

[PATCH v7 0/4] MR7216: winebth.sys part 3: Introduce IOCTLs related to radio discoverability, connectability and device inquiry.
by Vibhav Pant (＠vibhavp) Jan. 30, 2025

Jan. 30, 2025

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio, and to start/stop the device inquiry procedure. This MR introduces 3 wine-specific IOCTL codes for the same purposes, as most applications seem to the Win32 API itself for these operations: * IOCTL_WINBTH_RADIO_SET_FLAG * IOCTL_WINEBTH_RADIO_START_DISCOVERY * IOCTL_WINEBTH_RADIO_STOP_DISCOVERY -- v7: winebth.sys: Call bluez_watcher_close as part of bluetooth_shutdown. winebth.sys: Implement IOCTL_WINEBTH_RADIO_STOP_DISCOVERY. winebth.sys: Implement IOCTL_WINEBTH_RADIO_START_DISCOVERY. https://gitlab.winehq.org/wine/wine/-/merge_requests/7216

3 5

[PATCH v6 0/4] MR7216: winebth.sys part 3: Introduce IOCTLs related to radio discoverability, connectability and device inquiry.
by Vibhav Pant (＠vibhavp) Jan. 30, 2025

Jan. 30, 2025

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio, and to start/stop the device inquiry procedure. This MR introduces 3 wine-specific IOCTL codes for the same purposes, as most applications seem to the Win32 API itself for these operations: * IOCTL_WINBTH_RADIO_SET_FLAG * IOCTL_WINEBTH_RADIO_START_DISCOVERY * IOCTL_WINEBTH_RADIO_STOP_DISCOVERY -- v6: winebth.sys: Call bluez_watcher_close as part of bluetooth_shutdown. winebth.sys: Implement IOCTL_WINEBTH_RADIO_STOP_DISCOVERY. winebth.sys: Implement IOCTL_WINEBTH_RADIO_START_DISCOVERY. winebth.sys: Implement IOCTL_WINEBTH_RADIO_SET_FLAG. https://gitlab.winehq.org/wine/wine/-/merge_requests/7216

4 7

[PATCH v3 0/9] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) Jan. 30, 2025

Jan. 30, 2025

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v3: dlls/oleaut32: Implement SetHelpStringContext() dlls/oleaut32: Add DeleteTypeInfo() base-cases in typelib.c dlls/oleaut32: Allow TLB_get_typeinfo_by_name() to also return the index dlls/oleaut32: Disambiguate pIndex in typelib.c dlls/oleaut32: Avoid possible infinite loops and invalid mem access dlls/oleaut32: Simplify SLTG_DoRefs() readability dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND dlls/oleaut32: Consistently use lstrcmpiW() while looking for names dlls/oleaut32: Simplify loop in ITypeLib2_Constructor_MSFT() https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

3 10

[PATCH 0/1] MR7229: ntdll: Stub NtQuerySystemInformation(SystemLeapSecondInformation).
by Hans Leidekker (＠hans) Jan. 30, 2025

Jan. 30, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7229

4 3

[PATCH 0/1] MR7228: compstui: Add more string resources.
by Dmitry Timoshkov (＠dmitry) Jan. 30, 2025

Jan. 30, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7228

3 2

[PATCH v2 0/1] MR7174: mfplat: Introduce a MF startup count.
by Conor McCarthy (＠cmccarthy) Jan. 30, 2025

Jan. 30, 2025

In cases where MF is already shut down, simply forwarding MFShutdown() to RtwqShutdown() will corrupt the Rtwq lock count if async result objects still exist, because they hold a lock. JR East Train Simulator does this. -- v2: mf: Release the sample if stream sink processing fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/7174

3 2

[PATCH v9 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) Jan. 30, 2025

Jan. 30, 2025

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v9: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

3 5

[PATCH v8 0/3] MR7158: wine.inf.in: Add UBR key
by Etaash Mathamsetty (＠etaash.mathamsetty) Jan. 30, 2025

Jan. 30, 2025

Required by Logitech G Hub -- v8: twinapi/tests: Fix broken registry query. https://gitlab.winehq.org/wine/wine/-/merge_requests/7158

3 4

Re: [PATCH v7 0/3] MR7158: wine.inf.in: Add UBR key
by Etaash Mathamsetty (＠etaash.mathamsetty) Jan. 30, 2025

Jan. 30, 2025

turns out twinapi test failed because of a silly mistake in the test lol -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7158#note_93247

1 0