January 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR7132: gdiplus/tests: Trace locked bitmap data on failure. - approved
by Alexandre Julliard (＠julliard) Jan. 14, 2025

Jan. 14, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7132

1 0

Re: [PATCH v2 0/1] MR7147: mf/topology_loader: Avoid modifying downstream media type when attempting to connect. - approved
by Alexandre Julliard (＠julliard) Jan. 14, 2025

Jan. 14, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7147

1 0

Re: [PATCH v2 0/1] MR7134: kernel32/tests: Avoid stack-buffer-overflow in get_com_dir_size. (ASan) - approved
by Alexandre Julliard (＠julliard) Jan. 14, 2025

Jan. 14, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7134

1 0

Re: [PATCH v3 0/1] MR7135: gdiplus/tests: Fix double free of a graphics object (ASan). - approved
by Alexandre Julliard (＠julliard) Jan. 14, 2025

Jan. 14, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7135

1 0

[PATCH 0/1] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) Jan. 14, 2025

Jan. 14, 2025

"DIR /o" (no order specifier after /o) hasn't functioned the same as it does on Windows. This change makes the functionality of /o by itself equivalent to behavior on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131

3 8

[PATCH 0/1] MR7144: windows.networking.hostname: Guard against WindowsDuplicateString() failure.
by Mohamad Al-Jaf (＠maljaf) Jan. 14, 2025

Jan. 14, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7144

3 2

[PATCH 0/1] MR7147: mf/topology_loader: Avoid modifying downstream media type when attempting to connect.
by Rémi Bernon Jan. 14, 2025

Jan. 14, 2025

Fixes Soulcalibur VI video playback when MF pipelines are used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7147

2 2

[PATCH 0/4] MR7143: dlls, tools: transferring strlen calls out of bounds loops
by Herman Semenov (＠GermanAizek) Jan. 14, 2025

Jan. 14, 2025

This is more code refactoring than micro-optimization. Modern compilers may skip optimizations in some places, so we strictly make it clear to them that we need common variable to determine const result strlen() function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7143

5 8

Re: [PATCH v8 0/1] MR4174: shell32: Add Internet Explorer toolbar icons.
by Alex Henrie (＠alexhenrie) Jan. 14, 2025

Jan. 14, 2025

On Tue Jan 14 07:51:31 2025 +0000, Jacek Caban wrote: > Sorry for the delay, I'm not sure what to think about it. If it's > dropped in modern Windows, it's not clear if we want it. I guess it > wouldn't hurt... > We usually add SVGs so that maintainer mode can generate binary blobs. > It seems that Tango theme repo contains SVGs, could we use them? Hi Jacek, thanks for the review. When I wrote this patch, I considered combining the Tango SVGs into a single SVG file that would be converted to a PNG when building in Wine maintainer mode, but it turned out to be more trouble than it was worth. It's trivial to combine PNG files with ImageMagick, whereas combining SVG files requires a lot of manual effort. Moreover, no one cares about modifying these icons or has made an argument for why different icons would be better than the Tango defaults. And if in the future someone decides to import the SVGs into Wine, the resulting PNG will still have to be regenerated and replaced in the Git repository; we have to have a PNG in Git regardless of how it is created. It seems to me that we either need to merge a patch like the one I am proposing, or we need to close [Bug 40236](https://bugs.winehq.org/show_bug.cgi?id=40236) as WONTFIX and remove the [patches in Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/s…. The most important thing is just to make a decision. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4174#note_91975

1 0

Re: [PATCH v2 0/1] MR7135: gdiplus/tests: Fix use-after-free of a graphics object (ASan). - approved
by Esme Povirk (＠madewokherd) Jan. 13, 2025

Jan. 13, 2025

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7135

1 0