January 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/7] MR6911: Draft: ntdll: Add WaitCompletionPacket.
by Jinoh Kang (＠iamahuman) Jan. 11, 2025

Jan. 11, 2025

Jinoh Kang (@iamahuman) commented about server/thread.c: > + { > + struct wait_completion_packet *packet; > + > + LIST_FOR_EACH_ENTRY( packet, &obj->wait_completion_packet_queue, struct wait_completion_packet, entry ) > + { > + list_remove( &packet->entry ); > + release_object( packet->target ); > + packet->in_object_packet_queue = 0; > + packet->target = NULL; > + > + add_completion( packet->completion, packet->ckey, packet->cvalue, packet->status, > + packet->information, packet ); > + packet->in_completion_queue = 1; > + } > + } > + General advice: you should try not to leak implementation details of certain object (wait completion packet) into other types of objects. For example, if this piece of code is still to be preserved, you should move this into a helper completion.c, declare as extern in object.h (or file.h), and call that. That way, you don't have to define the entire `struct wait_completion_packet` in a shared header file. If this were factored into a helper, a simple forward declaration would have sufficed in the `file.h` side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6911#note_91785

1 0

[PATCH 0/1] MR7129: ntoskrnl.exe: Fix IRQL mismatch between cancel spin lock acquire and release.
by Jinoh Kang (＠iamahuman) Jan. 11, 2025

Jan. 11, 2025

Use the irql assigned by IoAcquireCancelSpinLock, not the (yet-to-be-assigned) irp->CancelIrql. This is for readability. No semantic change is expected with unmodified ntoskrnl.exe/hal.dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7129

3 2

[PATCH v2 0/1] MR7129: ntoskrnl.exe: Fix IRQL mismatch between cancel spin lock acquire and release.
by Jinoh Kang (＠iamahuman) Jan. 11, 2025

Jan. 11, 2025

Use the irql assigned by IoAcquireCancelSpinLock, not the (yet-to-be-assigned) irp->CancelIrql. This is for readability. Since IoReleaseCancelSpinLock() ignores the IRQL argument anyway, no semantic change is expected with unmodified ntoskrnl.exe/hal.dll. -- v2: ntoskrnl.exe: Fix IRQL mismatch between cancel spin lock acquire and release. https://gitlab.winehq.org/wine/wine/-/merge_requests/7129

2 1

Re: [PATCH v2 0/1] MR7124: mfmediaengine: Fix maths in scaling check. - approved
by Alexandre Julliard (＠julliard) Jan. 10, 2025

Jan. 10, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7124

1 0

Re: [PATCH v2 0/4] MR7057: Draft: amstream: Stop stream while running CreateSample. Feedback needed. :-)
by Santino Mazza (＠tati) Jan. 10, 2025

Jan. 10, 2025

On Sat Dec 21 08:41:22 2024 +0000, Anton Baskanov wrote: > The correct way to fix this is to implement a custom allocator like it > is done in the native AMDirectDrawStream. This will allow changing the > format on the fly without stopping the stream. But it of course requires > much more work, including adding format change support to decoders. Thanks for the feedback! I started reading about dynamic format changing and dynamic reconnecting from your comment, so now I have a better idea on how to continue with this. :-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7057#note_91771

1 0

[PATCH v3 0/1] MR7108: tools: Add manual-run job for new-style wow64.
by Jinoh Kang (＠iamahuman) Jan. 10, 2025

Jan. 10, 2025

The new job is only triggered when a developer manually starts it. Before run, it initially appears as a "skipped" job when the pipeline starts. -- v3: tools: Add manual-run job for new-style wow64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7108

3 2

[PATCH v6 0/3] MR6891: cmd: Use CD /D to change directory in POPD (same as PUSHD).
by huangqinjin (＠huangqinjin) Jan. 10, 2025

Jan. 10, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57137 -- v6: cmd: Set =C: environment variable if POPD succeeds (same as PUSHD). cmd: Refactor CD command. cmd/tests: Add tests for POPD with directory that no longer exists. https://gitlab.winehq.org/wine/wine/-/merge_requests/6891

3 4

[PATCH 0/1] MR7124: mfmediaengine: Fix maths in scaling check.
by Brendan McGrath (＠redmcg) Jan. 10, 2025

Jan. 10, 2025

This fixes a bug introduced in commit 7868484f04680c17cf56265c4cc0cb2319959a94. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7124

4 4

[PATCH 0/4] MR7125: mfreadwrite/tests: Add some tests.
by Ziqing Hui (＠zhui) Jan. 9, 2025

Jan. 9, 2025

I have some local patches which implements more of the writer. I'm going to submit a new MR once they are ready. Now just submit the tests MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7125

3 5

[PATCH v3 0/1] MR7091: windowscodecs: Make values returned from CanConvert consistent
by Jeffrey Smith (＠whydoubt) Jan. 9, 2025

Jan. 9, 2025

Any time CanConvert returns FALSE for the output parameter, also return an appropriate failing result code. This also adds tests for CanConvert. -- v3: windowscodecs: Make values returned from CanConvert consistent https://gitlab.winehq.org/wine/wine/-/merge_requests/7091

2 1