October 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR9162: shell32: Set SFGAO_HASSUBFOLDER correctly for normal shellfolders. - approved
by Alexandre Julliard (＠julliard) Oct. 15, 2025

Oct. 15, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9162

1 0

[PATCH v4 0/2] MR6408: odbc32: Handle odbcv2 for GetData
by Alistair Leslie-Hughes (＠alesliehughes) Oct. 15, 2025

Oct. 15, 2025

-- v4: odbc32: SQLColAttributesW support ODBC v2.0 odbc32: SQLGetData support ODBC v2.0 https://gitlab.winehq.org/wine/wine/-/merge_requests/6408

2 2

[PATCH v21 0/10] MR7797: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().
by Matteo Bruni (＠Mystral) Oct. 15, 2025

Oct. 15, 2025

This fixes Trials Fusion often crashing when disconnecting a controller while there are more still connected. -- v21: ntoskrnl/tests: Use the 'Nt' version of the CancelIo APIs. ntoskrnl/tests: Test the thread ID the cancellation routine runs from. ntoskrnl/tests: Add more cancellation tests. ntoskrnl/tests: Fix tests on current Windows 10 / 11. ntdll/tests: Test IOSB values of the cancel operation. ntdll/tests: Add more NtCancelIoFile[Ex]() tests. ntdll: Wait for all asyncs to handle cancel in NtCancelIoFile(). server: Factor out a cancel_async() function. server: Introduce a find_async_from_user helper. ntdll: Factor out a cancel_io() function. https://gitlab.winehq.org/wine/wine/-/merge_requests/7797

3 10

[PATCH 0/3] MR9182: dmscript: Code cleanups related to loading the Script form
by Michael Stefaniuc (＠mstefani) Oct. 15, 2025

Oct. 15, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9182

2 4

[PATCH v12 0/2] MR8887: mf/tests: Test H.264 sink media type height alignment.
by Conor McCarthy (＠cmccarthy) Oct. 15, 2025

Oct. 15, 2025

H.264 uses a 16-pixel alignment, and the stream sink media type should have the aligned height after the session has started. -- v12: mf/tests: Test H.264 decoder alignment. mf/tests: Test H.264 sink media type height alignment. https://gitlab.winehq.org/wine/wine/-/merge_requests/8887

2 3

[PATCH v5 0/6] MR9150: comctl32: Remove v6 only exports.
by Zhiyi Zhang (＠zhiyi) Oct. 15, 2025

Oct. 15, 2025

-- v5: comctl32: Remove v6 only exports. comctl32: Remove syslink from comctl32 v5. comctl32: Remove taskdialog from comctl32 v5. comctl32/tests: Test v6 only exports. comctl32: Remove user32 control copies in comctl32 v5. https://gitlab.winehq.org/wine/wine/-/merge_requests/9150

3 10

[PATCH 0/1] MR9178: ntdll: Use load / acquire instruction to get pointer value in RtlRunOnceBeginInitialize
by Luca Bacci (＠lb90) Oct. 15, 2025

Oct. 15, 2025

The `RtlRunOnce` family of functions are implemented using (a variant of) the Double Checked Locking Pattern (DCLP). The DCLP requires memory fences for correctness, on both the writer and reader sides. It's pretty obvious why it's needed on the writer side, but quite surprising that any is needed on the reader side! On strong memory model architectures (x86 and x86_64), only compiler-level fences are required. On weak memory model architectures like ARM64, instead, you need both CPU and compiler fences. That's explained well in books like _Concurrent Programming on Windows_ by Joe Duffy and in online resources like [1]. The Wine implementation has fences on the writing side (`RtlRunOnceComplete`). That's because `InterlockedCompareExchangePointer` inserts a full memory fence. However some code paths on the reader side (`RtlRunOnceBeginInitialize`) are missing fences, specifically the (`RTL_RUN_ONCE_CHECK_ONLY`) branch and the (`!RTL_RUN_ONCE_CHECK_ONLY && (val & 3) == 2`) branch. Add the missing fences using GCC's atomic builtins [2] Note: with this MR, the generated code should change only for ARM64 ### References: 1. [Double-Checked Locking is Fixed In C++11](https://preshing.com/20130930/double-checked-locking-is-fixed-in-cpp… 2. [GCC's Built-in Functions for Memory Model Aware Atomic Operations](https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.ht… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9178

4 7

Re: [PATCH v3 0/6] MR8261: comctl32/tests: Check RGB value in test_alpha.
by Ziqing Hui (＠zhui) Oct. 15, 2025

Oct. 15, 2025

On Fri Oct 10 03:30:29 2025 +0000, Zhiyi Zhang wrote: > Hi, Ziqing, the comctl32 v5 and v6 separation is done. You can use > __WINE_COMCTL32_VERSION to check the comctl32 version. See > https://gitlab.winehq.org/wine/wine/-/merge_requests/9150/diffs?commit_id=e… > for example. You can start working on v6 specific behaviors. Thanks a lot for your work! Now I can move this forwards. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8261#note_118575

1 0

[PATCH v11 0/3] MR8887: mf/tests: Test H.264 sink media type height alignment.
by Conor McCarthy (＠cmccarthy) Oct. 15, 2025

Oct. 15, 2025

H.264 uses a 16-pixel alignment, and the stream sink media type should have the aligned height after the session has started. -- v11: trace test failures https://gitlab.winehq.org/wine/wine/-/merge_requests/8887

2 3

[PATCH 0/1] MR9179: bcrypt: Support import/export for generic ECDH/ECDSA algorithms.
by Hans Leidekker (＠hans) Oct. 15, 2025

Oct. 15, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9179

2 1