October 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/7] MR9315: comctl32/ipaddress: Add a helper to get the theme text state. - approved
by Alexandre Julliard (＠julliard) Oct. 30, 2025

Oct. 30, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9315

1 0

Re: [PATCH v2 0/1] MR9313: configure: Only run checks in WINE_(MINGW_)PACKAGE_FLAGS when CFLAGS or LIBS is non-empty. - approved
by Alexandre Julliard (＠julliard) Oct. 30, 2025

Oct. 30, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9313

1 0

[PATCH 0/1] MR9318: urlmon: Fix PersistentZoneIdetifier tests on some Windows versions.
by Jacek Caban (＠jacek) Oct. 30, 2025

Oct. 30, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9318

2 1

[PATCH 0/5] MR9293: Reparse points, part 1.
by Elizabeth Figura (＠zfigura) Oct. 30, 2025

Oct. 30, 2025

As prescribed some time ago, this attempts to implement correct reparse behaviour simply without attempting at all to make reparse points resolvable Unix symlinks. A reparse point consists two files. For a file whose NT name is "foobar", the contents of the file or directory (and note that a reparse point *can* have arbitrary contents) is stored in a file or directory "foobar?". The contents of the reparse point are stored in a file "foobar*". Both * and ? are valid in POSIX filenames but not NT, so no collision should be possible. The actual file "foobar" does not exist in this case. This is to allow the case where there are no reparse points (which is most common) to work as it currently does, without any extra overhead to check for a reparse point. [Simply guarding this behind FILE_OPEN_REPARSE_POINT does not seem good enough to me; that flag is used for example by many builtin functions like MoveFile().] When failing to locate a path segment "foobar", we check for "foobar*" and attempt to parse and resolve that reparse point. Issues: (1) Since we are manipulating two files, are there any race conditions? I believe there are no meaningful races. Read/write races: - When setting a reparse point, we move the contents file out of the way last, so attempts to open the file before that will see a normal file. Attempts to read the reparse point might see a partial file, but we treat that as failure. - When removing a reparse point from a file, we move the contents file back first, so attempts to open or read will see a normal file. - When deleting a reparse point entirely, we delete the contents first, so attempts to open the file will see neither a normal file nor the contents of the symlink, and fail. Attempts to query attributes don't need to open the contents, only the data, which will either be present or not. Write/write races: - Races involving file deletion don't matter, because deletion doesn't take effect until all handles to an inode are closed. - If we try to simultaneously set the reparse point from two different threads, one will fail with no effect since we create the reparse data file with O_EXCL. - If we try to remove the reparse point while setting it, the contents won't be in the right place and we'll fail. - If we try to remove the reparse point from two different threads, one will fail to move the contents back or delete them. (2) How does this interact with hard links? Creating a hard link to an existing reparse point is not too hard to do; we can just hard link both the data file and the contents file. However, turning an existing hardlinked file into a reparse point cannot work. This is also a limitation of other approaches that have been proposed. For this reason I've elected to forbid hard link interaction for now. One alternative approach that would allow turning hardlinked files into reparse points would be to store the reparse data in xattr. This would be less portable though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9293

3 8

[PATCH v4 0/2] MR9217: dlls/twain_32: Fix segfault when application unloads and reloads twain_32.dll
by Bernd Herd (＠herdsoft) Oct. 30, 2025

Oct. 30, 2025

# Fault secnario If an application loads twain_32.dll for every scan and unloads it when done with scanning, it very likely crashes when the user chooses to scan a second time within the same process. Unloading twain_32.dll is not uncommon behaviour. # Internal error cause When sane.ds gets loaded the first time, it retrieves the address of the DSM_Entry function from twain_32.dll and stores it in a variable SANE_dsmentry in the sane.ds global data. When the DS gets closed, the sane.ds does not get unloaded due to an old workaround in dlls/twain_32/dsm_ctrl.c:275: ``` twRC = currentDS->dsEntry (pOrigin, DG_CONTROL, DAT_IDENTITY, MSG_CLOSEDS, pData); /* This causes crashes due to still open Windows, so leave out for now. * FreeLibrary (currentDS->hmod); */ ``` When the application program closes the DSM (twain_32.dll) and reloads it, there is a hight probability that it will be loaded in a different memory location. So the exported DSM_Entry function is located at a different address. But the code in dlls/sane.ds/sane_main.c:60 does not update the pointer if SANE_dsmentry is not NULL: ``` if (SANE_dsmentry == NULL) { HMODULE moddsm = GetModuleHandleW(L"twain_32"); if (moddsm) SANE_dsmentry = (void*)GetProcAddress(moddsm, "DSM_Entry"); ``` So SANE_dsmentry still points to where the twain_32.dll was loaded the first time it loaded the sane.ds. Which is now an invalid address. When later the DS wants to notify the application of an event (DS Closed, Image transfered..) it calls SANE_Notify in sane_main.c:357: ``` void SANE_Notify (TW_UINT16 message) { SANE_dsmentry (&activeDS.identity, &activeDS.appIdentity, DG_CONTROL, DAT_NULL, message, NULL); } ``` And here the crash occurs due to the invalid pointer in variable SANE_dsmentry. # Suggested Solution There are many ways how this problem could be solved. The solution suggested here is based on an extension of the TWAIN protocol in Version 2: The DSM transfers the entry points to it's callback functions in a message: DG_CONTROL / DAT_ENTRYPOINT / MSG_SET That message was already implemented in sane.ds and gphoto2.gs. And both also set the flag DF_DS2 in the identitiy information SupportedGroups, so the DSM knows it is allowed to send that message. So this approach is not a workaround, but an additional feature that solves the problem in the way intended according to the TWAIN specification. This also means that the patch should solve the problem in closed source TWAIN drivers a user might install. However [sane.d](http://sane.de)s and gphoto2.ds do not fill the TW_IDENTITY information in the response to the DAT_IDENTITIY / MSG_OPENDS message. This is different from the behaviour observed on windows. For that reason the DF_DS2 flag in SupportedGroups is also not set, and thus a change in sane.ds is neccessary to make the DAT_ENTRYPOINT solution work. This is also not just a workaround but a change of the behaviour so it becomes closer to what is observed on windows. # Test scenario software I've written a small 163 lines C application program to reproduce the erroneous behaviour. It is called unloaddsm.c and I'll attach it to this merge request. It is meant to be cross-compiled with mingw-w64. It loads the DSM, opens the DS (withour showing the UI), closes the DS, unloads DSM, re-loads DSM, re-opens the DS and then displays the UI (User Interface) when the user then clicks "cancel" or presses escape, this causes the call of SANE_Notify that leads to the crash. It also shows the TW_IDENTITY fields that sane.ds did not fill. I ran the same program with a 32-Bit windows TWAIN driver on Windows 10 and there the idendity fields were filled. With the patch applied, the error does not occur any more in sane.ds. ``` Archive: /tmp/unloaddsm.zip Length Date Time Name 5283 2025-10-18 23:31 unloaddsm.c 77104 2025-10-16 14:02 twain.h 161 2025-10-18 15:57 Makefile ``` -- v4: dlls/sane.ds: when opening a DS, return the identitity information of the opened device to the caller. Matches windows behaviour and neccessary for the change in dsm_ctrl.c to work dlls/twain_32: Avoid crash when application unloads twain32_dll and reloads it for a second scan by implementing TWAIN feature DG_CONTROL / DAT_ENTRYPOINT / MSG_SET https://gitlab.winehq.org/wine/wine/-/merge_requests/9217

4 4

[PATCH v3 0/6] MR9305: Reject pseudo-handles in NtWaitForMultipleObjects().
by Marc-Aurel Zent (＠mzent) Oct. 30, 2025

Oct. 30, 2025

Some applications rely on this behavior. -- v3: kernel32/tests: Add more tests for waits on pseudo-handles. include: Add more NT pseudo-handle definitions. ntdll: Reject pseudo-handles in NtWaitForMultipleObjects. ntdll: Reimplement NtWaitForSingleObject without NtWaitForMultipleObjects. kernelbase: Reimplement WaitForSingleObject[Ex] on top of NtWaitForSingleObject. kernelbase: Add set_ntwaitstatus() helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/9305

3 23

[PATCH v2 0/6] MR9305: Reject pseudo-handles in NtWaitForMultipleObjects().
by Marc-Aurel Zent (＠mzent) Oct. 30, 2025

Oct. 30, 2025

Some applications rely on this behavior. -- v2: kernel32/tests: Add more tests for waits on pseudo-handles. include: Add more NT pseudo-handle definitions. ntdll: Reject pseudo-handles in NtWaitForMultipleObjects. ntdll: Reimplement NtWaitForSingleObject without NtWaitForMultipleObjects. kernelbase: Reimplement WaitForSingleObject[Ex] on top of NtWaitForSingleObject. kernelbase: Add set_ntwaitstatus() helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/9305

2 6

[PATCH 0/1] MR8800: mfreadwrite/tests: Fix test failures with Windows 7.
by Bernhard Übelacker Oct. 30, 2025

Oct. 30, 2025

[Test pattern page](https://test.winehq.org/data/patterns.html#mfreadwrite:mfplat) [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=159453) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8800

3 6

Re: [PATCH v4 0/1] MR9303: ntdll/tests: Add NtRenameKey tests checking subkey after rename. - approved
by zhengyong chen (＠chenzhengyong) Oct. 30, 2025

Oct. 30, 2025

This merge request was approved by zhengyong chen. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9303

1 0

[PATCH 0/2] MR9317: msxml3: Update to IXMLDocument2.
by Nikolay Sivov (＠nsivov) Oct. 30, 2025

Oct. 30, 2025

Even though IXMLDocument2 does not inherit from IXMLDocument, it extends it in practice. Return automation type info also points to IID_IXMLDocument2. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9317

2 2