October 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR9329: dlls/sane.ds, dlls/gphoto2.ds: Destroy Progress Dialogs with DestroyWindow instead of EndDialog
by Bernd Herd (＠herdsoft) Nov. 1, 2025

Nov. 1, 2025

The TWAIN data sources sane.ds and gpoto.ds create progress dialogs with the WIN32 CreateDialog API in files ui.c When they need to destroy these windows, they call EndDialog. But EndDialog is meant for Modal Dialogs created by DialogBox, DialogBoxParam, DialogBoxInd and the like. Calling it for dialogs created by CreateDialog is undocumented behaviour. In the end, those progress dialogs are not destroyed (immediatly?) and can still be open when the application program closes the data source with the message. DG_CONTROL / DAT_IDENTITY / MSG_CLOSEDS This can then later cause a segfault if the sane.ds/gpoto2.ds gets unloaded with FreeLibrary so the dialog box procedure is no longer in memory. There is a workaround for this in dlls/twain_32/dsm_ctrl.c:220: ``` /* This causes crashes due to still open Windows, so leave out for now. * FreeLibrary (currentDS->hmod); */ ``` But the TWAIN organization offers their own DSM-Library twaindsm.dll, that does not contain this workaround so segfaults after an otherwise successful scan: https://github.com/twain/twain-dsm Using this patch, progress dialogs are closed with DestroyWindow instead of EndDialog and these segfaults do not occur any more. This would also allow to change the code in dsm_ctrl.c:220 to FreeLibrary the DS module again. I've tested that it works. But there is no evidence that that change would have benefits and it might have other disadvantages. Compatibility of twaindsm.dll with sane.ds requires one of my previous merge requests that are not yet in wine main tree. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9329

3 2

[PATCH 0/1] MR9328: dlls/sane.ds: Make comboboxes in property sheet high enough to properly drop down
by Bernd Herd (＠herdsoft) Nov. 1, 2025

Nov. 1, 2025

When the sane.ds TWAIN data source displays it's user interface, it auto-generates a proprties dialog from the sane options for the current scanner. Oftenly this dialog contains windows ComboBox controls to choose between scan modes (gray / color) or resolutions. The ComboBox controls created are too flat to properly drop down, they only open about half a line height. This is difficult to use. This patch makes the control about 10 times the height of a string. The combox will not occupy more height than the elements that are filled in anyway. Behaviour before the patch: ![before.png](/uploads/80e328dde7c04c14e5a29b54fa6843a5/before.png){width=305 height=244} Behaviour after the patch: ![after.png](/uploads/49a0e1014974e4bc43637f6b0b02ba54/after.png){width=308 height=246} -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9328

3 2

[PATCH 0/7] MR9331: msxml3: Merge IXMLDocument and IXMLElement sources into a single file.
by Nikolay Sivov (＠nsivov) Oct. 31, 2025

Oct. 31, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9331

2 7

Re: [PATCH v3 0/1] MR9298: ntdll: Remove unused parameter from linux_query_event_obj(). - approved
by Alexandre Julliard (＠julliard) Oct. 31, 2025

Oct. 31, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9298

1 0

Re: [PATCH v2 0/1] MR9326: winex11: Use window rects for minimization in virtual desktop mode. - approved
by Alexandre Julliard (＠julliard) Oct. 31, 2025

Oct. 31, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9326

1 0

Re: [PATCH v2 0/2] MR9324: kernelbase: Reject empty command lines in CreateProcess(). - approved
by Alexandre Julliard (＠julliard) Oct. 31, 2025

Oct. 31, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9324

1 0

Re: [PATCH v3 0/1] MR9309: reg: Make sure empty is big enough. - approved
by Alexandre Julliard (＠julliard) Oct. 31, 2025

Oct. 31, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9309

1 0

Re: [PATCH v2 0/1] MR9320: winex11: Null-terminate a string used with RTL_CONSTANT_STRING(). - approved
by Alexandre Julliard (＠julliard) Oct. 31, 2025

Oct. 31, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9320

1 0

[PATCH v2 0/2] MR9330: Draft: PickiconDlg
by Matthias Zorn (＠Matthias-Zorn.0178) Oct. 31, 2025

Oct. 31, 2025

Added PickiconDlg dialog resources as a test -- v2: Added resources for PickIconDlg function https://gitlab.winehq.org/wine/wine/-/merge_requests/9330

2 2

Re: [PATCH v2 0/1] MR9298: ntdll: Remove unused parameter from linux_query_event_obj(). - approved
by Elizabeth Figura (＠zfigura) Oct. 31, 2025

Oct. 31, 2025

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9298

1 0