November 2025 - Wine-GitLab

Re: [PATCH v2 0/1] MR9529: user32: Avoid out-of-bounds read in DdeCreateDataHandle with offset (ASan). - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9529

1 0

Re: [PATCH v4 0/2] MR9500: In CreateProcess(), set std handle when passing a pseudo-console. - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9500

1 0

Re: [PATCH v4 0/6] MR9453: xactengine3/tests: Add many more tests. - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9453

1 0

Re: [PATCH v2 0/6] MR9523: wined3d: Move backend-specific code out of texture.c. - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9523

1 0

Re: [PATCH v2 0/4] MR9527: widl: Use the metadata short name for parameterized types. - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9527

1 0

Re: [PATCH v2 0/6] MR9525: rometadata: IMetaDataImport implementation, part 1 - approved
by Alexandre Julliard (＠julliard) Nov. 19, 2025

Nov. 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9525

1 0

[PATCH 0/1] MR9519: dlls/twain_32: Offer TWAIN DSM as twaindsm.dll for 64 Bit and send DAT_ENTRYPOINT earlier.
by Bernd Herd (＠herdsoft) Nov. 19, 2025

Nov. 19, 2025

64-Bit Windows applications typically expect the Twain Data Source manager to be named twaindsm.dll. Send the DG_CONTROL/DAT_ENTRYPOINT/MSG_SET before DG_CONTROL/DAT_IDENTITY/MSG_OPENDS so sane.ds does not need to know the module name to find the DSM entry point. An explanation for the request to offer the name twaindsm.dll for 64-Bit windows is offered here by the TWAIN organization: https://github.com/twain/twain-dsm/blob/master/TWAIN_DSM/src/readme.doc They cannot update the twain_32.dll installed and maintained by Microsoft, so they choose the new name twaindsm.dll instead. This name is also used at least by Irfanview and oder versions oder LibreOffice (Newer Libreoffice version start a 32-Bit process for 32-Bit TWAIN usage). This Merge request also changes the twain_32.dll so that it send it's entry points earlier, before opening the data source. This is the same behaviour as the twaindsm.dll from the TWAIN organization from [https://github.com/twain/twain-dsm/](https://github.com/twain/twain-dsm/blo… Otherwise sane.ds would in MSG_OPENDS try to find the DSM entry point based on the module-name "twain_32" in sane_main.c:60: ``` if (SANE_dsmentry == NULL) { HMODULE moddsm = GetModuleHandleW(L"twain_32"); if (moddsm) SANE_dsmentry = (void*)GetProcAddress(moddsm, "DSM_Entry"); if (!SANE_dsmentry) { ERR("can't find DSM entry point\n"); return TWRC_FAILURE; } } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9519

5 5

[PATCH 0/1] MR9524: comctl32_v6/taskdialog: Fix not enough width for the expando button text.
by Zhiyi Zhang (＠zhiyi) Nov. 19, 2025

Nov. 19, 2025

The icon width and text offset are subtracted from the dialog max width and the result is then used for the expando button text rect calculation. When it's done, the expando button width should be the text width + icon width + text offset, not just the text width. ![Screenshot_From_2025-11-19_11-24-51](/uploads/b9f4f0ca8b72d6537e2a6b7788914cd3/Screenshot_From_2025-11-19_11-24-51.png) Test program: [test_taskdialog.zip](/uploads/0f710d99f9cfe8eb6a52645310cb1f53/test_taskdialog.zip) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9524

3 2

[PATCH 0/5] MR9521: comctl32/updown: Refactor UPDOWN_DrawBuddyBackground() to support drawing...
by Zhiyi Zhang (＠zhiyi) Nov. 19, 2025

Nov. 19, 2025

This MR marks the end of the series. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9521

3 6

Re: [PATCH v6 0/2] MR8360: include: Don't evaluate format arguments to ok() unless we need them.
by Bernhard Übelacker Nov. 19, 2025

Nov. 19, 2025

Hello @yshui, I am sorry, but I think I found an unwanted side effect of this patch. Since a9edbf49 got merged a failure in the [test pattern page of advapi32:registry](https://test.winehq.org/data/patterns.html#advapi32:regi… showed up. ``` registry.c:2267: Test failed: RegQueryValueExA returned: 0 ``` Because I was not able to reproduce it with testbot or a VM I tried to use gitlab CI: - [failure shows up here with a9edbf49](https://gitlab.winehq.org/bernhardu/wine/-/jobs/206300#L82) - [but succeeds here without a9edbf49](https://gitlab.winehq.org/bernhardu/wine/-/jobs/206303#L82) - Unfortunately adding a few traces around the place makes the failure go away like [here](https://gitlab.winehq.org/bernhardu/wine/-/jobs/209460#L82) - Also disabling optimizations for the function containing the test did not help like [here](https://gitlab.winehq.org/bernhardu/wine/-/jobs/209463#L83) (The git history of these Jobs can still be accessed by following the "Commit" at the right side, button "Browse Files", button "History.) What do you think? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8360#note_122996

1 0