November 2025 - Wine-GitLab

[PATCH 0/5] MR9505: comctl32/updown: Add a helper to get the buddy border size.
by Zhiyi Zhang (＠zhiyi) Nov. 18, 2025

Nov. 18, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9505

5 10

[PATCH 0/1] MR9513: user32/tests: Avoid out-of-bounds access in DdeCreateDataHandle (ASan).
by Bernhard Übelacker Nov. 18, 2025

Nov. 18, 2025

The literal "data" is just 5 bytes, but DdeCreateDataHandle is currently told to read a length of MAX_PATH. [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=160926) <details> <summary>ASan report details</summary> ``` ================================================================= ==1464==ERROR: AddressSanitizer: global-buffer-overflow on address 0x000140292045 at pc 0x6ffffe8ccfac bp 0x7ffffe1feed0 sp 0x7ffffe1fef18 READ of size 258 at 0x000140292045 thread T0 #0 0x6ffffe8ccfab in memmove /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt\lib/asan/../sanitizer_common/sanitizer_common_interceptors_memintrinsics.inc:100:3 #1 0x6ffffa6dd6e6 in DdeCreateDataHandle .../wine/dlls/user32/dde_misc.c:1328 #2 0x000140061ffe in test_DdeCreateDataHandle .../wine/dlls/user32/tests/dde.c:1943 #3 0x00014005b743 in func_dde .../wine/dlls/user32/tests/dde.c:2764 #4 0x000140268de2 in run_test .../wine/include/wine/test.h:780 #5 0x0001402687eb in main .../wine/include/wine/test.h:900 #6 0x00014026aa7a in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:62 #7 0x6ffffaf57a54 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027a54) #8 0x6ffffdcb06d6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700506d6) 0x000140292045 is located 27 bytes before global variable '"Expected non-NULL ptr\n"' defined in '.../wine/dlls/user32/tests/dde.c:1915' (0x000140292060) of size 23 '"Expected non-NULL ptr\n"' is ascii string 'Expected non-NULL ptr ' 0x000140292045 is located 0 bytes after global variable '"data"' defined in '.../wine/dlls/user32/tests/dde.c:1886' (0x000140292040) of size 5 '"data"' is ascii string 'data' SUMMARY: AddressSanitizer: global-buffer-overflow .../wine/dlls/user32/dde_misc.c:1328 in DdeCreateDataHandle ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9513

1 1

[PATCH v2 0/4] MR9508: Draft: winex11: Track more window state to avoid unnecessary requests.
by Rémi Bernon Nov. 18, 2025

Nov. 18, 2025

We don't track the corresponding property changes, because it seems like they sometimes are different from what was requested [^1], and that would defeat the purpose of this MR. This shouldn't matter and there's actually no reason for the properties to change as these are direct property change requests. [^1]: At least for me on XWayland, the differences seem mostly about x/y position hints, and they might come from XWayland quirks. -- v2: winex11: Track requested _NET_WM_ICON to avoid unnecessary requests. winex11: Track requested _NET_WM_WINDOW_STATE to avoid unnecessary requests. winex11: Track requested WM_HINTS to avoid unnecessary requests. winex11: Track requested WM_NORMAL_HINTS to avoid unnecessary requests. https://gitlab.winehq.org/wine/wine/-/merge_requests/9508

1 5

[PATCH v8 0/6] MR9470: rometadata/tests: Add some tests for IMetaDataImport
by Vibhav Pant (＠vibhavp) Nov. 18, 2025

Nov. 18, 2025

-- v8: rometadata/tests: Add tests for IMetaDataImport::{EnumProperties, GetPropertyProps}. rometadata/tests: Add tests for IMetaDataImport::GetCustomAttributeByName. rometadata/tests: Add tests for IMetaDataImport::{EnumFields, GetFieldProps}. https://gitlab.winehq.org/wine/wine/-/merge_requests/9470

3 7

[PATCH v2 0/6] MR9468: mmdevapi: Various
by Matteo Bruni (＠Mystral) Nov. 18, 2025

Nov. 18, 2025

The mmdevapi side of !9438 -- v2: mmdevapi/tests: Conditionally apply todo_wine to SetSampleRate() tests. mmdevapi/tests: Simplify handling of failure to get a capture endpoint. mmdevapi/tests: Get rid of questionable error handling. mmdevapi/tests: Test capture session state in render:test_session_creation(). mmdevapi/tests: Accept any digit before the process ID in the session instance identifier. mmdevapi: Share NULL GUID session. https://gitlab.winehq.org/wine/wine/-/merge_requests/9468

3 7

[PATCH 0/4] MR9504: Reparse points, part 5.
by Elizabeth Figura (＠zfigura) Nov. 18, 2025

Nov. 18, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9504

4 7

[PATCH v2 0/2] MR9500: In CreateProcess(), set std handle when passing a pseudo-console.
by eric pouech (＠epo) Nov. 18, 2025

Nov. 18, 2025

This MR tests and fix the std handles in child process when using CreateProcess with extended information and passing a pseudo-console handle. >From the added tests, and other manual testing (see linked bugzilla entry), it turns out native overrides the (bound) std handles from the parent console with handles on the passed pseudo-console for the child process. But happily inherits other kind of handles. As side notes: - resetting the std handle in RTL_USER_PROCESS_PARAMETERS being console handles could be optimized: potentially, native could just test if the passed handles are bound to the passed console and reset them if not. - hijacked an unused bit in ConsoleFlags to discriminate when to recreate the std handles in child (didn't check-out how native does it though). -- v2: kernelbase: Create std handles from passed pseudo-console. kernel32/tests: Test std handles in CreateProcess with pseudo console. https://gitlab.winehq.org/wine/wine/-/merge_requests/9500

3 4

[PATCH 0/2] MR9511: server: Forbid background process window reactivation.
by Rémi Bernon Nov. 18, 2025

Nov. 18, 2025

Pegasus Mail posts a WM_USER + 8991 message to its own window when it loses focus, then calls SetFocus on its window when processing this message. Several other applications have been seen calling SetWindowPos during WM_ACTIVATE message, which might also attempt to reactivate the window. That processing happens shortly after we have changed the foreground window to the desktop window, when focus is lost, then SetFocus tries to change the foreground window again. This SetFocus behavior is tested, and should work like this, but would only activate the window if the process is allowed to do so. Windows has various rules around this, and it seems to boil down to something like: * Allow taking focus if the process never was foreground, ie: when process is starting and gets initial focus on its windows. * Allow taking focus if the process was foreground but lost it recently because of a window being destroyed. * Forbid taking focus back if the process had foreground and called SetForegroundWindow explicitly to give it to another process. This doesn't implement all this rules, but rather keep rely on the host window management with some additional heuristics to avoid activating windows which lost foreground recently. This is mostly about keeping track of user input time, updating it on user input and on focus change. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58167 --- I think this should be enough to prevent spurious window reactivation, either from calls to SetWindowPos during WM_ACTIVATE messages like in https://gitlab.winehq.org/wine/wine/-/merge_requests/9398 or from calls to SetFocus from posted messages right after window deactivation as described above. Fwiw we could have tests for that, and show that this MR is fixing them but fvwm doesn't implement window minimization properly, and doesn't change focus when window is minimized, so the tests would be meaningless. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9511

1 3

[PATCH v23 0/10] MR7797: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().
by Matteo Bruni (＠Mystral) Nov. 18, 2025

Nov. 18, 2025

This fixes Trials Fusion often crashing when disconnecting a controller while there are more still connected. -- v23: ntoskrnl/tests: Use the 'Nt' version of the CancelIo APIs. ntoskrnl/tests: Test the thread ID the cancellation routine runs from. ntoskrnl/tests: Add more cancellation tests. ntoskrnl/tests: Fix tests on current Windows 10 / 11. ntdll/tests: Test IOSB values of the cancel operation. ntdll/tests: Add more NtCancelIoFile[Ex]() tests. ntdll: Wait for all asyncs to handle cancel in NtCancelIoFile(). server: Factor out a cancel_async() function. server: Introduce a find_async_from_user helper. ntdll: Factor out a cancel_io() function. https://gitlab.winehq.org/wine/wine/-/merge_requests/7797

3 13

Re: [PATCH v2 0/1] MR8509: hid: Implement HidP_SetData. - closed
by Rémi Bernon Nov. 18, 2025

Nov. 18, 2025

This merge request was closed by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8509

1 0