November 2025 - Wine-GitLab

[PATCH 0/1] MR9439: mf: Return E_NOINTERFACE if service is missing
by Aric Stewart (＠aricstewart) Nov. 13, 2025

Nov. 13, 2025

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9439

3 4

[PATCH v3 0/8] MR9438: dsound: Various
by Matteo Bruni (＠Mystral) Nov. 13, 2025

Nov. 13, 2025

Some small dsound fixes I came up with while looking into Wine bug 30639 -- v3: dsound/tests: Mark weird DescriptionW propset failure on the AMD testbot machine. dsound: Return the mmdevapi endpoint ID as module. dsound: Fill all the DSPROPERTY_DIRECTSOUNDDEVICE_ENUMERATE data. dsound: Check data size in propset methods. dsound: Consistently trace locked byte count as an unsigned value. dsound: Print time as an unsigned value. dsound: Simplify check in DSOUND_RecalcFormat(). dsound/tests: Disable a crashing test. https://gitlab.winehq.org/wine/wine/-/merge_requests/9438

3 10

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) Nov. 13, 2025

Nov. 13, 2025

Also, as Huw mentioned above, it looks like you still didn't fully address the comments from @nsivov that were pointed out [here](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.o…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121819

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) Nov. 13, 2025

Nov. 13, 2025

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + > + if (!SUCCEEDED(IShellLinkW_QueryInterface(shelllink, &IID_IPersistFile, (LPVOID*)&persistfile))) > + { > + ERR("couldn't get IPersistFile interface\n"); > + IShellLinkW_Release(shelllink); > + return; > + } > + > + do { > + WCHAR *link_filename; > + > + if (counter == 1) > + { > + static const WCHAR *fmt = L"%s - %s.lnk"; > + int length = wcslen(filename) + wcslen(shortcutW) + 7; /* length of the format*/ > + link_filename = malloc((length + 1) * sizeof(WCHAR)); Should you check if malloc returns null? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121810

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) Nov. 13, 2025

Nov. 13, 2025

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + WCHAR *link_filename; > + > + if (counter == 1) > + { > + static const WCHAR *fmt = L"%s - %s.lnk"; > + int length = wcslen(filename) + wcslen(shortcutW) + 7; /* length of the format*/ > + link_filename = malloc((length + 1) * sizeof(WCHAR)); > + wsprintfW(link_filename, fmt, filename, shortcutW); > + } > + else > + { > + static const WCHAR *fmt = L"%s - %s (%s).lnk"; > + int length = wcslen(filename) + wcslen(shortcutW) + 10; /* length of the format*/ > + WCHAR counter_string[34]; > + wsprintfW(counter_string, L"%i", counter); > + length += wcslen(counter_string); `wsprintfW` also returns the length of the string by the way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121809

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) Nov. 13, 2025

Nov. 13, 2025

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + { > + ERR("SetIDList failed\n"); > + return; > + } > + _ILSimpleGetTextW(This->apidl[0], (LPVOID)filename, MAX_PATH); > + length = wcslen(filename) + wcslen(shortcutW); > + if (length > MAX_PATH) > + { > + ERR("Path maximum length exceeded (%i>%i)\n", length, MAX_PATH); > + IShellLinkW_Release(shelllink); > + return; > + } > + > + SHGetPathFromIDListW(This->pidl, root); > + > + if (!SUCCEEDED(IShellLinkW_QueryInterface(shelllink, &IID_IPersistFile, (LPVOID*)&persistfile))) In these failure cases, it's probably possible to write some tests to see what `HRESULT` should be returned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121808

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) Nov. 13, 2025

Nov. 13, 2025

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + do { > + WCHAR *link_filename; > + > + if (counter == 1) > + { > + static const WCHAR *fmt = L"%s - %s.lnk"; > + int length = wcslen(filename) + wcslen(shortcutW) + 7; /* length of the format*/ > + link_filename = malloc((length + 1) * sizeof(WCHAR)); > + wsprintfW(link_filename, fmt, filename, shortcutW); > + } > + else > + { > + static const WCHAR *fmt = L"%s - %s (%s).lnk"; > + int length = wcslen(filename) + wcslen(shortcutW) + 10; /* length of the format*/ > + WCHAR counter_string[34]; > + wsprintfW(counter_string, L"%i", counter); I think we can just allocate a sufficient amount for `link_filename` and add the counter directly in the `wsprintfW` call below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121805

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) Nov. 13, 2025

Nov. 13, 2025

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + ILFree(full_pidl); > + if (FAILED(hr)) > + { > + ERR("SetIDList failed\n"); > + return; > + } > + _ILSimpleGetTextW(This->apidl[0], (LPVOID)filename, MAX_PATH); > + length = wcslen(filename) + wcslen(shortcutW); > + if (length > MAX_PATH) > + { > + ERR("Path maximum length exceeded (%i>%i)\n", length, MAX_PATH); > + IShellLinkW_Release(shelllink); > + return; > + } > + > + SHGetPathFromIDListW(This->pidl, root); In other places, we check the return value of this function. Not sure if we should do that here as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121807

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) Nov. 13, 2025

Nov. 13, 2025

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + ITEMIDLIST *full_pidl; > + HRESULT hr; > + int length; > + int counter = 1; > + > + static const WCHAR *shortcutW = L"Shortcut"; > + > + if (FAILED(IShellLink_Constructor(NULL, &IID_IShellLinkW, (LPVOID*)&shelllink))) > + { > + ERR("couldn't create ShellLink object\n"); > + return; > + } > + full_pidl = ILCombine(This->pidl, This->apidl[0]); > + if (!full_pidl) > + { > + ERR("Out of Memory\n"); Why don't we just return an `HRESULT` here and return that from `ItemMenu_InvokeCommand`, instead of the verbose ERRs? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121806

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) Nov. 13, 2025

Nov. 13, 2025

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + return; > + } > + > + PathCombineW(lnkfile, root, link_filename); > + free(link_filename); > + counter++; > + > + if (PathFileExistsW(lnkfile)) > + { > + hr = HRESULT_FROM_WIN32(ERROR_FILE_EXISTS); > + } > + else > + { > + ERR("attempting to write link to %s\n", wine_dbgstr_w(lnkfile)); > + hr = IPersistFile_Save(persistfile, lnkfile, FALSE); > + ERR("ARIC %#lx\n",hr); Debug statements -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121804

1 0