November 2025 - Wine-GitLab

[PATCH v3 0/1] MR9347: windowscodecs: Fix off-by-one check in IcoDecoder_GetFrame.
by zhengyong chen (＠chenzhengyong) Nov. 4, 2025

Nov. 4, 2025

The frame index should be strictly less than idCount. Previously, an index equal to idCount was not rejected, leading to an out-of-range access. Signed-off-by: chenzhengyong chenzhengyong(a)uniontech.com Although this bug was not fatal because subsequent IStream_Read and related functions also perform boundary checks, it is better to catch the invalid index early for clarity and consistency. -- v3: windowscodecs: Fix off-by-one check in IcoDecoder_GetFrame. https://gitlab.winehq.org/wine/wine/-/merge_requests/9347

3 2

[PATCH 0/1] MR9365: d2d1: Add property descriptions for the 2D Affine Transform effect.
by Nikolay Sivov (＠nsivov) Nov. 4, 2025

Nov. 4, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9365

2 1

[PATCH 0/2] MR9364: ntdll: Treat FPU_sig as a void* and memcpy to and from it as needed.
by Tim Clem (＠tclem) Nov. 4, 2025

Nov. 4, 2025

It may be unaligned on certain architectures (e.g. macOS). --- We started seeing this intermittently on Intel Macs after !9060. Since FPU_sig was returning an XMM_SAVE_AREA32*, the compiler assumed it was correctly aligned, and emitted `movaps` for a copy. If the pointer wasn't aligned, that of course failed. Presumably alignment is dodgy on macOS because we're returning a pointer a few fields into the context struct - `__fpu_fcw` is preceded by `int __fpu_reserved[2]`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9364

2 2

[PATCH v21 0/11] MR9209: vccorlib140: Implement Platform::Exceptions.
by Vibhav Pant (＠vibhavp) Nov. 4, 2025

Nov. 4, 2025

-- v21: vccorlib140: Implement __abi_translateCurrentException. vccorlib140: Throw exceptions on error paths. vccorlib140: Add Platform::Exception::CreateException() implementation. vccorlib140: Add Platform::Exception::Message::get() implementation. vccorlib140: Add Platform::COMException constructor implementation. vccorlib140: Add Platform::Exception(HSTRING) constructor implementation. vccorlib140: Add Platform::Exception constructor implementation. msvcrt: Move TYPE_FLAG* and CLASS_IS* defines to cxx.h. vccorlib140: Remove platform_ prefix from exception function names. vccorlib140: Move exception functions to new file. vccorlib140/tests: Add additional tests for exception objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/9209

4 12

[PATCH 0/1] MR9363: msxml3: Rewrite legacy DOM API using SAX parser.
by Nikolay Sivov (＠nsivov) Nov. 4, 2025

Nov. 4, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9363

2 1

Re: [PATCH v5 0/1] MR8988: win32u: change the stretch mode of dst hdc from BlackOnWhite to ColorOnColor...
by Jinoh Kang (＠iamahuman) Nov. 4, 2025

Nov. 4, 2025

On Tue Nov 4 19:05:24 2025 +0000, Kun Yang wrote: > @iamahuman Is there anything else to do for this patch? It looks fine for me, although you'll need @huw 's approval. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8988#note_120757

1 0

Re: [PATCH v5 0/1] MR8988: win32u: change the stretch mode of dst hdc from BlackOnWhite to ColorOnColor... - approved
by Jinoh Kang (＠iamahuman) Nov. 4, 2025

Nov. 4, 2025

This merge request was approved by Jinoh Kang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8988

1 0

[PATCH 0/1] MR9359: d3d9/tests: Fix value of stride passed to DrawPrimitiveUP (ASan).
by Bernhard Übelacker Nov. 4, 2025

Nov. 4, 2025

Other calls to `d3d9_device_DrawPrimitiveUP` use just the size of one dimension of the `quad` array as parameter `stride`. Therefore using the size of the whole `quad` variable causes the function call with `D3DPT_TRIANGLESTRIP` and `primitive_count=2` to read "64 * (2+2) = 256 bytes" which overflows the allocated "64 bytes". [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=160603) <details> <summary>ASan report details</summary> ``` ================================================================= ==312==ERROR: AddressSanitizer: global-buffer-overflow on address 0x0001401c8540 at pc 0x6ffffe8dc03b bp 0x7ffffe1fe930 sp 0x7ffffe1fe978 READ of size 256 at 0x0001401c8540 thread T0 #0 0x6ffffe8dc03a in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x6ffff97c7abb in wined3d_streaming_buffer_upload .../wine/dlls/wined3d/buffer.c:1438 #2 0x6ffffdd4519d in d3d9_device_DrawPrimitiveUP .../wine/dlls/d3d9/device.c:3345 #3 0x0001400b55f0 in clear_test .../wine/dlls/d3d9/tests/visual.c:1464 #4 0x0001400a900c in func_visual .../wine/dlls/d3d9/tests/visual.c:28886 #5 0x00014017ada2 in run_test .../wine/include/wine/test.h:768 #6 0x00014017a7ab in main .../wine/include/wine/test.h:888 #7 0x00014017ca7a in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:62 #8 0x6fffffc67a74 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027a74) #9 0x6fffffde06a6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700506a6) 0x0001401c8540 is located 32 bytes before global variable '"Clear rectangle 3(pos, neg) has "...' defined in '.../wine/dlls/d3d9/tests/visual.c:1230' (0x0001401c8560) of size 44 '"Clear rectangle 3(pos, neg) has "...' is ascii string 'Clear rectangle 3(pos, neg) has color %08x ' 0x0001401c8540 is located 0 bytes after global variable 'clear_test.quad' defined in '.../wine/dlls/d3d9/tests/visual.c:1168' (0x0001401c8500) of size 64 SUMMARY: AddressSanitizer: global-buffer-overflow .../wine/dlls/wined3d/buffer.c:1438 in wined3d_streaming_buffer_upload Shadow bytes around the buggy address: 0x0001401c8280: f9 f9 f9 f9 00 00 00 00 00 06 f9 f9 f9 f9 f9 f9 0x0001401c8300: 00 00 00 00 00 02 f9 f9 f9 f9 f9 f9 00 00 00 00 0x0001401c8380: 00 04 f9 f9 f9 f9 f9 f9 00 00 00 00 02 f9 f9 f9 0x0001401c8400: f9 f9 f9 f9 00 00 00 00 00 00 00 00 02 f9 f9 f9 0x0001401c8480: f9 f9 f9 f9 00 00 00 00 00 00 00 00 f9 f9 f9 f9 =>0x0001401c8500: 00 00 00 00 00 00 00 00[f9]f9 f9 f9 00 00 00 00 0x0001401c8580: 00 04 f9 f9 f9 f9 f9 f9 00 00 00 00 00 04 f9 f9 0x0001401c8600: f9 f9 f9 f9 00 00 00 00 00 f9 f9 f9 f9 f9 f9 f9 0x0001401c8680: 00 00 00 00 00 04 f9 f9 f9 f9 f9 f9 00 00 00 02 0x0001401c8700: f9 f9 f9 f9 00 00 00 02 f9 f9 f9 f9 00 00 00 02 0x0001401c8780: f9 f9 f9 f9 00 00 00 02 f9 f9 f9 f9 00 00 00 02 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9359

2 2

[PATCH v2 0/4] MR9296: dmsynth, dmusic: Reduce memory usage part 1
by Anton Baskanov (＠baskanov) Nov. 4, 2025

Nov. 4, 2025

-- v2: dmsynth: Release the waves when voices finish playing. dmsynth: Implement callback support in synth_Unload(). dmsynth: Call fluid_sample_set_sound_data() with copy_data = FALSE. dmusic: Reuse downloaded waves. https://gitlab.winehq.org/wine/wine/-/merge_requests/9296

4 10

[PATCH 0/1] MR9353: opengl32: Take GL_CLIENT_STORAGE_BIT into account when picking vk memory type in create_buffer_storage.
by Jacek Caban (＠jacek) Nov. 4, 2025

Nov. 4, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9353

3 2