December 2025 - Wine-GitLab

[PATCH 0/1] MR9625: dlls/sane.ds: Make UI Non-Modal as required by Twain specification
by Bernd Herd (＠herdsoft) Dec. 1, 2025

Dec. 1, 2025

This is neccessary according to the Twain specification and also allows much more comfortable user interfaces. The Twain specification is clear that event processing in the main application must be provided while the data source shows it's User Interface: ``` "You cannot use the modal dialog creation call DialogBox( ) to create the Source’s user interface main window. To allow event processing by both the application and the Source, this call cannot be used" ``` This was already documented that way in Twain Specification 1.8. According to the specification, MSG_ENABLEDS only creates the dialog and then returns. But the implementation in ui.c with the call to CreatePropertySheetW equals a "DialogBox" call and returns only when the user clicks OK or CANCEL. This Merge Requests sets PSH_MODELESS to make CreatePropertySheetW create a non-modal dialog and then returns control back to the application. To avoid crashes, some of the pointers passed to CreatePropertySheetW must stay valid as long as the dialog remains open. A pointer to an additional struct SUiData is stored with the activeDS and cleared when the user interface is cleared with DestroyWindow on MSG_DISABLEDS. To reduce the number of changes in the source code, the PROPSHEETHEADERW is not part of the struct as no problems were observable. The user interface is no longer automatically closed after every scan. Depening on the application program, it can stay open, ready for the next scan with just a click on the "Scan" button, which results in a much easier and faster user interface experience. For example the user might modifiy settings like resolution or brightness and start a second scan with the modified parameters with a singe click. The progress dialog is modified * to use the UI dialog as it's parent window. * And get created centered on the user interface dialog instead of the screen. Application orograms I found to profit from the modified behaviour: * IrfanView 4.7.2 if the Button "Close Twain dialog after acquiring an image" is disabled. * The simple memxfer.c source I recently attached to an older merge request. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9625

3 2

[PATCH 0/1] MR9602: dlls/sane.ds: Support SANE Backends that treat resolution as TYPE_FIXED
by Bernd Herd (＠herdsoft) Dec. 1, 2025

Dec. 1, 2025

Most SANE backends store resolution in DPI as an integer value TYPE_INT. Some store it as TYPE_FIXED. Twain always uses TW_FIX32 for resolution. This MR provide access to the resolution in ICAP_xRESOLUTION and DG_IMAGE/DAT_IMAGEINFO/MSG_GET for both types of sane backends. Since some backends have only one option "resolution" for both X and Y resolution, while others provide separate options for "x-resolution" and "y-resolution", there are a lot of possible combinations. Some backends do not allow read access to to their options once scanning has started. This had the consequene that for these backends, DG_IMAGE/DAT_IMAGEINFO/MSG_GET specified a resolution of -1. For that reason the current X/Y Resolution is now cached in activeDS before starting the scan. One backend that uses TYPE_FIXED is the SANE "test" backend. When setting a resolution, the test backend rounds to the nearest integer, so 300.4 DPI get 300.0 DPI and 300.6 DPI git 301 DPI. The test backend is not the only backend that stores resolution as TYPE_FIXED. This MR also contains code to display the resolution in DPI and the paper size calculated by pixel width/height and resolution in the progress dialog. If LOCALE_IMEASURE says that the locale applies the metric system, sizes are displayed in mm, otherwise (USA) sizes are displayed in inch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9602

3 2

[PATCH v2 0/4] MR9639: Fix the integration of PowerPoint add-in in MS Office 2016
by Ivan Lyugaev (＠valy) Dec. 1, 2025

Dec. 1, 2025

Encountered an issue with PowerPoint add-in integration. Reviewing the logs revealed the problem was due to the lack of CLSID lookup via the CurVer section and incorrect handling of the PARAMFLAG_NONE flag. A test was conducted in Windows to verify the handling of PARAMFLAG_NONE, PARAMFLAG_FIN, and PARAMFLAG_FOUT. Test class: ``` interface ITest : IDispatch { [id(1)] HRESULT TestMethod(BSTR* value); [id(2)] HRESULT TestMethodOut([out] BSTR* retVal); [id(3)] HRESULT TestMethodIn([in] BSTR* inVal); }; ``` Results in Windows: ``` --------TestMethod-------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethod] Hello from VT_BSTR Invoke returned: 0x00000000 -------TestMethodIn------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodIn] Hello from VT_BSTR Invoke returned: 0x00000000 -------TestMethodOut------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodOut] (null) Invoke returned: 0x00000000 ``` Results in Wine: ``` --------TestMethod-------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethod] (null) Invoke returned: 0x00000000 -------TestMethodIn------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodIn] Hello from VT_BSTR Invoke returned: 0x00000000 -------TestMethodOut------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodOut] (null) ``` Therefore, parameters with the PARAMFLAG_NONE flag are implied to be input parameters in Windows and are handled accordingly as PARAMFLAG_FIN. Added tests for the implemented changes. In the last two tests (their code is provided below), the CLSID is nullified in the guid_from_string function, which is why this test is left with a todo_wine tag. ``` clsid = CLSID_StdFont; hr = CLSIDFromString(L"MyApp.DocumentTest.3", &clsid); todo_wine ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "Unexpected clsid %s.\n", wine_dbgstr_guid(&clsid)); clsid = CLSID_StdFont; hr = CLSIDFromString(L"MyApp.DocumentTest.5", &clsid); todo_wine ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "Unexpected clsid %s.\n", wine_dbgstr_guid(&clsid)); ``` -- v2: oleaut32/test: Add ITypeInfo_fnInvoke test for VT_BSTR | VT_BYREF with different PARAMFLAG oleaut32: Fix parameter value loss in ITypeInfo_Invoke for byref parameters ole32/test: Remove now succeeding todo_wine combase: Implement CLSID lookup with CurVer fallback https://gitlab.winehq.org/wine/wine/-/merge_requests/9639

2 5

[PATCH 0/4] MR9639: Fix the integration of PowerPoint add-in in MS Office 2016
by Ivan Lyugaev (＠valy) Dec. 1, 2025

Dec. 1, 2025

Encountered an issue with PowerPoint add-in integration. Reviewing the logs revealed the problem was due to the lack of CLSID lookup via the CurVer section and incorrect handling of the PARAMFLAG_NONE flag. A test was conducted in Windows to verify the handling of PARAMFLAG_NONE, PARAMFLAG_FIN, and PARAMFLAG_FOUT. Test class: interface ITest : IDispatch { [id(1)] HRESULT TestMethod(BSTR* value); [id(2)] HRESULT TestMethodOut([out] BSTR* retVal); [id(3)] HRESULT TestMethodIn([in] BSTR* inVal); }; Results in Windows: --------TestMethod-------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethod] Hello from VT_BSTR Invoke returned: 0x00000000 -------TestMethodIn------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodIn] Hello from VT_BSTR Invoke returned: 0x00000000 -------TestMethodOut------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodOut] (null) Invoke returned: 0x00000000 Results in Wine: --------TestMethod-------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethod] (null) Invoke returned: 0x00000000 -------TestMethodIn------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodIn] Hello from VT_BSTR Invoke returned: 0x00000000 -------TestMethodOut------- Variant type: 0x0008 (VT_BSTR) [CTest::TestMethodOut] (null) Therefore, parameters with the PARAMFLAG_NONE flag are implied to be input parameters in Windows and are handled accordingly as PARAMFLAG_FIN. Added tests for the implemented changes. In the last two tests (their code is provided below), the CLSID is nullified in the guid_from_string function, which is why this test is left with a todo_wine tag. ``` clsid = CLSID_StdFont; hr = CLSIDFromString(L"MyApp.DocumentTest.3", &clsid); todo_wine ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "Unexpected clsid %s.\n", wine_dbgstr_guid(&clsid)); clsid = CLSID_StdFont; hr = CLSIDFromString(L"MyApp.DocumentTest.5", &clsid); todo_wine ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "Unexpected clsid %s.\n", wine_dbgstr_guid(&clsid)); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9639

3 5

[PATCH v3 0/3] MR9628: user32: Implement pointer input APIs for multi-touch support
by Hecheng Yu (＠kde-yyds) Dec. 1, 2025

Dec. 1, 2025

This patch implements core pointer input APIs required by modern applications with touchscreen support, particularly Chromium and Qt-based applications. Implemented APIs: - GetPointerType: Query pointer input type (touch, pen, mouse) - GetPointerTouchInfo: Retrieve detailed touch pointer information - GetPointerFrameTouchInfo: Get all active touch pointers in current frame Added stubs: - SkipPointerFrameMessages: Used by applications to skip pointer frame processing like Qt - GetPointerFrameTouchInfoHistory: Historical touch frame data (not yet implemented) - GetPointerPenInfoHistory: Historical pen data (not yet implemented) System metrics changes: - SM_DIGITIZER: Reports touch capabilities (NID_INTEGRATED_TOUCH | NID_MULTI_INPUT | NID_READY) - SM_MAXIMUMTOUCHES: Returns maximum simultaneous touch points (10) Limitations: - We explictly set pointer type to PT_TOUCH when storing pointer info to queue, so GetPointerType will always return PT_TOUCH - GetPointerFrameTouchInfo returns 0 pointers after finger lift, while Windows returns 1 pointer with UP flags. And SkipPointerFrameMessages is currently a stub returning TRUE. Qt's pointer message processing uses both of them, but it's just working well Application requirements: - Chromium: Requires GetPointerType and GetPointerTouchInfo for touch input - Qt applications: Need GetPointerFrameTouchInfo and proper system metrics for multi-touch support - Qt5: Additionally checks for presence of all pointer APIs at runtime, requiring stubs to enable pointer messages processing -- v3: GetPointerType: Drop into an error and return false when id or type is invalid https://gitlab.winehq.org/wine/wine/-/merge_requests/9628

3 7

Re: [PATCH v2 0/6] MR6051: win32u: Move layered window attributes update out of the drivers.
by Dmitry Timoshkov (＠dmitry) Dec. 1, 2025

Dec. 1, 2025

In case it was left unnoticed this MR caused a regression: https://bugs.winehq.org/show_bug.cgi?id=58914 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6051#note_124305

1 0

[PATCH v2 0/4] MR9616: Draft: opengl32: Implement GL_EXT_semaphore_win32 for base handle types.
by Derek Lesho (＠dlesho) Dec. 1, 2025

Dec. 1, 2025

Depends on !9574 and !9572 . -- v2: opengl32: Implement GL_EXT_semaphore_win32 for base handle types. opengl32: Implement GL_EXT_memory_object_win32 for base handle types. opengl32: Implement GL_DEVICE_LUID_EXT and GL_DEVICE_NODE_MASK_EXT. opengl32: Unify glGet* and fix typo in glGetDoublev. https://gitlab.winehq.org/wine/wine/-/merge_requests/9616

2 5

[PATCH 0/4] MR9638: ntdll: Fix handling of an arm64 unwind info corner case
by Martin Storsjö Dec. 1, 2025

Dec. 1, 2025

Also update existing tests for consistency, after previous changes, and take more tests into use. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9638

1 4

[PATCH v2 0/9] MR9618: windows.perception.stub: Stub SpatialAnchorExporter class.
by Paul Gofman (＠gofman) Dec. 1, 2025

Dec. 1, 2025

-- v2: coremessaging: Synchronize IAsyncInfo implementation in async.c. windows.security.credentials.ui.userconsentverifier: Synchronize IAsyncInfo implementation in async.c. windows.devices.enumeration: Synchronize IAsyncInfo implementation in async.c. cryptowinrt: Synchronize IAsyncInfo implementation in async.c. windows.gaming.input: Synchronize IAsyncInfo implementation in async.c. windows.media.speech: Synchronize IAsyncInfo implementation in async.c. windows.perception.stub: Implement exporter_statics_RequestAccessAsync(). windows.perception.stub: Stub SpatialAnchorExporter class. include: Add defintions related to Windows.Perception.Spatial.SpatialAnchorExporter. https://gitlab.winehq.org/wine/wine/-/merge_requests/9618

3 12

[PATCH 0/1] MR9632: sxs: avoid uninitialised len_name length
by Hans Chen (＠hans.chen) Dec. 1, 2025

Dec. 1, 2025

The `redirect_data->clrdata_len` [is unset in /dlls/ntdll/actctx.c#L4411-4412](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/ntdll/actctx.c?ref_type=heads#L4411-4412) when using registration-free COM in C# NET code. Program.cs ```C# //... Guid guid = Guid.Parse("COM clsid"); Type type = Type.GetTypeFromCLSID(guid, true); //... ``` App.manifest ```xml <assembly> <file name="ExampleCOM.dll"> <comClass description="ExampleCOM" progid="ExampleCOM" clsid="{COM clsid}" threadingModel="Free"/> </file> </assembly> ``` The above C# code gets this error on its second line. ```Shell System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. ``` This is because `len_name` is uninitialized when calling `memcpy(ret_strings, ptr_name, len_name);` in `SxsLookupClrGuid`, which is fixed in this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9632

3 4