February 2025 - Wine-GitLab

Re: [PATCH v2 0/1] MR7355: wined3d: Handle a NULL "push_constants" buffer in glsl_fragment_pipe_alpha_test_func(). - approved
by Alexandre Julliard (＠julliard) Feb. 26, 2025

Feb. 26, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7355

1 0

Re: [PATCH v2 0/2] MR7427: msxml3/tests: Remove tests that already run for msxml6. - approved
by Alexandre Julliard (＠julliard) Feb. 26, 2025

Feb. 26, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7427

1 0

Re: [PATCH v6 0/5] MR7370: winex11: Pass fullscreen flag to is_window_managed. - approved
by Alexandre Julliard (＠julliard) Feb. 26, 2025

Feb. 26, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7370

1 0

Re: [PATCH v5 0/1] MR7352: winewayland: Update locked pointer position hint. - approved
by Alexandre Julliard (＠julliard) Feb. 26, 2025

Feb. 26, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7352

1 0

[PATCH v5 0/7] MR7152: dxgi: Fix the frame latency waitable implementation.
by Giovanni Mascellani (＠giomasce) Feb. 26, 2025

Feb. 26, 2025

This is an alternative proposal to !5830. It fixes the same glitches in Horizon Zero Dawn, but attempts to do that by implementing the proper behavior expected from the swapchain. More precisely, it fixes a few mistakes I had made the last time I touched this code, it implements the frame latency waitable with a semaphore instead of an event (as it should be) and at last it uses the frame latency waitable to implement an appropriate wait after presentation when the client didn't request to manage the waitable directly. This implementation is not yet complete, because the semaphore should be released when the frame is presented. Knowing when this is the case would require using `VK_KHR_present_wait`. We currently approximate that with the moment in which the frame is submitted for presentation to Vulkan, which as far as I can tell is good enough. Eventually I'll try to write the proper thing. This MR depends on https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1343, which has been submitted in the meantime to vkd3d. The vkd3d change is included in the first commit, so this MR is already functional. -- v5: dxgi: Wait on the frame latency semaphore when the client doesn't do it. dxgi: Make the frame latency waitable a semaphore. dxgi: Remove the frame latency fence. dxgi: Directly signal the frame latency fence. dxgi: Do not bias the frame latency fence. dxgi: Set the frame latency even when increasing the frame latency. dxgi: Submit Vulkan presentation as soon as possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/7152

3 10

[PATCH v3 0/7] MR7422: winebus/dinput: Support arbitrary number of axes in the virtual PID descriptor
by Tomasz Pakuła Feb. 26, 2025

Feb. 26, 2025

Related Wine issue: https://bugs.winehq.org/show_bug.cgi?id=52714 I'm starting work on updating/extending Linux force feedback API and one of my goals is to expose the number and an array that contains the device's ffb-enabled axes. As I'm mainly working with USB PID driver, I already have a POC of obtaining this data. What prompted this is that currently Wine always creates virtual joysticks with two PID ffb axes. This causes issues with [Richard Burns Rally](https://github.com/ValveSoftware/Proton/issues/6702#issuecomment-267…, as this game incorrectly initializes a `CONSTANT_FORCE` effect with all the FFB axes that contain `DIDOI_FFACTUATOR` flag and then trying to update `cAxes` and `rgdwAxes` values which leads to `DIERR_INVALIDPARAM`. Now, this flag is set by wine while enumerating virtual device's axes and while `(axis index < FFB axes)`, flag is applied. This means, that every device which has FFB functionality and at least two axes, will report FFB on `X`, `Y`. While updated API would mean a lot of steering wheels would correctly report only 1 axis, a lot of USB PID wheels still include `X` and `Y` in their `AXES_ENABLE` and `DIRECTION` usages. This, again, would lead to broken FFB (in affected games). On Windows, there's a possibility of overwriting some joystick capabilities with registry entries, which ends up removing `DIDOI_FFACTUATOR` flag from a selected axis. This doesn't work in Wine. This MR allows Wine to add an arbitrary number (up to `PID_AXES_MAX`) of axes to the PID descriptor, based on the value of Haptic Axes from SDL or from Linux FF api in the future (I'm working on it). Additionally, to work around RBR and other games with similar, wrong FFB handling, I introduced a [hint](https://github.com/libsdl-org/SDL/issues/12341) to SDL that allows a dynamic overwrite of the number of haptic axes. For the Linux API, I'll figure out a nice way to override when the number of axes will be exposed. With these changes, I was able to successfully get force feedback on my Moza Racing R9 with all axes usable. With additional traces in the dinput code, I confirmed that with one axis defined in the PID descriptor, the game created a constant force effect with just one axis and `cAxes = 1`. -- v3: winebus: Get the number of haptic axes from SDL winebus: Support creation of arbitrary number of PID axes https://gitlab.winehq.org/wine/wine/-/merge_requests/7422

1 8

[PATCH 0/1] MR7428: wined3d: Use temporary buffer when stretching a surface to itself with cpu blit
by YuriK7 (＠riyu12383) Feb. 26, 2025

Feb. 26, 2025

Fixes https://bugs.winehq.org/show_bug.cgi?id=57283. I believe some sort of smart two pass stretching is possible, but not worth it. [dlls/wined3d/surface.c#L1570](https://gitlab.winehq.org/riyu12383/wine/-/bl… not exactly sure if it's related and should be removed then ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7428

3 2

[PATCH v4 0/5] MR5814: d3dx9, d3dcompiler: Do not emit implicit truncation warnings before version 42.
by Elizabeth Figura (＠zfigura) Feb. 26, 2025

Feb. 26, 2025

-- v4: d3dx9: Link versions 42 and 43 to the corresponding d3dcompiler DLL. d3dx9: Reimplement D3DXCompileShader() for versions before 42. d3dcompiler: Use D3DCompile2VKD3D() from vkd3d-utils. d3dcompiler: Use D3DPreprocess() from vkd3d-utils. https://gitlab.winehq.org/wine/wine/-/merge_requests/5814

3 11

[PATCH v3 0/2] MR7417: mfplat: Modify MFCreateWaveFormatExFromMFMediaType to allow MF_MT_AM_FORMAT_TYPE to be missing or set to GUID_NULL.
by Brendan McGrath (＠redmcg) Feb. 26, 2025

Feb. 26, 2025

This MR: - adds tests for when MF_MT_AM_FORMAT_TYPE is missing or set to GUID_NULL; and - modifies MFCreateWaveFormatExFromMFMediaType to pass these tests -- v3: mfplat: Allow MF_MT_USER_DATA to be missing for all subtypes. mfplat/tests: Add additional MFCreateWaveFormatExFromMFMediaType tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/7417

2 3

[PATCH v7 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Yuxuan Shui (＠yshui) Feb. 26, 2025

Feb. 26, 2025

## Context This is a problem discovered when running "Max: The Curse of Brotherhood" under proton. This game writes 4MB a piece into `wg_transform`, which contains about 4 seconds of compressed video. `wg_transform` calls `gst_pad_push` in `transform_ProcessOutput`, which takes \~300ms (i.e. 20 frames @ 60fps) to decode this buffer of video. So the end result is the game hitches every 4 seconds while playing cut scene videos. Proton currently has a special case for this particular game, for which it breaks up the buffer into small chunks to avoid long blocks. This MR adopts that and applies it generally. One concern raised by @redmcg is: > The only issue I can think of is if there are any decoders which don't have a parser; then they might not know how to deal with an arbitrary 4096 byte buffer (the parser is generally responsible for taking arbitrary buffers and producing something the decoder can work with, for example: a full frame). So this MR only enables this strategy when there is a parser element. -- v7: winegstreamer: Avoid large buffer pushes in wg_transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/7288

2 3