February 2025 - Wine-GitLab

[PATCH 0/1] MR7267: explorerframe: Return S_OK in more ITaskbarList3 functions.
by Sebastian Scheibner (＠sebastian) Feb. 5, 2025

Feb. 5, 2025

The software Helicon Filter 5 crashes at startup when it tries to call SetTabOrder and SetTabActive. And it crashes on shutdown when it tries to call UnregisterTab. Fake success return code as it was done in the following commit for some other functions already: 570ea014770fd62997be81e88f03829eded98390 <details><summary>Wine log from SetTabOrder to automatic starting of debugger</summary> <pre> 0134:fixme:explorerframe:taskbar_list_RegisterTab iface 027DE690, hwndTab 000103AC, hwndMDI 000100F0 stub! 0134:fixme:explorerframe:taskbar_list_SetTabOrder iface 027DE690, hwndTab 000103AC, hwndInsertBefore 00000000 stub! 0134:Call oleaut32.GetErrorInfo(00000000,00e6fdf4) ret=004c76b6 0134:Call combase.GetErrorInfo(00000000,00e6fdf4) ret=7bcebd50 0134:Ret combase.GetErrorInfo() retval=00000001 ret=7bcebd50 0134:Ret oleaut32.GetErrorInfo() retval=00000001 ret=004c76b6 0134:Call KERNEL32.FormatMessageA(00003200,00000000,80004001,00000000,00e6fc38,00000100,00000000) ret=0041da74 0134:Call ntdll.RtlFindMessage(7b5e0000,0000000b,00000000,80004001,00e6fb64) ret=7b65982a 0134:Ret ntdll.RtlFindMessage() retval=00000000 ret=7b65982a 0134:Call ntdll.RtlAllocateHeap(00350000,00000000,00010000) ret=7b5fcaaa 0134:Ret ntdll.RtlAllocateHeap() retval=09030020 ret=7b5fcaaa 0134:Call ntdll.RtlFormatMessage(7b76ddd0,00000000,00000001,00000001,00000001,00000000,09030020,00010000,00e6fbb4) ret=7b5fcb0a 0134:Ret ntdll.RtlFormatMessage() retval=00000000 ret=7b5fcb0a 0134:Call ntdll.RtlFreeHeap(00350000,00000000,00000000) ret=7b5fcb2f 0134:Ret ntdll.RtlFreeHeap() retval=00000001 ret=7b5fcb2f 0134:Call ntdll.RtlFreeHeap(00350000,00000000,09030020) ret=7b5fcbd6 0134:Ret ntdll.RtlFreeHeap() retval=00000001 ret=7b5fcbd6 0134:Ret KERNEL32.FormatMessageA() retval=00000011 ret=0041da74 0134:Call KERNEL32.RaiseException(0eedfade,00000001,00000007,00e6fda8) ret=0081acc3 0134:trace:seh:dispatch_exception code=eedfade (unknown) flags=1 addr=7B627448 0134:trace:seh:dispatch_exception info[0]=0081ACC3 0134:trace:seh:dispatch_exception info[1]=038A2B00 0134:trace:seh:dispatch_exception info[2]=80004001 0134:trace:seh:dispatch_exception info[3]=0081ACC3 0134:trace:seh:dispatch_exception info[4]=00000000 0134:trace:seh:dispatch_exception info[5]=00E6FDF8 0134:trace:seh:dispatch_exception info[6]=00E6FDC4 0134:trace:seh:dispatch_exception eip=7b627448 esp=00e6fd00 ebp=00e6fd58 eflags=00200246 0134:trace:seh:dispatch_exception eax=00e6fd00 ebx=00000018 ecx=00e6fd14 edx=00e6fda8 0134:trace:seh:dispatch_exception esi=00e6fdf8 edi=00e6fd70 cs=0023 ds=002b es=002b fs=0063 gs=006b ss=002b 0134:trace:seh:call_seh_handlers calling handler at 004C7770 code=eedfade flags=1 0134:trace:seh:call_seh_handlers handler at 004C7770 returned 1 0134:trace:seh:call_seh_handlers calling handler at 0081ACF2 code=eedfade flags=1 0134:trace:seh:call_seh_handlers handler at 0081ACF2 returned 1 0134:trace:seh:call_seh_handlers calling handler at 0081B18F code=eedfade flags=1 0134:trace:seh:call_seh_handlers handler at 0081B18F returned 1 0134:trace:seh:call_seh_handlers calling handler at 00902C31 code=eedfade flags=1 0134:trace:seh:call_seh_handlers handler at 00902C31 returned 1 0134:trace:seh:call_seh_handlers calling handler at 0096B5C7 code=eedfade flags=1 0134:trace:seh:call_seh_handlers handler at 0096B5C7 returned 1 0134:trace:seh:call_seh_handlers calling handler at 004059FC code=eedfade flags=1 0134:Call KERNEL32.UnhandledExceptionFilter(00e6f118) ret=00405a20 0134:Call ntdll.NtQueryInformationProcess(ffffffff,0000000c,00e6f084,00000004,00000000) ret=7b602304 0134:Ret ntdll.NtQueryInformationProcess() retval=00000000 ret=7b602304 0134:Call ntdll.NtCreateEvent(00e6f0ac,001f0003,00e6f0b0,00000000,00000000) ret=7b642f85 0134:Ret ntdll.NtCreateEvent() retval=00000000 ret=7b642f85 wine: Unhandled exception 0x0eedfade in thread 134 at address 7B627448 (thread 0134), starting debugger... </pre> </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7267

2 1

Re: [PATCH v3 0/1] MR7115: Added support of case FileAllocationInformation in SetFileInformationByHandle
by Stéphane Bacri Feb. 5, 2025

Feb. 5, 2025

@hans Thanks for the suggestion! Will use this one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7115#note_93717

1 0

[PATCH 0/1] MR7266: light.msstyles: Use light blue as hot tracking color instead of grey.
by Zhiyi Zhang (＠zhiyi) Feb. 5, 2025

Feb. 5, 2025

Fix erwin Data Modeler header text being grey. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7266

2 1

[PATCH 0/1] MR7265: winhttp: Accept server response without status text.
by Hans Leidekker (＠hans) Feb. 5, 2025

Feb. 5, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57794 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7265

3 2

Re: [PATCH v3 0/1] MR7115: Added support of case FileAllocationInformation in SetFileInformationByHandle
by Hans Leidekker (＠hans) Feb. 5, 2025

Feb. 5, 2025

posix_fallocate() looks like a better fit when increasing allocation size but you'd need to check the file size first, which introduces a race condition. posix_fallocate() will also increase the file size if the file is truncated by another thread. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7115#note_93690

1 0

[PATCH v2 0/1] MR7262: ieframe: Use wide character string literals.
by Alex Henrie (＠alexhenrie) Feb. 5, 2025

Feb. 5, 2025

-- v2: ieframe: Use wide character string literals. https://gitlab.winehq.org/wine/wine/-/merge_requests/7262

3 2

[PATCH v2 0/4] MR7260: wined3d: Clean up some FFP settings a bit.
by Elizabeth Figura (＠zfigura) Feb. 5, 2025

Feb. 5, 2025

-- v2: wined3d: Remove FOGVERTEXMODE handling from find_ps_compile_args(). wined3d: Remove the redundant per_vertex_point_size from vs_compile_args. wined3d: Do not toggle point sprite. wined3d: Do not disable point sprite in wined3d_context_gl_apply_blit_state(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7260

4 6

[PATCH 0/3] MR7222: wined3d: Housekeeping for NV12 support.
by Elizabeth Figura (＠zfigura) Feb. 5, 2025

Feb. 5, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7222

4 5

[PATCH 0/1] MR7264: prntvpt: Use Windows 10 version numbers.
by Dmitry Timoshkov (＠dmitry) Feb. 5, 2025

Feb. 5, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7264

3 2

[PATCH v11 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) Feb. 5, 2025

Feb. 5, 2025

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v11: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

3 4