March 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR7610: win32u: Create a shared object for user handle entries.
by Rémi Bernon March 19, 2025

March 19, 2025

For https://gitlab.winehq.org/wine/wine/-/merge_requests/7512 to use it to locate window shared objects. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7610

1 6

[PATCH v12 0/2] MR7607: Draft: win32u: Add stub for NtUserSetAdditionalForegroundBoostProcesses.
by Louis Lenders (＠xe) March 19, 2025

March 19, 2025

Microsoft Edge worked if windows version is set to win8.1 (or win7) but now crashes in current wine due to this unimplemented function. This patch makes it work again in win8.1 mode; (It's still broken in win10 mode, see https://bugs.winehq.org/show_bug.cgi?id=56378 for more info) -- v12: Fix typo https://gitlab.winehq.org/wine/wine/-/merge_requests/7607

2 2

[PATCH v3 0/8] MR7597: wintypes: Implement IBufferByteAccess::Buffer().
by Mohamad Al-Jaf (＠maljaf) March 19, 2025

March 19, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55759 -- v3: wintypes: Implement IBufferByteAccess::Buffer(). wintypes/tests: Add IBufferByteAccess::Buffer() tests. wintypes: Add IBufferByteAccess stub. wintypes: Implement IBuffer::get_Length(). wintypes: Implement IBuffer::put_Length(). wintypes: Implement IBuffer::get_Capacity(). wintypes: Implement IBufferFactory::Create(). wintypes/tests: Add IBufferFactory::Create() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/7597

3 9

Re: [PATCH v2 0/8] MR7597: wintypes: Implement IBufferByteAccess::Buffer().
by Mohamad Al-Jaf (＠maljaf) March 19, 2025

March 19, 2025

On Wed Mar 19 05:07:09 2025 +0000, Mohamad Al-Jaf wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/7597/diffs?diff_id=165075&start_sha=0c9df529abfdeb01208ee618b4cb766a0961ba69#d430fdc14e90f656acc7b2f3eb52d29c37bb640f_331_308) That's a better method, thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7597#note_98370

1 0

Re: [PATCH v2 0/8] MR7597: wintypes: Implement IBufferByteAccess::Buffer().
by Mohamad Al-Jaf (＠maljaf) March 19, 2025

March 19, 2025

On Wed Mar 19 05:07:15 2025 +0000, Rémi Bernon wrote: > Is it really useful to test such corner case here? I'm not sure what you mean by corner case, the test fails on i386 because 0xdeadbeef is too big of an allocation. In any case, letting malloc handle it makes the check unnecessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7597#note_98369

1 0

[PATCH v2 0/2] MR7606: user32/edit: Block key input when mouse input is captured.
by Nikolay Sivov (＠nsivov) March 19, 2025

March 19, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56108 -- v2: comctl32/edit: Block key input when mouse input is captured. user32/edit: Block key input when mouse input is captured. https://gitlab.winehq.org/wine/wine/-/merge_requests/7606

3 4

[PATCH 0/1] MR7599: COMCTL32: LVN_ENDLABELEDIT with empty text must send "" and not NULL
by Anders Kjersem (＠anders) March 19, 2025

March 19, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7599

4 5

[PATCH v11 0/1] MR7607: win32u: Add stub for NtUserSetAdditionalForegroundBoostProcesses.
by Louis Lenders (＠xe) March 19, 2025

March 19, 2025

Microsoft Edge worked if windows version is set to win8.1 (or win7) but now crashes in current wine due to this unimplemented function. This patch makes it work again in win8.1 mode; (It's still broken in win10 mode, see https://bugs.winehq.org/show_bug.cgi?id=56378 for more info) -- v11: win32u: Add stub for NtUserSetAdditionalForegroundBoostProcesses. https://gitlab.winehq.org/wine/wine/-/merge_requests/7607

3 3

Re: [PATCH v5 0/6] MR6866: ntdll: On macOS x86_64, swap GSBASE between the TEB and macOS TSD when entering/leaving PE code.
by Paul Gofman (＠gofman) March 18, 2025

March 18, 2025

Paul Gofman (@gofman) commented about dlls/ntdll/unix/signal_x86_64.c: > "callq *(%r10,%rax,8)\n\t" > "leaq -0x98(%rbp),%rcx\n\t" > __ASM_LOCAL_LABEL("__wine_syscall_dispatcher_return") ":\n\t" > + /* push rbp-based kernel stack cfi */ > + __ASM_CFI(".cfi_remember_state\n\t") > + __ASM_CFI_CFA_IS_AT2(rcx, 0xa8, 0x01) /* frame->syscall_cfa */ > + "leaq 0x70(%rcx),%rsp\n\t" /* %rsp > frame means no longer inside syscall */ Looks like patch subject is a bit misleading? "leaq 0x70(%rcx),%rsp\n\t" doesn't leave kernel stack, maybe "ntdll: Move stack to machine frame before accessing %gs in x86_64 syscall dispatcher."? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6866#note_98356

1 0

Re: [PATCH v5 0/6] MR6866: ntdll: On macOS x86_64, swap GSBASE between the TEB and macOS TSD when entering/leaving PE code.
by Brendan Shanks (＠bshanks) March 18, 2025

March 18, 2025

On Tue Mar 18 23:36:40 2025 +0000, Jinoh Kang wrote: > Yeah, I think so. FWIW, even with two MOVs, should be faster than one > MOV from GS indirect. Thanks, I suspect the performance impact is negligible but the patch is certainly cleaner. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6866#note_98354

1 0