March 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR7492: winegstreamer: Expand GST_ELEMENT_REGISTER* defines.
by Brendan McGrath (＠redmcg) March 5, 2025

March 5, 2025

These defines were only introduced to GStreamer in version 1.20; thus compiling against earlier versions causes a compilation error. This commit replaces the defines with their respective expansions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7492

3 2

[PATCH v3 0/7] MR6752: include: More fixes to build libc++.
by Rémi Bernon March 5, 2025

March 5, 2025

-- v3: include: Fix wmemchr C++ warning. include: Fix InlineIsEqualGUID C++ warning. include: Add some _BitScanForward(64) declarations in intrin.h. include: Add a __shiftright128 intrinsic definition. include: Add a _umul128 intrinsic definition. include: Move FILE_DISPOSITION_INFO after DeleteFile(A|W). include: Add a MB_CUR_MAX definition in ctype.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/6752

2 14

[PATCH 0/1] MR7496: xml2: Import upstream release 2.12.10.
by Daniel Lehman (＠dlehman25) March 5, 2025

March 5, 2025

To address: - CVE-2025-24928 - CVE-2024-56171 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7496

2 1

[PATCH v36 0/1] MR7400: cmd: Allow any key to continue past DIR /P pauses.
by Joe Souza (＠JoeS209) March 5, 2025

March 5, 2025

Current code requires entering a newline character in order to continue past DIR /P prompts. This change allows any key to be pressed instead. Code to handle this was similar to existing WCMD_pause() so we leveraged that code for this purpose as well. Key to the fix was the removal of ENABLE_LINE_INPUT from the console flags, and ENABLE_PROCESSED_INPUT was added in order to preserve the ability to abort the operation via Ctrl-C. -- v36: cmd: Allow any key to continue past DIR /P pauses. https://gitlab.winehq.org/wine/wine/-/merge_requests/7400

2 1

[PATCH v2 0/3] MR7482: Include defines
by Alistair Leslie-Hughes (＠alesliehughes) March 5, 2025

March 5, 2025

-- v2: include: Add sscanf_s define include: Add IID_PPV_ARGS macro include: More sal.h defines https://gitlab.winehq.org/wine/wine/-/merge_requests/7482

2 3

[PATCH 0/2] MR7493: mp3dmod: Implement an IMFTransform interface.
by Brendan McGrath (＠redmcg) March 5, 2025

March 5, 2025

This MR adds the IMFTransform interface to the mp3dmod module so that it can be used as an MFT. It also calls `MFTRegister` (so the MFT can be found via `MFTEnum`) and also registers a byte stream handler for the mp3 format. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7493

2 2

Re: [PATCH v11 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Brendan McGrath (＠redmcg) March 5, 2025

March 5, 2025

On Wed Mar 5 01:20:21 2025 +0000, Brendan McGrath wrote: > I was able to resolve this by copying the defines to our code (and > declaring them if GStreamer version is < 1.20): > [winegstreamer.patch](/uploads/caf23dfb5e167f828b2709b17eb519fb/winegstreamer.patch) > I'm not sure that's the way we want to go; but I'll raise an MR with > that (and I'll close it if there's a better option). I've raised MR !7492. In the end I decided expansion was the better option. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7288#note_96829

1 0

[PATCH v2 0/2] MR7490: shell32: mark FOLDERID_UserProgramFiles as CSIDL_Type_User
by Tingzhong Luo (＠tzluo) March 5, 2025

March 5, 2025

Fix the issue where some installers refuse to launch, due to `SHGetKnownFolderPath()` failing when called with `FOLDERID_UserProgramFiles`. -- v2: shell32/tests: add tests to get path of FOLDERID_USerProgramFiles shell32: mark FOLDERID_UserProgramFiles as CSIDL_Type_User https://gitlab.winehq.org/wine/wine/-/merge_requests/7490

2 2

Re: [PATCH v11 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Brendan McGrath (＠redmcg) March 5, 2025

March 5, 2025

On Wed Mar 5 01:20:21 2025 +0000, Brendan McGrath wrote: > I just tried to build this in a container running debian bullseye and > got the following error: > ``` > ../../dlls/winegstreamer/wg_transform.c:68:50: error: expected ')' > before string constant > 68 | GST_ELEMENT_REGISTER_DEFINE(winegstreamerstepper, > "winegstreamerstepper", GST_RANK_NONE, GST_TYPE_WG_STEPPER); > | ^~~~~~~~~~~~~~~~~~~~~~~ > | ) > ``` > I _think_ that's because bullseye is running gstreamer version 1.18, > whilst the documentation suggests `GST_ELEMENT_REGISTER_DEFINE` was > added version 1.20. > I think we'll need to address this as I _think_ Crossover is built > against bullseye. I was able to resolve this by copying the defines to our code (and declaring them if GStreamer version is < 1.20): [winegstreamer.patch](/uploads/caf23dfb5e167f828b2709b17eb519fb/winegstreamer.patch) I'm not sure that's the way we want to go; but I'll raise an MR with that (and I'll close it if there's a better option). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7288#note_96820

1 0

Re: [PATCH v11 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Brendan McGrath (＠redmcg) March 5, 2025

March 5, 2025

I just tried to build this in a container running debian bullseye and got the following error: ``` ../../dlls/winegstreamer/wg_transform.c:68:50: error: expected ')' before string constant 68 | GST_ELEMENT_REGISTER_DEFINE(winegstreamerstepper, "winegstreamerstepper", GST_RANK_NONE, GST_TYPE_WG_STEPPER); | ^~~~~~~~~~~~~~~~~~~~~~~ | ) ``` I _think_ that's because bullseye is running gstreamer version 1.18, whilst the documentation suggests `GST_ELEMENT_REGISTER_DEFINE` was added version 1.20. I think we'll need to address this as I _think_ Crossover is built against bullseye. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7288#note_96816

1 0