April 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) April 26, 2025

April 26, 2025

On Sat Apr 26 15:12:31 2025 +0000, eric pouech wrote: > looks to be that curPos can be \> \*numRead, hence reading garbage in > that case Line 312 terminates the buffer at *numRead, line 314 sets len to *numRead, and loop at 320 stops when !(curPos < len). Worst case is if curPos == len then we are checking the null terminator. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101952

1 0

[PATCH v2 0/1] MR7888: wbemprox: Implement Win32_CacheMemory table.
by Paul Gofman (＠gofman) April 26, 2025

April 26, 2025

-- v2: wbemprox: Implement Win32_CacheMemory table. https://gitlab.winehq.org/wine/wine/-/merge_requests/7888

3 3

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) April 26, 2025

April 26, 2025

On Sat Apr 26 17:10:07 2025 +0000, Joe Souza wrote: > Paths need to be quoted if they are long file names or they contain > spaces, hence the check for findData.cAlternateFileName. To do what you're asking here we would need to track whether each level in the path requires quotes, not just the current filename. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101950

1 0

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) April 26, 2025

April 26, 2025

On Sat Apr 26 15:12:32 2025 +0000, eric pouech wrote: > I think quote handling is not done as it should > from what I see on native: quotes are added when generated word does > contain characters that would need to be escaped (eg ' ', but didn't > check all the others) > need quote is an attribute of current filename (ie they are removed when > the new (partial) matching file no longer needs them) ; so quotes > shouldn't be part of the SEARCH_CONTEXT, but only used for display > (basically: go to beg of word; if needs quotes, print quote; print > (partial) word; print ending quotes (if needed) Paths need to be quoted if they are long file names or they contain spaces, hence the check for findData.cAlternateFileName. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101949

1 0

[PATCH 0/2] MR7884: odbc32: Fix some NULL pointer issues
by Stefan Dösinger April 26, 2025

April 26, 2025

I ran into this trying to use the Mac-Native MS SQL Server ODBC driver -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7884

2 3

[PATCH 0/1] MR7912: appwiz.cpl: Report addon download failures.
by Esme Povirk (＠madewokherd) April 26, 2025

April 26, 2025

This relates to https://bugs.winehq.org/show_bug.cgi?id=58160 but doesn't fix it, just reports the error instead of stalling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7912

2 1

[PATCH 0/1] MR7911: odbc32: Fix replicating unixODBC data sources.
by Hans Leidekker (＠hans) April 26, 2025

April 26, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58140 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7911

2 1

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) April 26, 2025

April 26, 2025

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + } > + lstrcatW(searchstr, L"*"); > + TRACE("New search: [%s]\n", wine_dbgstr_w(searchstr)); > + > + sc.isDirSearch = IsDirectoryOperation(inputBuffer, inputBufferLength); > + } > + > + FindNextMatchingDirectoryEntry(searchstr, &sc); > + > + if (sc.haveSearchResult) { > + /* If this is our first time through here for this search, we need to find the insert position > + * for the results. Note that this is very likely not the same location as the search position. > + */ > + if (!sc.insertPos) { > + /* If user entered a backslash after quotes, remove the quotes. */ > + if (curPos > 2 && inputBuffer[curPos-2] == L'\"' && inputBuffer[curPos-1] == L'\\') { I think quote handling is not done as it should from what I see on native: quotes are added when generated word does contain characters that would need to be escaped (eg ' ', but didn't check all the others) need quote is an attribute of current filename (ie they are removed when the new (partial) matching file no longer needs them) ; so quotes shouldn't be part of the SEARCH_CONTEXT, but only used for display (basically: go to beg of word; if needs quotes, print quote; print (partial) word; print ending quotes (if needed) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101937

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) April 26, 2025

April 26, 2025

didn't play a lot with resulting code, mostly reviewed it note: dir "c:\\Programs Files\\"\<tab\> should circle among the subdirectories... current code doesn't also dir c\<tab\> (with a first file displayed), then reduce size of console window to be shorter than input line, will display input on line after the prompt -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101938

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) April 26, 2025

April 26, 2025

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + int lastStartQuote; > + int searchPos; > + int insertPos; > +} SEARCH_CONTEXT, *PSEARCH_CONTEXT; > + > + > +static BOOL IsDirectoryOperation(const WCHAR *inputBuffer, const ULONG inputBufferLength) > +{ > + int cc = 0; > + BOOL ret = FALSE; > + > + while (cc < inputBufferLength && (inputBuffer[cc] == L' ' || inputBuffer[cc] == L'\t')) { > + cc++; > + } > + > + if ((cc + 2 < inputBufferLength && (inputBuffer[cc + 2] == L' ' || inputBuffer[cc + 2] == L'\t')) && questionning about finding the end of first word algorithm native behavior is very inconsistent `>cd\windows` (note that there's no space between "cd" and "\\"). is supported as command, but tab-completion on "windows" doesn't work **but** `>cd"\windows"` (idem no space, but with quotes). isn't supported as a command, but tab-completion does work since this relates to corner cases of user interaction, I'm not sure we want to mimic all these broken behaviors for consistency I'd rather suggest that you use `WCMD_parameter` to split the edit line into separate words you can then work upon this at least will provide consistency across all the code -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101935

1 0