April 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/2] MR7856: gdiplus: Simplify region code.
by Esme Povirk (＠madewokherd) April 19, 2025

April 19, 2025

Just some cleanups from the recent changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7856

2 2

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) April 19, 2025

April 19, 2025

On Sat Apr 19 16:23:57 2025 +0000, Joe Souza wrote: > Testing on Windows 11 this morning, I find that Windows does not filter > on .EXE or anything in PATHEXT if tab key is hit for first word on > command line. forgot to say that executable files must be in considered directory (eg if a.exe and e.bat exist in current directory, then 'a\<tab\>' shall circle around both files); PATH is not used -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101456

1 0

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) April 19, 2025

April 19, 2025

On Sat Apr 19 15:01:13 2025 +0000, Joe Souza wrote: > A bug in Wine's ReadConsole implementation that I found while making > these changes is that Wine does not handle ESC key correctly. On > Windows, ESC key clears the text on the screen and clears the buffer. > Wine emits the control character for the ESC key. I'll handle this in > my changes and add a FIXME comment. maybe. i could also be something that cmd implements in CONSOLE_READCONSOLE_CONTROL (using 0x1B in control mask). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101455

1 0

[PATCH v3 0/1] MR7801: combase: Add a stub for SetRestrictedErrorInfo().
by Nikolay Sivov (＠nsivov) April 19, 2025

April 19, 2025

Foobar 2000 crashes without it. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: combase: Add a stub for SetRestrictedErrorInfo(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

3 2

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) April 19, 2025

April 19, 2025

On Fri Apr 18 16:37:52 2025 +0000, Joe Souza wrote: > OK, using ReadConsole/CONSOLE_READCONSOLE_CONTROL on Windows gives me > the behaviour that I need; i.e. pre-filled text is preserved and can be > further edited. Caller must output the text first, but seems to work as expected. > I'll start making the changes to my code soon, within the coming days. A bug in Wine's ReadConsole implementation that I found while making these changes is that Wine does not handle ESC key correctly. On Windows, ESC key clears the text on the screen and clears the buffer. Wine emits the control character for the ESC key. I'll handle this in my changes and add a FIXME comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101451

1 0

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) April 19, 2025

April 19, 2025

On Sat Apr 19 14:56:08 2025 +0000, Joe Souza wrote: > Will definitely handle .exe filtering as a subsequent patch. Testing on Windows 11 this morning, I find that Windows does not filter on .EXE or anything in PATHEXT if tab key is hit for first word on command line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101450

1 0

[PATCH v2 0/1] MR7801: combase: Add a stub for SetRestrictedErrorInfo().
by Nikolay Sivov (＠nsivov) April 19, 2025

April 19, 2025

Foobar 2000 crashes without it. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: combase: Add a stub for SetRestrictedErrorInfo(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

3 3

[PATCH 0/1] MR7798: spoolss: Avoid buffer-overflow when setting numentries. (ASan)
by Bernhard Übelacker April 19, 2025

April 19, 2025

BuildOtherNamesFromMachineName writes sizeof(LPVOID) bytes but the test reserved just sizeof(DWORD), which makes a difference at amd64 and gets detected by ASan. <details> <summary>ASan output</summary> ``` ================================================================= ==spoolss_test.exe==700==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ffba0 at pc 0x6ffffdc53e38 bp 0x7ffffe1ffa40 sp 0x7ffffe1ffa88 WRITE of size 8 at 0x7ffffe1ffba0 thread T0 #0 0x6ffffdc53e37 in BuildOtherNamesFromMachineName .../wine/dlls/spoolss/spoolss_main.c:99:11 #1 0x00014000170e in test_BuildOtherNamesFromMachineName .../wine/dlls/spoolss/tests/spoolss.c:131:11 #2 0x000140001030 in func_spoolss .../wine/dlls/spoolss/tests/spoolss.c:218:5 #3 0x000140003ede in run_test .../wine/include/wine/test.h:765:5 #4 0x000140003a8e in main .../wine/include/wine/test.h #5 0x000140004963 in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #6 0x6fffffc3565e in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #7 0x6fffffdbbcc2 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004bcc2) Address 0x7ffffe1ffba0 is located in stack of thread T0 at offset 64 in frame #0 0x00014000164f in test_BuildOtherNamesFromMachineName .../wine/dlls/spoolss/tests/spoolss.c:122 This frame has 2 object(s): [32, 40) 'buffers' (line 123) [64, 68) 'numentries' (line 124) <== Memory access at offset 64 partially overflows this variable HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/dlls/spoolss/spoolss_main.c:99:11 in BuildOtherNamesFromMachineName Shadow bytes around the buggy address: 0x7ffffe1ff900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffa00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffa80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffb00: 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1 f1 f1 =>0x7ffffe1ffb80: 00 f2 f2 f2[04]f3 f3 f3 00 00 00 00 00 00 00 00 0x7ffffe1ffc00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc80: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 f8 f8 f8 f8 0x7ffffe1ffd00: f8 f8 f8 f8 f3 f3 f3 f3 00 00 00 00 00 00 00 00 0x7ffffe1ffd80: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 00 00 00 00 0x7ffffe1ffe00: 00 00 00 00 00 00 00 00 00 00 00 00 f2 f2 f2 f2 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==spoolss_test.exe==700==ABORTING ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7798

2 3

[PATCH 0/1] MR7801: combase: Add a stub for SetRestrictedErrorInfo().
by Nikolay Sivov (＠nsivov) April 19, 2025

April 19, 2025

Foobar 2000 crashes without it. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

3 2

[PATCH v3 0/1] MR7838: mfplat/tests: Don't assume video processor MFT can provide samples.
by Charlotte Pabst (＠CharlottePabst) April 19, 2025

April 19, 2025

This fixes a test failure/crash on Windows 8.1 introduced by dd1d82728811c15716eefa0917eb3ecac4b9a85a. -- v3: mfplat/tests: Don't assume video processor MFT can provide samples. https://gitlab.winehq.org/wine/wine/-/merge_requests/7838

3 2