April 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR7817: winebth.sys part 10: Add support for removing/disconnecting devices.
by Vibhav Pant (＠vibhavp) April 14, 2025

April 14, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7817

2 5

[PATCH v3 0/1] MR7676: winegstreamer: Make sure WMSyncReader never reads in the background.
by Yuxuan Shui (＠yshui) April 14, 2025

April 14, 2025

WMSyncReader starts a background read thread that reads from the IStream passed to IWMSyncReader::OpenStream. This means it could use the IStream in the background even when no IWMSyncReader methods are being called. For well-behaved applications, this is probably OK. However, AQUARIUM (Steam 2515070) frees the IStream it passes to WMSyncReader _before_ it calls IWMSyncReader::Close, which stops the read thread. This causes the read thread to access freed memory. This is improper, but not unreasonable, as IWMSyncReader is supposed to be a synchronous interface, so one might assume when they weren't calling into IWMSyncReader methods, the IStream won't be used. This commit adds a `wg_parser_dont_read` function, which can be used to stop wg_parser from issuing read requests. This is used by IWMSyncReader to make sure read requests are only issued when IWMSyncReader methods are being called. -- v3: winegstreamer: Make sure WMSyncReader never reads in the background. https://gitlab.winehq.org/wine/wine/-/merge_requests/7676

2 2

[PATCH v5 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Charlotte Pabst (＠CharlottePabst) April 14, 2025

April 14, 2025

This fixes a misbehaving proton game that sets MF_XVP_PLAYBACK_MODE. MF_XVP_PLAYBACK_MODE isn't mentioned in microsoft docs, but it's explained and used in the MIT-licensed [Windows-classic-samples](https://github.com/microsoft/Windows-classic-sampl… Not sure if mfplat is the right place to add the tests for this since the code is in winegstreamer, but it's very similar to the existing mfplat tests and the test does not interface with winegstreamer directly. It should be noted that on windows, ProcessOutput errors out if we provide a pSample with MF_XVP_PLAYBACK_MODE unset, wine simply ignores it. -- v5: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE. mfplat/tests: Add test for MF_XVP_PLAYBACK_MODE. https://gitlab.winehq.org/wine/wine/-/merge_requests/7796

3 4

[PATCH v4 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Charlotte Pabst (＠CharlottePabst) April 14, 2025

April 14, 2025

This fixes a misbehaving proton game that sets MF_XVP_PLAYBACK_MODE. MF_XVP_PLAYBACK_MODE isn't mentioned in microsoft docs, but it's explained and used in the MIT-licensed [Windows-classic-samples](https://github.com/microsoft/Windows-classic-sampl… Not sure if mfplat is the right place to add the tests for this since the code is in winegstreamer, but it's very similar to the existing mfplat tests and the test does not interface with winegstreamer directly. It should be noted that on windows, ProcessOutput errors out if we provide a pSample with MF_XVP_PLAYBACK_MODE unset, wine simply ignores it. -- v4: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE. mfplat/tests: Add test for MF_XVP_PLAYBACK_MODE. https://gitlab.winehq.org/wine/wine/-/merge_requests/7796

3 5

[PATCH v3 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Charlotte Pabst (＠CharlottePabst) April 14, 2025

April 14, 2025

This fixes a misbehaving proton game that sets MF_XVP_PLAYBACK_MODE. MF_XVP_PLAYBACK_MODE isn't mentioned in microsoft docs, but it's explained and used in the MIT-licensed [Windows-classic-samples](https://github.com/microsoft/Windows-classic-sampl… Not sure if mfplat is the right place to add the tests for this since the code is in winegstreamer, but it's very similar to the existing mfplat tests and the test does not interface with winegstreamer directly. It should be noted that on windows, ProcessOutput errors out if we provide a pSample with MF_XVP_PLAYBACK_MODE unset, wine simply ignores it. -- v3: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE. mfplat/tests: Add test for MF_XVP_PLAYBACK_MODE. https://gitlab.winehq.org/wine/wine/-/merge_requests/7796

3 11

[PATCH 0/3] MR7816: bcrypt/tests: Add support for exporting/importing AES wrapped blob with different key sizes.
by Dmitry Timoshkov (＠dmitry) April 14, 2025

April 14, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7816

3 4

[PATCH v2 0/1] MR7809: server: Do not call setpriority() if it cannot be used safely.
by Conor McCarthy (＠cmccarthy) April 14, 2025

April 14, 2025

Not checking nice_limit here can result in some calls to setpriority() succeeding while others fail, which can result in relative priorities being incorrect. For example, buffer underflows can occur in winepulse.drv because the priority is too low in pulse_timer_loop(). -- v2: server: Do not call setpriority() if it cannot be used safely. https://gitlab.winehq.org/wine/wine/-/merge_requests/7809

2 1

[PATCH v3 0/1] MR7810: cryptext: Implement CryptExtOpenCER.
by Dmitry Timoshkov (＠dmitry) April 14, 2025

April 14, 2025

-- v3: cryptext: Implement CryptExtOpenCER. https://gitlab.winehq.org/wine/wine/-/merge_requests/7810

5 4

[PATCH 0/1] MR7814: winex11.drv: Map driver DC coordinates to raw monitor DPI.
by Zhiyi Zhang (＠zhiyi) April 14, 2025

April 14, 2025

This is similar to 1529ab0ac7a3591cad301d7b3cbb0a7d85377f3e. DOOM (379720) doesn't change back to the original resolution when entering windowed mode from non-native fullscreen mode on the secondary monitor. So after that, the raw and effective monitor DPI differs when emulate_modeset is on, and Wine needs to scale the game window according to DPI. Wine's built-in title bar is drawn using NtGdiGradientFill() in draw_caption_bar(). On Linux, NtGdiGradientFill() eventually calls xrenderdrv_GradientFill(). However, the lp_to_dp() in winex11.drv doesn't map coordinates to raw monitor DPI. So the title bar drawn in this case is too small and looks corrupted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7814

2 2

[PATCH 0/2] MR7809: server: Do not call setpriority() if it cannot be used safely.
by Conor McCarthy (＠cmccarthy) April 14, 2025

April 14, 2025

Not checking nice_limit here can result in some calls to setpriority() succeeding while others fail, which can result in relative priorities being incorrect. For example, buffer underflows can occur in winepulse.drv because the priority is too low in pulse_timer_loop(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7809

3 3