April 2025 - Wine-GitLab - list.winehq.org

[PATCH v2 0/2] MR7713: ntdll/tests, kernel32/tests: Use the PROCESS_BASIC_INFORMATION struct.
by Rémi Bernon April 9, 2025

April 9, 2025

-- v2: ntdll/tests: Use the public PROCESS_BASIC_INFORMATION definition. kernel32/tests: Use the public PROCESS_BASIC_INFORMATION definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/7713

1 3

Re: [PATCH v13 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) April 9, 2025

April 9, 2025

On Tue Apr 8 17:12:58 2025 +0000, Elizabeth Figura wrote: > Yes, someone needs to come up with better a solution to the file > deletion problem. I don't think this series is going to be accepted > without one. The following change was added at https://gitlab.winehq.org/wine/wine/-/merge_requests/7650/diffs?commit_id=4… to fix this issue: ``` /* st was set from the file name if the file could not be opened */ if (fd->unix_fd != -1) fstat( fd->unix_fd, &st ); ``` Anything else to fix ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100370

1 0

[PATCH v14 0/1] MR7752: activeds: Implement ADsBuildVarArrayInt.
by Daniel Martin (＠danlm) April 9, 2025

April 9, 2025

Implementation and test function for ADsBuildVarArrayInt, using ADsBuildVarArrayStr as reference. - /dlls/activeds/activeds_main.c - /dlls/activeds/tests/activeds.c - /include/adshlp.h -- v14: activeds: Implement ADsBuildVarArrayInt. https://gitlab.winehq.org/wine/wine/-/merge_requests/7752

2 1

[PATCH 0/6] MR7775: shell32: Test and rework rename operation.
by Ziqing Hui (＠zhui) April 9, 2025

April 9, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7775

2 6

Re: [PATCH v2 0/2] MR7767: win32u: Add support WM_IME_KEYDOWN message translate
by Byeongsik Jeon (＠bsjeon) April 8, 2025

April 8, 2025

Updated the commit message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7767#note_100363

1 0

Re: [PATCH v3 0/1] MR7766: win32u: Preserve result string from multiple WINE_IME_POST_UPDATE call during ImeProcessKey.
by Byeongsik Jeon (＠bsjeon) April 8, 2025

April 8, 2025

On Tue Apr 8 12:49:49 2025 +0000, Rémi Bernon wrote: > I think this loses the previous result if it was != NULL but the new > update has result_str == NULL. What about: > ```suggestion:-45+0 > struct imm_thread_data *data = get_imm_thread_data(); > UINT id = -1, comp_len, result_len, prev_result_len; > WCHAR *prev_result_str, *tmp; > struct ime_update *update; > TRACE( "hwnd %p, cursor_pos %u, comp_str %s, result_str %s\n", hwnd, cursor_pos, > debugstr_w(comp_str), debugstr_w(result_str) ); > comp_len = comp_str ? wcslen( comp_str ) + 1 : 0; > result_len = result_str ? wcslen( result_str ) + 1 : 0; > /* prepend or keep the previous result string, if there was any */ > if (!data->ime_process_vkey || !data->update) prev_result_str = NULL; > else prev_result_str = data->update->result_str; > prev_result_len = prev_result_str ? wcslen( prev_result_str ) + 1 : 0; > if (!prev_result_len && !result_len) tmp = NULL; > else if (!(tmp = malloc( (prev_result_len + result_len) * > sizeof(WCHAR) ))) return; > if (prev_result_len && result_len) prev_result_len -= 1; /* concat > both strings */ > if (prev_result_len) memcpy( tmp, prev_result_str, prev_result_len * > sizeof(WCHAR) ); > if (result_len) memcpy( tmp + prev_result_len, result_str, > result_len * sizeof(WCHAR) ); > result_len += prev_result_len; > result_str = tmp; > if (!(update = malloc( offsetof(struct ime_update, buffer[comp_len + > result_len]) ))) return; > update->cursor_pos = cursor_pos; > update->comp_str = comp_str ? memcpy( update->buffer, comp_str, > comp_len * sizeof(WCHAR) ) : NULL; > update->result_str = result_str ? memcpy( update->buffer + comp_len, > result_str, result_len * sizeof(WCHAR) ) : NULL; > if (!(update->vkey = data->ime_process_vkey)) > { > pthread_mutex_lock( &imm_mutex ); > id = update->scan = ++ime_update_count; > update->vkey = VK_PROCESSKEY; > list_add_tail( &ime_updates, &update->entry ); > pthread_mutex_unlock( &imm_mutex ); > NtUserPostMessage( hwnd, WM_WINE_IME_NOTIFY, > IMN_WINE_SET_COMP_STRING, id ); > } > else > { > update->scan = data->ime_process_scan; > free( data->update ); > data->update = update; > } > free( result_str ); > ``` Yes. That's where the previous ime_update calls are ignored. This is fine for comp_str, but it's problematic for result_str. The change you suggest is similar to my personal early version. v1 removed the malloc addition and compacted the code, but now that I look at it, it seems too implicit, so I've updated it with the code you suggest. I changed a small memory freeing problem. Also, v1 had a meaningless dead code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7766#note_100361

1 0

Re: [PATCH v3 0/1] MR7766: win32u: Preserve result string from multiple WINE_IME_POST_UPDATE call during ImeProcessKey.
by Byeongsik Jeon (＠bsjeon) April 8, 2025

April 8, 2025

Updated the commit message and removed the bracket characters. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7766#note_100360

1 0

[PATCH v13 0/1] MR7752: activeds: Implement ADsBuildVarArrayInt.
by Daniel Martin (＠danlm) April 8, 2025

April 8, 2025

Implementation and test function for ADsBuildVarArrayInt, using ADsBuildVarArrayStr as reference. - /dlls/activeds/activeds_main.c - /dlls/activeds/tests/activeds.c - /include/adshlp.h -- v13: activeds: Implement ADsBuildVarArrayInt. https://gitlab.winehq.org/wine/wine/-/merge_requests/7752

2 2

[PATCH v12 0/1] MR7752: activeds: Implement ADsBuildVarArrayInt.
by Daniel Martin (＠danlm) April 8, 2025

April 8, 2025

Implementation and test function for ADsBuildVarArrayInt, using ADsBuildVarArrayStr as reference. - /dlls/activeds/activeds_main.c - /dlls/activeds/tests/activeds.c - /include/adshlp.h -- v12: activeds: Implement ADsBuildVarArrayInt. https://gitlab.winehq.org/wine/wine/-/merge_requests/7752

2 1

[PATCH v4 0/2] MR7672: Draft: mfplat/tests: Add tests for Byte Stream Output.
by Brendan McGrath (＠redmcg) April 8, 2025

April 8, 2025

This MR adds tests that examine the values of the samples output by the byte stream handlers. It is marked as draft as it is dependent on the fixes included within MR !7569. I've also renamed the tests as they previously exclusively tested the sample output timestamps. The tests now also look at the number of buffers included in a sample and total size of the buffers within a sample. -- v4: mfplat/tests: Add tests for MP3 Byte Stream Output. mfplat/tests: Add tests for Byte Stream Output. https://gitlab.winehq.org/wine/wine/-/merge_requests/7672

3 6