April 2025 - Wine-GitLab - list.winehq.org

[PATCH v11 0/1] MR4809: Draft: wip! winewayland.drv: Try to support smooth scroll events
by Ray Strode (＠halfline) May 20, 2025

May 20, 2025

Wayland has 3 types of scrolling events: - axis. Used for e.g., touchpad 2 finger smooth scrolling - axis_discrete. Used for mouse scroll wheels (i.e., notches) - axis_value120. Used for high resolution input devices Wine currently only supports axis_discrete, meaning that 2 finger scroll events get ignored. This commit tries to add basic support for axis scrolling events, by translating the smooth motion in scroll increments using some primitive assumptions about line height and number of lines to scroll. -- v11: wip! winewayland.drv: Try to support smooth scroll events https://gitlab.winehq.org/wine/wine/-/merge_requests/4809

5 10

[PATCH 0/1] MR7920: winecoreaudio: Fallback to pre-per-channel audio if the audio device does not support it
by Ada Ahmed (＠yretenai) May 17, 2025

May 17, 2025

I was able to replicate the issue seen in [Bug 58113](https://bugs.winehq.org/show_bug.cgi?id=58113) on my M1. The issue stems from the usage of AudioDevicePropertyVolumeScalar, which the audio driver for the M1 does not support (at least so it appears.) Using AudioObjectIsPropertySettable allows for fast checking for this situation, including preemptively disabling main channel audio if it appears to be unsupported. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7920

4 11

[PATCH v8 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) May 15, 2025

May 15, 2025

This MR modifies winegstreamer to match Windows behaviour in that: 1. the video decoders will output the PTS and duration of the input sample (if provided); and 2. the WMV decoder will set any value not provided to zero It also adds support for supplying a DTS value to the MFTs. I've marked this as draft as it fixes the tests in MR !7563 (in addition to fixing some existing `test_wmv_decoder` tests). Also, as demonstrated in MR !7569, our demuxers output different timestamps to Windows. This change will result in those different timestamps being forwarded from the decoder. So we may also want to address that difference prior to accepting this MR. -- v8: winegstreamer: Use provided PTS and duration in video_decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/7623

3 9

[PATCH 0/3] MR6025: winewayland: Support shaped and transparent windows.
by Rémi Bernon May 15, 2025

May 15, 2025

First commit fixes a deadlock when resizing a window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6025

2 13

[PATCH v6 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) May 15, 2025

May 15, 2025

In CopyFileEx, and DeleteFile functions, by default, the file name and path are limited to MAX_PATH characters. To extend this limit to 32,767 wide characters, need prepend "\\\\?\\" to the path. -- v6: kernelbase: Limit the maximum path length for DeleteFile. kernelbase: Fix DeleteFileA doesn't support long path. kernelbase: Limit the maximum path length for filesystem. ntdll: Check if long path aware is enabled. kernel32/tests: Add tests for maximum path length limitation. https://gitlab.winehq.org/wine/wine/-/merge_requests/7540

3 10

[PATCH v4 0/1] MR7181: winex11: Avoid creating windows with override-redirect flag set.
by Rémi Bernon May 15, 2025

May 15, 2025

This confuses mutter and it manifests with spurious IconicState WM_STATE change when it decides to try managing the window, but it also makes it randomly lose focus or even fail to map the window back on screen. Adding the flag after the window has been created fixes the issue. -- v4: winex11: Avoid creating windows with override-redirect flag set. https://gitlab.winehq.org/wine/wine/-/merge_requests/7181

1 2

[PATCH 0/1] MR7456: Draft: [RFC] ddraw/tests: Set DPI awareness to avoid unexpected clip rect.
by Bernhard Übelacker May 15, 2025

May 15, 2025

Hello, I wondered about the ddraw* tests, which show a similar message `Expect clip rect (0,0)-(1920,1080), got (0,0)-(1536,864).` over a range of Windows 10 machines. This seems the same as discussed in: https://bugs.winehq.org//show_bug.cgi?id=54068 . I searched just the internet for "1536,864" which also points to the direction of something DPI related. So I tested if it disappears with a call to `SetProcessDpiAwareness(PROCESS_PER_MONITOR_DPI_AWARE);`, and in seems it does. https://testbot.winehq.org/JobDetails.pl?Key=151556 (The failures with debiant and w11pro64_amd seem to be also there with a null patch: https://testbot.winehq.org/JobDetails.pl?Key=151557 ) Would such a change be acceptable, or would it defeat the purpose of the test? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7456

2 4

[PATCH v2 0/1] MR7872: shell32: Avoid writing past end of xlpFile or lpResult in SHELL_FindExecutable().
by Paul Gofman (＠gofman) May 15, 2025

May 15, 2025

-- v2: shell32: Avoid writing past end of xlpFile or lpResult in SHELL_FindExecutable(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7872

3 3

[PATCH 0/1] MR7823: winegstreamer: Allow decodebin to eliminate caps that don't use system memory.
by Brendan McGrath (＠redmcg) May 15, 2025

May 15, 2025

This speeds up pipeline creation and fixes a timing issue where caps negotiation is not completed prior to the first buffer being sent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7823

3 9

[PATCH v4 0/4] MR2127: ntdll: Load known dlls from system directory
by Paul Gofman (＠gofman) May 15, 2025

May 15, 2025

The practical issue I am trying to solve is the following scenario (encountered with a game using some Uplay plugin) which has regressed with apisets implementation in Wine. The game imports ucrtbase.dll. Then, a plugin calls GetModuleHandle("api-ms-win-crt-runtime-l1-1-0.dll") and expects GetProcAddress("\_crt_atexit") to succeed on the returned handle. The problem is that the game has ucrtbase.dll in its .exe directory. That one currently gets loaded. Then, find_dll_file() resolves api-ms-win-crt-runtime-l1-1-0.dll to the ucrtbase with a full path in system32 and tries to find that one (this part matches Windows behaviour as far as tests show). Since we have ucrtbase loaded with another path this results in NULL module handle. Windows maintains the list of "Known DLLs" (probably aimed for speeding up processes startup by using pre-mapped dll images for commonly used system dlls). On Windows, known dlls have specifics in load path resolution when dll name doesn't contain path (relative or full): - they are loaded from system directory even if there is another dll with the same name in priority search path; - they are found even if library search paths do not contain system directory; Those "Known DLLs" are basically listed in HKLM\\System\\CurrentControlSet\\Control\\Session Manager\KnownDLLs registry key. But the actual list of "known dlls" is bigger (probably includes all dependencies of those listed under registry key). The full actual list of "known dlls" is in '\\KnownDlls\' directory object which contains image sections under dll names. Most notably, ucrtbase.dll (which is of the concern in the regression) is not listed in registry but is present in \\KnownDlls. Technically nothing prevents us from implementing these mechanics and creating directory object with mapped load dlls, also resolving the explicitly listed dlls' dependencies. But it is not apparent to me if that is going to improve load times noticably in Wine, and also that is worth the inherent complications until anything actually depends on that \\KnownDlls sections. So instead of implementing all of that throughout the loader I added a few missing dlls to registry. The current list in this pat chset corresponds to the contents of \\KnownDlls directory on an up to date Windows 10. -- v4: ntdll: Load known dlls from system directory. loader/wine.inf: Add known dlls key. ntdll: Factor out prepend_system_dir() function. kernel32/tests: Add tests for known dlls load specifics. https://gitlab.winehq.org/wine/wine/-/merge_requests/2127

4 8