May 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/12] MR8148: opengl32: Implement wglShareLists directly.
by Rémi Bernon May 30, 2025

May 30, 2025

v4: Fix some missing harmless make_opengl changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8148#note_104979

1 0

[PATCH 0/1] MR8181: po: Update Polish translation
by Adam Markowski (＠AMark) May 30, 2025

May 30, 2025

Newest strings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8181

2 1

[PATCH v3 0/5] MR8174: winebth.sys part 12: Introduce support for Low Energy GATT services
by Vibhav Pant (＠vibhavp) May 30, 2025

May 30, 2025

Generic ATTribute Profile (GATT) is a protocol used by BLE devices for data exchange. Broadly, every LE device contains one or more GATT services, with each service having multiple characteristics, which contain the actual piece of data to be exchanged. The Win32 BLE api is defined in [`bluetoothleapis.h`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/), and operates on `HANDLE`s to PDOs created by the driver to remote devices and services, using the `GUID_BLUETOOTHLE_DEVICE_INTERFACE` and `GUID_BLUETOOTH_GATT_SERVICE_DEVICE_INTERFACE` class interfaces respectively. This MR introduces initial support for accessing GATT services on LE devices: * Create PDOs for remote devices that we discover GATT services on, and enabling `GUID_BLUETOOTHLE_DEVICE_INTERFACE` for them. * Because the driver also creates PDOs for bluetooth radios, a tagged union is used to distinguish between device extension values to dispatch IOCTL and PnP IRPs appropriately. * Enumerate through all `org.bluez.GattService1` objects on BlueZ, and store them on the PE driver inside the associated devices. * Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES for device PDOs. * Use the newly added IOCTL to implement [`BluetoothGATTGetServices`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/nf-bluetoothleapis-bluetoothgattgetservices). -- v3: bluetoothapis/tests: Add tests for BluetoothGATTGetServices. bluetoothapis: Implement BluetoothGATTGetServices. https://gitlab.winehq.org/wine/wine/-/merge_requests/8174

2 6

[PATCH 0/1] MR8171: wintrust: Initialize all cert fields in WINTRUST_AddCert.
by Alex Henrie (＠alexhenrie) May 30, 2025

May 30, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58293 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8171

3 2

[PATCH v2 0/1] MR8179: crypt32: Fix invalid access of list head.
by Yuxuan Shui (＠yshui) May 30, 2025

May 30, 2025

At the end of LIST_FOR_EACH_ENTRY, assuming no matches are found, `provider` will point to the list head, not NULL, as a result we call IsEqualGUID on invalid memory. -- v2: crypt32: Fix invalid access of list head. https://gitlab.winehq.org/wine/wine/-/merge_requests/8179

2 1

[PATCH v4 0/2] MR7920: winecoreaudio: revert unix_set_volumes
by Ada Ahmed (＠yretenai) May 30, 2025

May 30, 2025

I was able to replicate the issue seen in [Bug 58113](https://bugs.winehq.org/show_bug.cgi?id=58113) on my M1. The issue stems from the usage of AudioDevicePropertyVolumeScalar, which the audio driver for the M1 does not support (at least so it appears.) Using AudioObjectIsPropertySettable allows for fast checking for this situation, including preemptively disabling main channel audio if it appears to be unsupported. -- v4: winecoreaudio: quality improvements Revert "winecoreaudio: Implement per-channel volume control." https://gitlab.winehq.org/wine/wine/-/merge_requests/7920

2 3

[PATCH v6 0/3] MR8095: server: Update full window invalidate rect with window resize.
by Rémi Bernon May 30, 2025

May 30, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58210 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38975 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8013 -- v6: server: Update fill window invalidate rect with window resize. server: Pass NULL as child region if region is NULL. https://gitlab.winehq.org/wine/wine/-/merge_requests/8095

3 8

[PATCH v2 0/2] MR8172: mfreadwrite: Fix media type output when video processor is used.
by Brendan McGrath (＠redmcg) May 30, 2025

May 30, 2025

This is required to fix video playback in Crashlands 2 on Proton 10. -- v2: mfreadwrite: Fix media type output when video processor is used. mfreadwrite/tests: Check DEFAULT_STRIDE is not always present. https://gitlab.winehq.org/wine/wine/-/merge_requests/8172

2 3

[PATCH v3 0/2] MR7920: winecoreaudio: revert unix_set_volumes
by Ada Ahmed (＠yretenai) May 29, 2025

May 29, 2025

I was able to replicate the issue seen in [Bug 58113](https://bugs.winehq.org/show_bug.cgi?id=58113) on my M1. The issue stems from the usage of AudioDevicePropertyVolumeScalar, which the audio driver for the M1 does not support (at least so it appears.) Using AudioObjectIsPropertySettable allows for fast checking for this situation, including preemptively disabling main channel audio if it appears to be unsupported. -- v3: winecoreaudio: Fixed outdated params, improvements Revert "winecoreaudio: Implement per-channel volume control." https://gitlab.winehq.org/wine/wine/-/merge_requests/7920

3 4

Re: [PATCH v3 0/2] MR7880: combase: Fix refcount leak fix in apartment_hostobject
by Kevin Puetz (＠puetzk) May 29, 2025

May 29, 2025

On Tue Apr 22 19:17:10 2025 +0000, Kevin Puetz wrote: > Yes, but not as rebased to master (we're quite a bit behind, so I just > ran things through testbot.winehq.org before submitting rather than > doing a full local build of 10.6). I'll mark as draft for now and do > some more testing... Ok, my apologies that this took so long to get back to. The fix was sound, but the test was completely flawed and I'm not sure how it seemed to work the first time. The key problem is that, since the whole scenario involves a hostapartment, the class factory will be a proxy. And to keep cross-thread traffic down, proxies keep their own refcount, with the proxy owning a single refcount to the stub, which owns a single refcount to the real implementing object. So observing the refcount of the proxy could never have shown whether the actual implementation had been leaked. So now the test instead checks the way we observed the problem in real life - we put a "real" CLSID in to testlib.dll, and notice that the existence of any external refcounts on the class factory object has caused testlib.dll's DllCanUnloadNow to return S_FALSE. So now the compobj test I added seems OK ole32:compobj start dlls/ole32/tests/compobj.c ole32:compobj:0c0c done (0) in 2s 1498B However, pipeline is still showing VM failure on mac > no IP address found, is your VM running And a failure on linux-32, not in the test I changed: > ole32:clipboard:0bf8 done (0) in 0s 5076B > ole32:compobj start dlls/ole32/tests/compobj.c which is where my new test is - the failure is later > ole32:marshal start dlls/ole32/tests/marshal.c > marshal.c:4214:0.026 Test failed: got 0 > marshal.c:4223:0.027 Test failed: Number of locks should be 0, but actually is 2 These marshal.c failures seem to be present in other PRs too (including ones that merged last night), so I assume they are unrelated... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7880#note_104932

1 0