May 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v17 0/1] MR6199: winewayland: Fix release_all_keys's modifier filtering.
by Alexandros Frantzis (＠afrantzis) May 23, 2025

May 23, 2025

Hi @yurih, from what I understand the reason alt(-tab) is problematic is because the alt menu mode is enabled when the key is released. However, avoiding the release just for this behavior doesn't seem like a viable way forward, since other applications may treat alt differently or may also require treating other keys the same way. I was experimenting a bit and sending WM_CANCELMODE (which winex11 does already) seems to help with the alt(-tab) menu situation in my tests. Could you try the following and let me know if it helps with your use case: ```patch --- a/dlls/winewayland.drv/wayland_keyboard.c +++ b/dlls/winewayland.drv/wayland_keyboard.c @@ -800,6 +800,11 @@ static void keyboard_handle_leave(void *data, struct wl_keyboard *wl_keyboard, * and for any key repetition to stop. */ release_all_keys(hwnd); + if (hwnd == NtUserGetForegroundWindow()) + { + if (!(NtUserGetWindowLongW(hwnd, GWL_STYLE) & WS_MINIMIZE)) + send_message(hwnd, WM_CANCELMODE, 0, 0); + } /* FIXME: update foreground window as well */ } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6199#note_104335

1 0

[PATCH 0/5] MR8129: widl: Write the table stream.
by Hans Leidekker (＠hans) May 23, 2025

May 23, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8129

2 5

[PATCH 0/1] MR8126: include: Do not register classes from xapofx or x3daudio dlls.
by Elizabeth Figura (＠zfigura) May 23, 2025

May 23, 2025

Alternatively we can avoid "makedep register" for these DLLs by using a separate IDL in dlls/xaudio2_7/. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8126

3 2

[PATCH v3 0/6] MR7932: mf: Restart transforms and sinks on seek.
by Brendan McGrath (＠redmcg) May 23, 2025

May 23, 2025

This MR fixes seek in VRChat by copying the sequence of flushes/stop/starts that Windows does. The order on Windows is: 1. Stop sources; 2. Flush MFTs; 3. Start sources; 4. Request output down the chain of sink inputs; 6. Flush sinks; and 7. Start the clock This takes place whether we pause before we seek or seek without pause. Changes in version 2: 1. Add test to see when SAR requests new samples; 2. Add test to examine when step 4 from above takes place; 3. Adjust the seek implementation in `mf/session.c` to match findings from the new tests; 4. Adjust `mfmediaengine` to reflect findings from the new tests; 5. Refactored `if` statement in `session_start` to be a `switch` again -- v3: mfmediaengine: Request sample if we are seeking. mfmediaengine: Don't perform implicit flush on state change. mf: Don't send MFT_MESSAGE_NOTIFY_START_OF_STREAM when seeking. mf: Restart transforms and sinks on seek. mf/tests: Test sequence of calls during a Pause and Seek. mf/tests: Test when SAR requests a new sample. https://gitlab.winehq.org/wine/wine/-/merge_requests/7932

2 9

[PATCH 0/1] MR8066: mmdevapi: Avoid race between main and notify thread.
by Bernhard Übelacker May 23, 2025

May 23, 2025

The gitlab runners where showing a few flaky crashes in e.g. tests: dmsynth:dmsynth dmusic:dmusic winmm:midi Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58233 This patch attempts to wait at the DRV_CLOSE call for the thread to finish. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8066

3 4

[PATCH v23 0/4] MR6737: comctl32/toolbar: forward WM_NOTIFY CBEN_ENDEDITW
by Alanas Tebuev (＠BZZZZ) May 23, 2025

May 23, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v23: comctl32/toolbar: Forward WM_NOTIFY CBEN_ENDEDITW and CBEN_ENDEDITA. comctl32: Move WM_NOTIFY unicode to ansi conversion code from pager.c to commctrl.c. comctl32: Rewrite COMCTL32_array_reserve (was PAGER_AdjustBuffer). comctl32/tests: Test WM_NOTIFY CBEN_ENDEDITW conversion and forwarding in toolbar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

3 5

[PATCH v6 0/3] MR8078: windows.ui: Fix a double free.
by Zhiyi Zhang (＠zhiyi) May 23, 2025

May 23, 2025

The object reference is actually held by ref_weak. -- v6: geolocation: Use helpers to implement IWeakReference. windows.ui: Use helpers to implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/8078

3 6

[PATCH v3 0/1] MR8111: win32u: Implement NtGdiDdDDIOpenAdapterFromDeviceName().
by Paul Gofman (＠gofman) May 23, 2025

May 23, 2025

-- v3: win32u: Implement NtGdiDdDDIOpenAdapterFromDeviceName(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8111

3 3

[PATCH 0/1] MR8127: include: Add DBBOOKMARK enum.
by Piotr Caban (＠piotr) May 23, 2025

May 23, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8127

2 1

[PATCH v3 0/4] MR8034: winegstreamer: Call wg_format_get_max_size() to get the video decoder output sample size.
by Conor McCarthy (＠cmccarthy) May 23, 2025

May 23, 2025

Windows uses a smaller alignment than gstreamer for some formats, for example NV12. This means we cannot use MFCalculateImageSize() to get the output sample size. Commit 7b79e3a87b1e switched to calling it instead of GetOutputStreamInfo() to fix some game bugs. -- v3: winegstreamer: Call wg_format_get_max_size() to get the video decoder output sample size. winegstreamer: Do not pass a sample size to wg_transform_read_mf(). mf/tests: Add a video processor NV12 test with a width alignment of 2. mfplat/tests: Add NV12 650 x 850 to image_size_tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/8034

2 4