May 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR8070: msado15: Recordset ActiveConnection related changes.
by Piotr Caban (＠piotr) May 18, 2025

May 18, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8070

2 5

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) May 18, 2025

May 18, 2025

eric pouech (@epo) commented about include/consoleapi.h: > ULONG nLength; > ULONG nInitialChars; > ULONG dwCtrlWakeupMask; > - ULONG dwConsoleKeyState; this change (and the other ones using the correct field name) should be in a separate patch (inside the same merge request) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103751

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) May 18, 2025

May 18, 2025

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + > +static void set_cursor_visible(const HANDLE hOutput, const BOOL visible) > +{ > + CONSOLE_CURSOR_INFO cursorInfo; > + > + if (GetConsoleCursorInfo(hOutput, &cursorInfo)) { > + cursorInfo.bVisible = visible; > + SetConsoleCursorInfo(hOutput, &cursorInfo); > + } > +} > + > +static void build_search_string(WCHAR *inputBuffer, int len, SEARCH_CONTEXT *sc) > +{ > + int cc = 0, nn = 0; > + WCHAR *param = NULL, *last_param, *stripped_copy = NULL; > + WCHAR last_stripped_copy[MAX_PATH] = L"\0"; you likely want MAXSTRING here (native definitively works on strings longer than 260 chars) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103750

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) May 18, 2025

May 18, 2025

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + > +static void build_search_string(WCHAR *inputBuffer, int len, SEARCH_CONTEXT *sc) > +{ > + int cc = 0, nn = 0; > + WCHAR *param = NULL, *last_param, *stripped_copy = NULL; > + WCHAR last_stripped_copy[MAX_PATH] = L"\0"; > + BOOL need_wildcard = TRUE; > + > + sc->searchstr[0] = L'\0'; > + > + /* If inputBuffer ends in a space then the user hit tab beyond the last > + * parameter, so use that as the search pos (i.e. a wildcard search). > + * Otherwise, parse the buffer to find the last parameter in the buffer, > + * where tab was pressed. > + */ > + if (inputBuffer[len-1] == L' ') { len can be zero here (if \<tab\> is pressed at beg of line) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103749

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) May 18, 2025

May 18, 2025

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + clear_console_characters(hOutput, maxLen - len, lastConsoleInfo.dwSize.X); /* width at time of last console update */ > + } > + set_cursor_visible(hOutput, TRUE); > + > + /* Remember current dimensions in case user resizes console window. */ > + GetConsoleScreenBufferInfo(hOutput, &lastConsoleInfo); > + > + inputControl.nLength = sizeof(inputControl); > + inputControl.nInitialChars = len; > + inputControl.dwCtrlWakeupMask = (1 << '\t'); > + inputControl.dwControlKeyState = 0; > + > + /* Allow room for NULL terminator. inputBufferLength is at least 1 due to check above. */ > + ret = ReadConsoleW(hInput, inputBuffer, inputBufferLength - 1, numRead, &inputControl); > + > + if (ret) { I'd rather do `if (!ret) break;` so that you gain an indentation level afterwards -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103748

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) May 18, 2025

May 18, 2025

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + sc.have_quotes = FALSE; > + sc.user_specified_quotes = FALSE; > + sc.search_pos = 0; > + sc.insert_pos = 0; > + > + build_search_string(inputBuffer, curPos, &sc); > + TRACE("***** New search: [%s]\n", wine_dbgstr_w(sc.searchstr)); > + > + sc.is_dir_search = is_directory_operation(inputBuffer); > + > + free_directory_entry_list(&sc); > + build_directory_entry_list(&sc); > + } > + > + if (sc.entry_count) { > + get_next_matching_directory_entry(&sc, (inputControl.dwControlKeyState & SHIFT_PRESSED) ? TRUE : FALSE); when starting a new iteration ,you start on second element (index 1) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103747

1 0

[PATCH v6 0/1] MR8051: timeout/tests: Move the ctrl-c tests below an intermediate process.
by Bernhard Übelacker May 18, 2025

May 18, 2025

Failing gitlab CI examples are: - [job #157583](https://gitlab.winehq.org/wine/wine/-/jobs/157583#L2282) - [job #157314](https://gitlab.winehq.org/wine/wine/-/jobs/157314#L1957) - [job #157131](https://gitlab.winehq.org/wine/wine/-/jobs/157131#L2052) - [job #157068](https://gitlab.winehq.org/wine/wine/-/jobs/157068#L1955) - [job #157032](https://gitlab.winehq.org/wine/wine/-/jobs/157032#L2150) - [job #156785](https://gitlab.winehq.org/wine/wine/-/jobs/156785#L2112) - [job #156713](https://gitlab.winehq.org/wine/wine/-/jobs/156713#L2048) - [job 156677#](https://gitlab.winehq.org/wine/wine/-/jobs/156677#L2030) So happens just a few times per day. The value -1073741510 in `timeout.exe:timeout:06b4 done (-1073741510) in 5s 177B` equals to 0xC000013A, STATUS_CONTROL_C_EXIT. Therefore the assumption the ctrl-c from the test reaches sometimes the parent process. -- v6: timeout/tests: Move the ctrl-c tests below an intermediate process. https://gitlab.winehq.org/wine/wine/-/merge_requests/8051

2 3

Re: [PATCH v2 0/1] MR8060: include: Add ID3D11FunctionLinkingGraph.
by Biswapriyo Nath (＠Biswa96) May 18, 2025

May 18, 2025

Biswapriyo Nath (@Biswa96) commented about include/d3d11shader.h: > +#undef INTERFACE > + > +DEFINE_GUID(IID_ID3D11FunctionLinkingGraph, 0x54133220, 0x1ce8, 0x43d3, 0x82, 0x36, 0x98, 0x55, 0xc5, 0xce, 0xec, 0xff); > + > +#define INTERFACE ID3D11FunctionLinkingGraph > +DECLARE_INTERFACE_(ID3D11FunctionLinkingGraph, IUnknown) > +{ > + STDMETHOD(QueryInterface)(THIS_ REFIID iid, void **out) PURE; > + STDMETHOD_(ULONG, AddRef)(THIS) PURE; > + STDMETHOD_(ULONG, Release)(THIS) PURE; > + > + /* ID3D11FunctionLinkingGraph methods */ > + STDMETHOD(CreateModuleInstance)(THIS_ ID3D11ModuleInstance **instance, ID3DBlob **error) PURE; > + STDMETHOD(SetInputSignature)(THIS_ const D3D11_PARAMETER_DESC *parameter_desc, UINT parameter_count, ID3D11LinkingNode **input_node) PURE; > + STDMETHOD(SetOutputSignature)(THIS_ const D3D11_PARAMETER_DESC *parameter_desc, UINT parameter_count, ID3D11LinkingNode **output_node) PURE; > + STDMETHOD(CallFunction)(THIS_ LPCSTR namespace, ID3D11Module *module, LPCSTR function_name, ID3D11LinkingNode **call_node) PURE; This causes error in C++ ``` error: invalid parameter name: 'namespace' is a keyword ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8060#note_103738

1 0

[PATCH v3 0/10] MR8047: Draft: dxcore: Implement IDXCoreAdapterList::GetAdapterCount().
by Mohamad Al-Jaf (＠maljaf) May 18, 2025

May 18, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58133 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58192 -- v3: dxcore: Implement IDXCoreAdapter::GetProperty( HardwareID ). dxcore/tests: Add IDXCoreAdapter::GetProperty() tests. dxcore: Implement IDXCoreAdapterList::GetAdapter(). dxcore/tests: Add IDXCoreAdapterList::GetAdapter() tests. dxcore: Implement IDXCoreAdapterList::GetAdapterCount(). dxcore: Partially implement IDXCoreAdapterFactory::CreateAdapterList(). dxcore/tests: Add IDXCoreAdapterFactory::CreateAdapterList() tests. dxcore: Implement DXCoreCreateAdapterFactory(). dxcore/tests: Add DXCoreCreateAdapterFactory() tests. include: Add dxcore C interface macros. https://gitlab.winehq.org/wine/wine/-/merge_requests/8047

2 11

[PATCH 0/1] MR8069: gdiplus: Remove repeated points before widening paths.
by Esme Povirk (＠madewokherd) May 17, 2025

May 17, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58203 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8069

2 1