May 2025 - Wine-GitLab - list.winehq.org

[PATCH v4 0/4] MR2127: ntdll: Load known dlls from system directory
by Paul Gofman (＠gofman) May 15, 2025

May 15, 2025

The practical issue I am trying to solve is the following scenario (encountered with a game using some Uplay plugin) which has regressed with apisets implementation in Wine. The game imports ucrtbase.dll. Then, a plugin calls GetModuleHandle("api-ms-win-crt-runtime-l1-1-0.dll") and expects GetProcAddress("\_crt_atexit") to succeed on the returned handle. The problem is that the game has ucrtbase.dll in its .exe directory. That one currently gets loaded. Then, find_dll_file() resolves api-ms-win-crt-runtime-l1-1-0.dll to the ucrtbase with a full path in system32 and tries to find that one (this part matches Windows behaviour as far as tests show). Since we have ucrtbase loaded with another path this results in NULL module handle. Windows maintains the list of "Known DLLs" (probably aimed for speeding up processes startup by using pre-mapped dll images for commonly used system dlls). On Windows, known dlls have specifics in load path resolution when dll name doesn't contain path (relative or full): - they are loaded from system directory even if there is another dll with the same name in priority search path; - they are found even if library search paths do not contain system directory; Those "Known DLLs" are basically listed in HKLM\\System\\CurrentControlSet\\Control\\Session Manager\KnownDLLs registry key. But the actual list of "known dlls" is bigger (probably includes all dependencies of those listed under registry key). The full actual list of "known dlls" is in '\\KnownDlls\' directory object which contains image sections under dll names. Most notably, ucrtbase.dll (which is of the concern in the regression) is not listed in registry but is present in \\KnownDlls. Technically nothing prevents us from implementing these mechanics and creating directory object with mapped load dlls, also resolving the explicitly listed dlls' dependencies. But it is not apparent to me if that is going to improve load times noticably in Wine, and also that is worth the inherent complications until anything actually depends on that \\KnownDlls sections. So instead of implementing all of that throughout the loader I added a few missing dlls to registry. The current list in this pat chset corresponds to the contents of \\KnownDlls directory on an up to date Windows 10. -- v4: ntdll: Load known dlls from system directory. loader/wine.inf: Add known dlls key. ntdll: Factor out prepend_system_dir() function. kernel32/tests: Add tests for known dlls load specifics. https://gitlab.winehq.org/wine/wine/-/merge_requests/2127

4 8

[PATCH v7 0/5] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon May 15, 2025

May 15, 2025

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v7: server: Use an event sync for fd objects. server: Introduce a new event sync object. server: Redirect fd-based objects sync to the fd. server: Add an operation to retrieve an object sync. server: Move object grab/release out of (add|remove)_queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

1 6

[PATCH v5 0/5] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon May 15, 2025

May 15, 2025

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v5: server: Use an event sync for fd objects. server: Introduce a new event sync object. server: Redirect fd-based objects sync to the fd. server: Add an operation to retrieve an object sync. server: Move object grab/release out of (add|remove)_queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

1 5

[PATCH 0/1] MR7983: server: Remove const qualifier from shared memory pointers.
by Rémi Bernon May 15, 2025

May 15, 2025

For https://gitlab.winehq.org/wine/wine/-/merge_requests/7610 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7983

2 2

[PATCH 0/1] MR7981: include: Add IHTMLOptionButtonElement interface
by Alistair Leslie-Hughes (＠alesliehughes) May 15, 2025

May 15, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7981

3 2

[PATCH v17 0/7] MR7610: win32u: Create a shared object for user handle entries.
by Rémi Bernon May 15, 2025

May 15, 2025

For https://gitlab.winehq.org/wine/wine/-/merge_requests/7512 to use it to locate window shared objects. -- v17: win32u: Use the session shared object for user handle entries. win32u: Use the session shared object to implement is_window. server: Move the user object handle table to the shared memory. server: Allocate a session shared memory header structure. server: Use NTUSER_OBJ constants for user object types. server: Remove const qualifier from shared memory pointers. include: Implement ReadAcquire64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7610

2 11

[PATCH v4 0/2] MR7678: winewayland: Use system cursor shapes when possible.
by Alexandros Frantzis (＠afrantzis) May 15, 2025

May 15, 2025

This MR uses the cursor-shapes-v1 protocol to tell the compositor which system cursor shape to use. If a shape match is not found (or cursor-shapes-v1 is not available) we fall back to setting the cursor buffer from the Windows cursor data as before. The second commit implements support for a "UseSystemCursors" driver option, similar to what winex11 has. Since this is the first winewayland driver option we also introduce all the related registry reading code. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57648 -- Side note: The registry code is a copy from winex11, and is the third copy in the codebase (x11, mac, wayland). Perhaps it's worth introducing a common ntuser function to perform the option reading for the drivers, something like `NtUserGetDriverOption("X11 Driver", buffer, buffer_size, TRUE /* whether to read app specific option if present */)`. With such a function there is the concern about each call reopening the registry, but we can see if that's actually a problem and how a different API (or some sort of caching) may help. -- v4: winewayland: Support "UseSystemCursors" driver option. winewayland: Use system cursor shapes when possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/7678

3 9

[PATCH v2 0/1] MR7982: winebus: Ignore mouse / keyboard hidraw devices by default.
by Rémi Bernon May 15, 2025

May 15, 2025

-- v2: winebus: Ignore mouse / keyboard hidraw devices by default. https://gitlab.winehq.org/wine/wine/-/merge_requests/7982

1 1

Re: [PATCH v2 0/5] MR7663: wined3d: Move FFP extra states away from STATE_RENDER, part 2/4.
by Rémi Bernon May 15, 2025

May 15, 2025

Fwiw 93bfdc6f21a1b1be092b7a7b8e5b1dad0aff8a46 seems to be causing crashes in `d3d10core:d3d10core` on Win32, which may indicate address space exhaustion, but there's also crashes on wow64 (which I find somehow suspicious) and a couple on win64, so idk... [^1] [^1]: https://test.winehq.org/data/patterns.html#d3d10core:d3d10core -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7663#note_102734

1 0

[PATCH 0/4] MR7980: Add various missing header information
by Alistair Leslie-Hughes (＠alesliehughes) May 15, 2025

May 15, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7980

2 4