June 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR8447: comctl32/listview: Test WM_PAINT with a subclassed header that paints without...
by Nikolay Sivov (＠nsivov) June 30, 2025

June 30, 2025

Thanks. This one will need a rebase after !8327. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8447#note_108188

1 0

Re: [PATCH v3 0/2] MR8327: comctl32/listview: Always set the initial background mode to TRANSPARENT. - approved
by Nikolay Sivov (＠nsivov) June 30, 2025

June 30, 2025

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8327

1 0

Re: [PATCH v3 0/2] MR8327: comctl32/listview: Always set the initial background mode to TRANSPARENT.
by Zhiyi Zhang (＠zhiyi) June 30, 2025

June 30, 2025

On Fri Jun 27 08:51:24 2025 +0000, Zhiyi Zhang wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/8327/diffs?diff_id=189184&start_sha=83d1eda3ee528f697e33607386e2aa259e7983a4#0251bfdc5c488ffd767c45cd3a965188becc33f7_2357_2284) v3: Added LVS_NOCOLUMNHEADER to make tests simpler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8327#note_108185

1 0

Re: [PATCH 0/2] MR8447: comctl32/listview: Test WM_PAINT with a subclassed header that paints without...
by Zhiyi Zhang (＠zhiyi) June 30, 2025

June 30, 2025

On Fri Jun 27 08:40:32 2025 +0000, Nikolay Sivov wrote: > I see, so validating header rect reduces following erase region and > preserves rendered header? Yes. Normally, the original header implementation uses BeginPaint() when handling WM_PAINT, which automatically removes the update region. In this case, an application subclasses the header class and handles WM_PAINT without validating the update region. Thus, the header region is not preserved after calling BeginPaint(listview). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8447#note_108180

1 0

Re: [PATCH 0/2] MR8447: comctl32/listview: Test WM_PAINT with a subclassed header that paints without...
by Nikolay Sivov (＠nsivov) June 30, 2025

June 30, 2025

On Fri Jun 27 08:39:01 2025 +0000, Zhiyi Zhang wrote: > I added that message sequence to show that the header is painted before > WM_ERASEBKGND for the listview. Without the sequence, it might seem > there are other possibilities. For example, the BeginPaint(listview) > could be ahead of UpdateWindow(header), or maybe no WM_ERASEBKGND should > be sent. Even if it remains a todo after the fix, I think it provides > some insight about how it's supposed to work. So I would like to keep it > if that's okay. I see, so validating header rect reduces following erase region and preserves rendered header? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8447#note_108178

1 0

[PATCH 0/3] MR8443: comctl32: Implement OBJID_QUERYCLASSNAMEIDX for more controls.
by Esme Povirk (＠madewokherd) June 30, 2025

June 30, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8443

3 4

Re: [PATCH 0/2] MR8447: comctl32/listview: Test WM_PAINT with a subclassed header that paints without...
by Nikolay Sivov (＠nsivov) June 30, 2025

June 30, 2025

Do we need to check message sequences if they are going to remain todo after the fix? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8447#note_108175

1 0

Re: [PATCH 0/2] MR8447: comctl32/listview: Test WM_PAINT with a subclassed header that paints without...
by Zhiyi Zhang (＠zhiyi) June 30, 2025

June 30, 2025

On Fri Jun 27 08:37:27 2025 +0000, Nikolay Sivov wrote: > Do we need to check message sequences if they are going to remain todo > after the fix? I added that message sequence to show that the header is painted before WM_ERASEBKGND for the listview. Without the sequence, it might seem there are other possibilities. For example, the BeginPaint(listview) could be ahead of UpdateWindow(header), or maybe no WM_ERASEBKGND should be sent. Even if it remains a todo after the fix, I think it provides some insight about how it's supposed to work. So I would like to keep it if that's okay. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8447#note_108177

1 0

Re: [PATCH v7 0/4] MR8390: sapi/tts: Add some SSML parsing tests and XML parsing flags support.
by Huw Davies (＠huw) June 30, 2025

June 30, 2025

After the third commit I'm getting ``` tts.c:1060: Test succeeded inside todo block: got 0. ``` which is fixed after the final commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8390#note_108173

1 0

Re: [PATCH v2 0/5] MR8446: server: Initialize global and user tables with some atoms.
by Rémi Bernon June 30, 2025

June 30, 2025

v2: Remove some todo_wine which now succeed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8446#note_108172

1 0