June 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/2] MR8431: win32u: Mind window show command in startup info.
by Paul Gofman (＠gofman) June 25, 2025

June 25, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8431

2 3

Re: [PATCH v2 0/6] MR8426: server: Use an event sync for console objects.
by Rémi Bernon June 25, 2025

June 25, 2025

The sync is a separate object and as long as it is referenced by other objects it will survive the console destruction (while being reset as it should). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8426#note_107966

1 0

Re: [PATCH v2 0/6] MR8426: server: Use an event sync for console objects.
by Elizabeth Figura (＠zfigura) June 25, 2025

June 25, 2025

However, deferring to the console *was* intentionally undone by e.g. 1bffc938, because these objects can survive their original console. I guess this must pass the tests, but it's not clear to me how? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8426#note_107964

1 0

Re: [PATCH v2 0/6] MR8426: server: Use an event sync for console objects.
by Elizabeth Figura (＠zfigura) June 25, 2025

June 25, 2025

Oh right, there was a reason I didn't do that. <sigh> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8426#note_107963

1 0

Re: [PATCH v2 0/6] MR8426: server: Use an event sync for console objects.
by Rémi Bernon June 25, 2025

June 25, 2025

It's not obvious in the current state of the code that the fd signaling matches to the console signaling state. This could perhaps be done but it's not going to be as no-op as these changes are supposed to be. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8426#note_107962

1 0

[PATCH v13 0/8] MR6892: propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) June 25, 2025

June 25, 2025

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v13: propsys: Implement IPropertyDescription for several known system properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

3 17

[PATCH v12 0/8] MR6892: propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) June 25, 2025

June 25, 2025

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v12: propsys: Implement IPropertyDescription for several known system properties. propsys: Add IPropertyDescription stub for system defined properties. propsys/tests: Add conformance tests for PSGetNameFromPropertyKey. propsys: Add stubs for PSGetNameFromPropertyKey. propsys: Add stubs for PropertySystem. include: Add declaration for PSGetPropertySystem. propsys/tests: Add conformance tests for PSGetPropertyKeyFromName. propsys/tests: Add conformance tests for getting PropertyDescriptions from PropertySystem. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

2 8

Re: [PATCH v2 0/6] MR8426: server: Use an event sync for console objects.
by Elizabeth Figura (＠zfigura) June 25, 2025

June 25, 2025

If we're going to do that, we might as well use the fd. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8426#note_107934

1 0

[PATCH v6 0/3] MR8258: comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid.
by Jacob Czekalla (＠JacobCzekalla) June 25, 2025

June 25, 2025

comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid. LButtonDown should return when the treeview handle is invalid (e.g. destroyed) after NM_CLICK to prevent further message processing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58211 -- v6: comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid. comctl32/treeview: Add a function for sending notifications that also checks for invalid treeview. comctl32/tests: Add a test for treeview deletion during NM_CLICK in LBUTTONDOWN. https://gitlab.winehq.org/wine/wine/-/merge_requests/8258

2 3

[PATCH v5 0/7] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Rémi Bernon June 25, 2025

June 25, 2025

This should fix some spurious test failure in `test_media_session_Close`, as sometimes the source shutdown happens quickly enough and changes the session state to SESSION_STATE_STOPPED, causing the later Close command to succeed when it consistently returns E_SHUTDOWN on Windows. -- v5: mf/session: Simplify the media session shutdown event handling. mf/session: Introduce a SESSION_FLAG_SOURCE_SHUTDOWN presentation flag. mf/session: Replace SESSION_FLAG_END_OF_PRESENTATION with dedicated states. mf/session: Replace SESSION_FLAG_FINALIZE_SINKS with dedicated states. mf/session: Remove unnecessary SESSION_FLAG_PENDING_COMMAND flag. mf/session: Move internal states to a separate command_state enum. mf/session: Clarify internal states from session states separation. https://gitlab.winehq.org/wine/wine/-/merge_requests/8402

1 8