June 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/2] MR8382: msvcr120/tests: Add tests for expf.
by Daniel Lehman (＠dlehman25) June 20, 2025

June 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8382

3 3

Re: [PATCH v2 0/3] MR8379: setupapi: Implement support for device interface properties (SetupDi{Set,Get}DeviceInterfacePropertyW).
by Etaash Mathamsetty (＠etaash.mathamsetty) June 19, 2025

June 19, 2025

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/setupapi/devinst.c: > + { > + SETUPDI_GuidToString( &key->fmtid, prop_path + 11 ); > + swprintf( prop_path + 49, ARRAY_SIZE( prop_path ) - 49, L"\\%04X", key->pid ); > + if (!(ret = RegOpenKeyExW( iface->refstr_key, prop_path, 0, KEY_QUERY_VALUE, &property ))) > + { > + size = buf_size; > + ret = RegQueryValueExW( property, NULL, NULL, &val_type, buf, &size ); > + RegCloseKey( property ); > + } > + > + switch (ret) > + { > + case ERROR_SUCCESS: > + case ERROR_MORE_DATA: > + *type = val_type & 0xffff; > + ret = (ret == ERROR_MORE_DATA || !buf) ? ERROR_INSUFFICIENT_BUFFER : ERROR_SUCCESS; If it can't be refactored, you missed a indent here :p -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8379#note_107338

1 0

Re: [PATCH v2 0/3] MR8379: setupapi: Implement support for device interface properties (SetupDi{Set,Get}DeviceInterfacePropertyW).
by Etaash Mathamsetty (＠etaash.mathamsetty) June 19, 2025

June 19, 2025

This looks very similar to a previously defined function get_device_property. Would it be possible to use that function instead? resolving, @ zfigura already commented a similar thing -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8379#note_107337

1 0

[PATCH v2 0/1] MR8372: user32: Add ScheduleDispatchNotification() stub.
by Zhiyi Zhang (＠zhiyi) June 19, 2025

June 19, 2025

React Native apps use user32.2582 and expect the return value to be non-zero. -- v2: user32: Add ScheduleDispatchNotification() stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/8372

2 1

[PATCH v3 0/3] MR8152: avifil32: Fix a couple of bugs.
by Paul Gofman (＠gofman) June 19, 2025

June 19, 2025

-- v3: avifil32: Fix dwLength counting for fixed size samples. avifil32: Assume OF_WRITE for OF_CREATE in AVIFileOpenW(). avifil32/tests: Test creating AVI file with OF_CREATE but without access mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/8152

3 6

[PATCH 0/1] MR8381: winegstreamer: Support the Indeo 5.0 format in DirectShow.
by Elizabeth Figura (＠zfigura) June 19, 2025

June 19, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8381

3 4

Re: [PATCH v3 0/1] MR8350: crypt32: Handle missing attributes in CDecodeSignedMsg_GetParam. - approved
by Alexandre Julliard (＠julliard) June 19, 2025

June 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8350

1 0

Re: [PATCH v2 0/1] MR8374: crypt32: Fix missing size check in CSignedEncodeMsg_Open. - approved
by Alexandre Julliard (＠julliard) June 19, 2025

June 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8374

1 0

Re: [PATCH v3 0/1] MR8363: winex11.drv: Add programmer dvorak layout. - approved
by Alexandre Julliard (＠julliard) June 19, 2025

June 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8363

1 0

Re: [PATCH v3 0/1] MR8317: ntdll, server: Treat Rbp as CONTEXT_INTEGER register. - approved
by Alexandre Julliard (＠julliard) June 19, 2025

June 19, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8317

1 0