June 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR8344: gdi32: Fix missing terminator element in Devanagari_consonants.
by Yuxuan Shui (＠yshui) June 17, 2025

June 17, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8344

4 3

[PATCH 0/1] MR8349: msvcrt: Fix allocated buffer size in _getcwd.
by Piotr Caban (＠piotr) June 17, 2025

June 17, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8349

2 1

[PATCH 0/1] MR8347: musl: Don't use __builtin_rint in clang builds.
by Piotr Caban (＠piotr) June 17, 2025

June 17, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58381 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8347

3 2

[PATCH 0/1] MR8348: wintrust: Fix data length mix-up in asn decoder.
by Yuxuan Shui (＠yshui) June 17, 2025

June 17, 2025

(I think this is right? realLenBytes is skipped so what's left should be realDataLen bytes? and bytesNeeded also uses realDataLen, not dataLen). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8348

2 1

Re: [PATCH v6 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL.
by Rémi Bernon June 17, 2025

June 17, 2025

On Tue Jun 17 15:09:00 2025 +0000, Paul Gofman wrote: > This is not the case in practice, SwapBuffers works with NULL context in > WGL and GLX. I recall it is depended on in practice, IIRC the launcher > of Black Desert. Okay well I'm going to change this again to move the surfaces to the DCs in the near future, so it won't be needing the context anymore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8210#note_106853

1 0

[PATCH 0/1] MR8343: usp10/tests: Avoid out-of-bound use of glyphItems when nGlyphs mismatches.
by Yuxuan Shui (＠yshui) June 17, 2025

June 17, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8343

2 1

Re: [PATCH v6 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL.
by Paul Gofman (＠gofman) June 17, 2025

June 17, 2025

On Tue Jun 17 13:41:22 2025 +0000, Rémi Bernon wrote: > Hmm, I think it might be needed in theory but I kind of expect apps to > always call wglSwapBuffer with an active context. This is not the case in practice, SwapBuffers works with NULL context in WGL and GLX. I recall it is depended on in practice, IIRC the launcher of Black Desert. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8210#note_106850

1 0

[PATCH 0/2] MR8341: user32/tests: Fix 2 out-of-bound accesses in dde tests.
by Yuxuan Shui (＠yshui) June 17, 2025

June 17, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8341

2 2

Re: [PATCH v6 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL.
by Rémi Bernon June 17, 2025

June 17, 2025

On Tue Jun 17 13:37:42 2025 +0000, Fabian Maurer wrote: > The `context` nullcheck is now pointless, since it's dereferenced > anyways. Is that nullcheck superflous now, or should another nullcheck > be added? Hmm, I think it might be needed in theory but I kind of expect apps to always call wglSwapBuffer with an active context. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8210#note_106843

1 0

Re: [PATCH v6 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL.
by Fabian Maurer (＠DarkShadow44) June 17, 2025

June 17, 2025

Fabian Maurer (@DarkShadow44) commented about dlls/win32u/opengl.c: > + const struct opengl_funcs *funcs = &display_funcs; > int interval; > HWND hwnd; > > - if (!(funcs = get_dc_funcs( hdc, NULL ))) > - { > - RtlSetLastWin32Error( ERROR_DC_NOT_FOUND ); > - return FALSE; > - } > - driver_funcs = funcs == &display_funcs ? display_driver_funcs : memory_driver_funcs; > - > if (!(hwnd = NtUserWindowFromDC( hdc ))) interval = 0; > else interval = get_window_swap_interval( hwnd ); > > + if (context->memory_pbuffer) return flush_memory_pbuffer( context, hdc, FALSE, funcs->p_glFlush ); > return driver_funcs->p_swap_buffers( context ? context->driver_private : NULL, hwnd, hdc, interval ); The `context` nullcheck is now pointless, since it's dereferenced anyways. Is that nullcheck superflous now, or should another nullcheck be added? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8210#note_106842

1 0