June 2025 - Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR8228: mshtml: Fix misuse of IWinInetHttpInfo_QueryInfo.
by Yuxuan Shui (＠yshui) June 12, 2025

June 12, 2025

IWinInetHttpInfo_QueryInfo returns a multibyte string, not a wide string. We were also wrongly expecting it to have a NUL terminator. * * * this one doesn't feel good. IWinInetHttpInfo_QueryInfo calls HttpInfo_QueryInfo (urlmon), which calls HttpQueryInfoA (wininet), so it returns char*. but inside, HttpQueryInfoA is calling HttpQueryInfoW and does charset conversion. so we are converting the string to multibyte and back. maybe there's an API that returns wchar* i don't know about. -- v3: mshtml: Fix misuse of IWinInetHttpInfo_QueryInfo. https://gitlab.winehq.org/wine/wine/-/merge_requests/8228

2 2

Re: [PATCH v3 0/1] MR8242: libs/musl: Force built-in rint for i386.
by Piotr Caban (＠piotr) June 12, 2025

June 12, 2025

I think it's not possible to implement it correctly using floating point operations when 24bit precision is used. We would either need to implement it without floating point operations (I'll look into that) or set the precision. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8242#note_106331

1 0

[PATCH v3 0/2] MR8216: server: prevent division by zero in coordinate mapping
by Wei Xie (＠wayne) June 12, 2025

June 12, 2025

Wine applications crash in VNC/headless environments due to invalid all-zero monitor coordinates. The root cause is: - Environment Issue: VNC systems report all displays as RR_Disconnected - Faulty Fallback: Wine incorrectly reverts to legacy XRandR 1.0 API when no "connected" displays are detected - API Incompatibility: Modern XRandR 1.6 doesn't support Wine's XRandR 1.0 implementation, causing XRRSizes() to return empty display modes - Uninitialized Data: This leaves critical display fields (dmPelsWidth/Height) at initialization value 0 -- v3: winex11: handle fallback display modes when XRandR fails https://gitlab.winehq.org/wine/wine/-/merge_requests/8216

3 11

Re: [PATCH v15 0/3] MR8200: cmd: COPY should output file names as they are copied.
by eric pouech (＠epo) June 12, 2025

June 12, 2025

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > * Otherwise, parse the buffer to find the last parameter in the buffer, > * where tab was pressed. > */ > - if (len && inputBuffer[len-1] == L' ') { you should support the same parameters as below likely you'd better have the {cc=len; } body when parameter_with_delims() fails -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8200#note_106328

1 0

Re: [PATCH v15 0/3] MR8200: cmd: COPY should output file names as they are copied.
by eric pouech (＠epo) June 12, 2025

June 12, 2025

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > /* Handle paths here. Find last '\\'. > * If '\\' isn't found then insert pos is the same as search pos. > */ > - while (cc > sc->search_pos && inputBuffer[cc] != L'\\') { ditto is there a reason to not handle the other delimiters here? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8200#note_106327

1 0

Re: [PATCH v15 0/3] MR8200: cmd: COPY should output file names as they are copied.
by eric pouech (＠epo) June 12, 2025

June 12, 2025

eric pouech (@epo) commented about programs/cmd/builtins.c: > } > } > > + if (numcopied) { > + WCHAR* string; > + string = WCMD_format_string(WCMD_LoadMessage(WCMD_NUMCOPIED), numcopied); nitpick: `WCMD_output(WCMD_LoadMessage... `would be simpler -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8200#note_106326

1 0

[PATCH 0/2] MR8293: kernelbase: SetFileInformationByHandle pass FileRenameInfoEx to NtSetInformationFile
by Michael Stopa (＠stomy) June 12, 2025

June 12, 2025

FileRenameInfoEx is already handled by NtSetInformationFile, SetFileInformationByHandle need only pass it through correctly. As of version 5.3, Apple's Metal Developer Tools are dependent on SetFileInformationByHandle to handle FileRenameInfoEx in this fashion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8293

3 5

[PATCH v3 0/6] MR8254: msi: Fix installing 64 bit library from 32 bit installer if 32 bit version of it is loaded into installer.
by Paul Gofman (＠gofman) June 12, 2025

June 12, 2025

-- v3: msi: Fix getting version info for library loaded into wow64 process. https://gitlab.winehq.org/wine/wine/-/merge_requests/8254

3 8

[PATCH 0/5] MR8291: winex11: Drop pixmap-based child window workaround.
by Rémi Bernon June 12, 2025

June 12, 2025

Updating the GL drawables on/offscreen dynamically, similarly to how we do it for Vulkan, and in order to ultimately converge and factor both GL and VK client surfaces. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8291

1 5

[PATCH 0/1] MR8290: secur32/tests: Fix test failure on Windows 11.
by Hans Leidekker (＠hans) June 12, 2025

June 12, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58190 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8290

2 1