June 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR1035: oleaut32/tests: Use IMallocSpy to test VariantClear(VT_RECORD).
by Kevin Puetz (＠puetzk) Sept. 9, 2025

Sept. 9, 2025

Salvage tests and fix a leak found in another review: see https://gitlab.winehq.org/wine/wine/-/merge_requests/897#note_9175 points 1 and 2. 3. is why !897 was reverted. This does not contain the (incorrect) changes to VariantCopyInd, but instead fixes the leak identified in VariantClear (VT_RECORD needs to free pvRecord), and the wrong allocator being used in VariantCopy (it should have been IMalloc, rather than `HeapAlloc`, as shown by the fact IMallocSpy observes these allocations). This also cleans up some dubious behavior by the test IRecordInfoImpl, which was modifying a VARIANT that it did not own or receive as an argument in the middle of VariantClear. This was likely undefined behavior, and in any case concealed the heap leak. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1035

4 12

[PATCH 0/1] MR7446: oleaut32: Implement OleLoadPictureFileEx()
by Edward OC (＠funfunctor) Sept. 8, 2025

Sept. 8, 2025

As per documentation. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7446

3 2

[PATCH v2 0/1] MR3529: rpcrt4: Forward NdrStubCall3 to NdrStubCall2.
by Alex Henrie (＠alexhenrie) Sept. 8, 2025

Sept. 8, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54606 -- v2: rpcrt4: Forward NdrStubCall3 to NdrStubCall2. https://gitlab.winehq.org/wine/wine/-/merge_requests/3529

5 9

[PATCH v3 0/1] MR7447: oleaut32: Implement (S|G)etVarConversionLocaleSetting()
by Edward OC (＠funfunctor) Sept. 7, 2025

Sept. 7, 2025

Partial, as per documentation, implement fixing as the default locale. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v3: oleaut32: Implement (S|G)etVarConversionLocaleSetting() https://gitlab.winehq.org/wine/wine/-/merge_requests/7447

2 1

[PATCH v4 0/3] MR7375: dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND
by Edward OC (＠funfunctor) Sept. 7, 2025

Sept. 7, 2025

Trivial, small set of cleanups patches to start with, non-controversial and NOP functionally speaking. These are to help get the review process going in making ways towards the bar being lowered for contributing to the oleaut32 implementation. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v4: dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Invert if stmt for clarity dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND https://gitlab.winehq.org/wine/wine/-/merge_requests/7375

3 5

[PATCH v3 0/10] MR7449: oleaut32: Fix methods relating typeinfo substructures around names, guids and friends
by Edward OC (＠funfunctor) Sept. 7, 2025

Sept. 7, 2025

- Clean up method implementations to be consistent and pass tests. - Factor out common code. - Validate arguments. - Correctly match szNameBuf user passed strings as case-insensitive as per documentation. - Match method parameter identifiers to be as per documentation. - Rewrite where required to use common helpers. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v3: oleaut32: Factor out TLB_get_typeinfo_by_guid() https://gitlab.winehq.org/wine/wine/-/merge_requests/7449

3 12

[PATCH v11 0/24] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) Sept. 7, 2025

Sept. 7, 2025

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v11: dlls/oleaut32: ptr_size should be a ULONG This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

2 2

[PATCH v7 0/2] MR4405: gdi32: Implement FixBrushOrgEx according to test.
by Bartosz Kosiorek (＠gang65) Sept. 7, 2025

Sept. 7, 2025

More information about different Windows versions: https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-osversio… Verified with: https://testbot.winehq.org/JobDetails.pl?Key=139906 -- v7: win32u: Fix ExtCreateRegion when parameters are wrong. https://gitlab.winehq.org/wine/wine/-/merge_requests/4405

4 5

[PATCH v2 0/4] MR8401: gdi32: Use the maximum number of colours when biClrUsed is zero.
by Zhiyi Zhang (＠zhiyi) Sept. 7, 2025

Sept. 7, 2025

Fix a regression from 225004e1. According to MSDN, if the biClrUsed field is zero, the bitmap should use the maximum number of colours corresponding to the value of the biBitCount member for the compression mode specified by biCompression. -- v2: Revert "wineps: Use the correct colours when a monochrome bitmap without a colour table is the source." gdi32/tests: Test recording SetDIBitsToDevice() for bitmaps with zero biClrUsed field in EMFs. gdi32/tests: Test recording StretchDIBits() for bitmaps with zero biClrUsed field in EMFs. https://gitlab.winehq.org/wine/wine/-/merge_requests/8401

3 7

[PATCH v4 0/1] MR4820: dlls/winmm: waveOutGetID: Return correct id for WAVE_MAPPER.
by Carlo Bramini (＠carlo-bramini) Sept. 7, 2025

Sept. 7, 2025

Fixes bug 52592. https://bugs.winehq.org/show_bug.cgi?id=52592 -- v4: dlls/winmm: waveOutGetID: Return correct id for WAVE_MAPPER. https://gitlab.winehq.org/wine/wine/-/merge_requests/4820

2 1