June 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR8223: comctl32/taskdialog: Fix layout when there is no button.
by Zhiyi Zhang (＠zhiyi) June 6, 2025

June 6, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8223

3 3

Re: [PATCH v2 0/3] MR8193: Support generating both DWARF and PDB debug info in a single build.
by Jacek Caban (＠jacek) June 6, 2025

June 6, 2025

On Fri Jun 6 18:17:35 2025 +0000, eric pouech wrote: > @jacek just testing this (yeah a bit late sorry), it looks like the .pdb > file only contains the public symbols. > using: clang version 20.1.5 > do we need a later clang version? I tested mostly with LLVM git, but version 19 seems to work too, unless I'm checking it wrong. For example, I get: ``` $ llvm-pdbutil dump --symbols programs/notepad/x86_64-windows/notepad.pdb |grep NOTEPAD_WndProc 7468 | S_LPROC32 [size = 56] `NOTEPAD_WndProc` ``` Do you not see such symbols in your build or did you mean something else? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8193#note_105685

1 0

[PATCH v3 0/5] MR8222: widl: Add rows for the struct type.
by Hans Leidekker (＠hans) June 6, 2025

June 6, 2025

-- v3: widl: Add rows for the requires keyword. widl: Add rows for the exclusiveto attribute. widl: Add rows for the uuid attribute. widl: Add rows for the interface type. https://gitlab.winehq.org/wine/wine/-/merge_requests/8222

4 8

[PATCH 0/1] MR8219: gdiplus/tests: Use correctly formatted description.
by Yuxuan Shui (＠yshui) June 6, 2025

June 6, 2025

According to a comment in emf_create, description is expected to be "App name\0Title\0\0". But in the test cases we only ever passed "winetest\0", so emf_create reads out-of-bound trying to find the title. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8219

3 2

[PATCH 0/1] MR8228: mshtml: Fix misuse of IWinInetHttpInfo_QueryInfo.
by Yuxuan Shui (＠yshui) June 6, 2025

June 6, 2025

IWinInetHttpInfo_QueryInfo returns a multibyte string, not a wide string. We were also wrongly expecting it to have a NUL terminator. * * * this one doesn't feel good. IWinInetHttpInfo_QueryInfo calls HttpInfo_QueryInfo (urlmon), which calls HttpQueryInfoA (wininet), so it returns char*. but inside, HttpQueryInfoA is calling HttpQueryInfoW and does charset conversion. so we are converting the string to multibyte and back. maybe there's an API that returns wchar* i don't know about. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8228

3 4

[PATCH v2 0/5] MR8225: PDB rewrite #15.
by eric pouech (＠epo) June 6, 2025

June 6, 2025

This MR does: - improve startup time when loading a large PDB file (a chromium based PDB file (larger than 4G) now loads in 3,5s) (at the begining of this rewrite, loading the very same PDB file ended with a reboot triggered by the Linux OOM after 30 minutes of heavy swap) - finally untie the new PDB backend for the old one (they are now considered as two independant debug formats, so that we can eventually drop the old one at some point) -- v2: dbghelp: Let new PDB reader exist independantly of the old one. dbghelp: Rename declarations for old PBD backend. dbghelp: Simplify signature of PDB unwinders. dbghelp: Get fpo stream information directly in new PDB reader. dbghelp: Speed up global symbols at startup. https://gitlab.winehq.org/wine/wine/-/merge_requests/8225

2 6

[PATCH 0/1] MR8230: inetmib1: Fix table emptiness check.
by Yuxuan Shui (＠yshui) June 6, 2025

June 6, 2025

getItemAndInstanceFromTable only checks if the table is NULL, but didn't check if it actually contains any entries. It just assumes it does and will return index 1 in some cases, resulting in out-of-bound access of the table down the line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8230

2 1

[PATCH 0/1] MR8229: win32u: Return hwnd from get_full_window_handle when invalid.
by Rémi Bernon June 6, 2025

June 6, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58329 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8229

1 1

[PATCH v4 0/4] MR8220: Draft: comdlg32: Don't use a shadow devmode structure in PrintDlg.
by Jacob Czekalla (＠JacobCzekalla) June 6, 2025

June 6, 2025

If the "Properties" button is clicked in the printdlg it opens the print properties dlg. The problem is the values set in the properties dlg don't get passed through correctly to the final printing stage. This prevents properties like duplex and page size from working. -- v4: comdlg32: Don't use a shadow devmode structure in PrintDlgA. comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgA. comdlg32: Don't use a shadow devmode structure in PrintDlgW. comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgW. https://gitlab.winehq.org/wine/wine/-/merge_requests/8220

3 5

Re: [PATCH v2 0/3] MR8193: Support generating both DWARF and PDB debug info in a single build.
by eric pouech (＠epo) June 6, 2025

June 6, 2025

@jacek just testing this (yeah a bit late sorry), it looks like the .pdb file only contains the public symbols. using: clang version 20.1.5 do we need a later clang version? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8193#note_105659

1 0