June 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR8204: comctl32: Fix use-after-free when page creation fails.
by Yuxuan Shui (＠yshui) June 4, 2025

June 4, 2025

When page creation fails in PROPSHEET_SetCurSel, the dialog window is destroyed, which means the attached PropSheetInfo (psInfo) is freed. Because there is a call to PROPSHEET_SetCurSel in the handling of WM_INITDIAG, any use of psInfo thereafter could be invalid, which wasn't taken into account. * * * this feels a bit iffy but i think this is the right fix? previously we got 0 return value from `PropertySheet` because `do_loop` calls `IsWindow(hwnd)`, and when page creation failed the `hwnd` is destroyed, which resulted in `do_loop` returning 0. i just duplicated this check in `PROPSHEET_PropertySheet` too. as for the change in `DiaglogProc`, if `PROPSHEET_SetCurSel` destroyed the window then the SendMessageW isn't necessary, i believe? also, this bit is redundant i think? ```c /* wizards set their focus during init */ if (psInfo->ppshheader.dwFlags & INTRNL_ANY_WIZARD) return FALSE; return FALSE; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8204

3 2

[PATCH 0/3] MR8205: comctl32: Make sure line_widths is big enough.
by Yuxuan Shui (＠yshui) June 4, 2025

June 4, 2025

When button_count is 0, we would allocate 0 bytes for line_widths, but later line_count would be 1 so we would still try to access line_widths[0] which is out-of-bound. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8205

2 3

[PATCH 0/1] MR8114: kerberos: Get security trailer length from the context.
by Dmitry Timoshkov (＠dmitry) June 4, 2025

June 4, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8114

2 4

[PATCH v2 0/1] MR8200: cmd: COPY should output file names as they are copied.
by Joe Souza (＠JoeS209) June 4, 2025

June 4, 2025

In native Windows, the COPY command will display the names of the files as they are copied. Wine should do the same. This change enables that. -- v2: cmd: COPY should output file names as they are copied. https://gitlab.winehq.org/wine/wine/-/merge_requests/8200

2 1

[PATCH 0/6] MR8203: SECBUFFER_STREAM fixes
by Hans Leidekker (＠hans) June 4, 2025

June 4, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8203

3 7

[PATCH v5 0/5] MR8174: winebth.sys part 12: Introduce support for Low Energy GATT services
by Vibhav Pant (＠vibhavp) June 4, 2025

June 4, 2025

Generic ATTribute Profile (GATT) is a protocol used by BLE devices for data exchange. Broadly, every LE device contains one or more GATT services, with each service having multiple characteristics, which contain the actual piece of data to be exchanged. The Win32 BLE api is defined in [`bluetoothleapis.h`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/), and operates on `HANDLE`s to PDOs created by the driver to remote devices and services, using the `GUID_BLUETOOTHLE_DEVICE_INTERFACE` and `GUID_BLUETOOTH_GATT_SERVICE_DEVICE_INTERFACE` class interfaces respectively. This MR introduces initial support for accessing GATT services on LE devices: * Create PDOs for remote devices that we discover GATT services on, and enabling `GUID_BLUETOOTHLE_DEVICE_INTERFACE` for them. * Because the driver also creates PDOs for bluetooth radios, a tagged union is used to distinguish between device extension values to dispatch IOCTL and PnP IRPs appropriately. * Enumerate through all `org.bluez.GattService1` objects on BlueZ, and store them on the PE driver inside the associated devices. * Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES for device PDOs. * Use the newly added IOCTL to implement [`BluetoothGATTGetServices`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/nf-bluetoothleapis-bluetoothgattgetservices). -- v5: bluetoothapis/tests: Add tests for BluetoothGATTGetServices. bluetoothapis: Implement BluetoothGATTGetServices. winebth.sys: Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES. winebth.sys: Store a list of GATT services discovered on LE devices. winebth.sys: Create PDOs for remote Bluetooth devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/8174

2 5

[PATCH 0/2] MR8170: libs/musl: Set EDOM in exp for NAN.
by Daniel Lehman (＠dlehman25) June 4, 2025

June 4, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8170

3 3

[PATCH v3 0/1] MR7837: shell32/tests: Avoid hang in test_rename.
by Bernhard Übelacker June 4, 2025

June 4, 2025

Followup of 0eab97ffa8. Usually version checks have to be avoided, but this modifies a pre-existing version check to skip that single test just with Windows 7. [Test pattern page.](https://test.winehq.org/data/patterns.html#shell32:shlfileop) [Testbot run with this patch included.](https://testbot.winehq.org/JobDetails.pl?Key=157955) CC: @zhui -- v3: shell32/tests: Avoid hang in test_rename. https://gitlab.winehq.org/wine/wine/-/merge_requests/7837

1 3

[PATCH 0/1] MR8180: crypt32: Fix use-after-free in CRYPT_ImportSystemRootCertsToReg.
by Yuxuan Shui (＠yshui) June 4, 2025

June 4, 2025

CRYPT_ImportSystemRootCertsToReg calls sync_trusted_roots_from_known_locations which calls check_and_store_certs. check_and_store_certs creates a chain engine with `cached`. Here the problem is that the chain engine actually owns the store used to create it. And when later the chain engine is freed, the store is closed too. This means on the success path `cached` is already closed when sync_trusted_roots_from_known_locations returns to CRYPT_ImportSystemRootCertsToReg, but CRYPT_ImportSystemRootCertsToReg tries to close `cached` again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8180

3 12

[PATCH v2 0/1] MR7837: shell32/tests: Avoid hang in test_rename.
by Bernhard Übelacker June 4, 2025

June 4, 2025

Followup of 0eab97ffa8. Usually version checks have to be avoided, but this modifies a pre-existing version check to skip that single test just with Windows 7. [Test pattern page.](https://test.winehq.org/data/patterns.html#shell32:shlfileop) [Testbot run with this patch included.](https://testbot.winehq.org/JobDetails.pl?Key=157955) CC: @zhui -- v2: shell32/tests: Avoid hang in test_rename. https://gitlab.winehq.org/wine/wine/-/merge_requests/7837

1 1