July 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/3] MR8567: winegstreamer: Return S_OK from AllocateStreamingResources().
by Elizabeth Figura (＠zfigura) July 14, 2025

July 14, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8567

2 3

[PATCH v15 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Vibhav Pant (＠vibhavp) July 14, 2025

July 14, 2025

-- v15: setupapi: Support in-built properties in SetupDiGetDevicePropertyW and CM_Get_DevNode_Property_ExW. ntoskrnl.exe/tests: Add tests for built-in properties for PnP device instances. setupapi/tests: Add tests for inbuilt device properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/8515

2 4

Re: [PATCH v14 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Elizabeth Figura (＠zfigura) July 14, 2025

July 14, 2025

On Mon Jul 14 18:05:00 2025 +0000, Vibhav Pant wrote: > On Clang, it results in this error for x86_64: > ``` > ../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type > 'unsigned long' but the argument has type 'unsigned long long' [-Werror,-Wformat] > 1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu > >= %lu\n", keys_len, ARRAY_SIZE(expected_keys)); > ``` > for i686: > ``` > ../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type > 'unsigned long' but the argument has type 'unsigned int' [-Werror,-Wformat] > 1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu > >= %lu\n", keys_len, ARRAY_SIZE(expected_keys)); > ``` That's capital I, not lowercase l. I cannot imagine what on earth possessed gitlab to use a sans-serif font by default. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109815

1 0

Re: [PATCH v14 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Vibhav Pant (＠vibhavp) July 14, 2025

July 14, 2025

On Mon Jul 14 17:58:45 2025 +0000, Elizabeth Figura wrote: > Personally I feel that writing a constant in an error message is > redundant. You already know what the expected value is by looking at the > test; it doesn't help to print it in the terminal. Fair, I just wanted to keep the same test style as the rest of the code in `test_device_property`, which seems to use this format as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109813

1 0

Re: [PATCH v14 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Vibhav Pant (＠vibhavp) July 14, 2025

July 14, 2025

On Mon Jul 14 17:59:28 2025 +0000, Elizabeth Figura wrote: > You can use %Iu for sizeof. On Clang, it results in this error for x86_64: ``` ../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type 'unsigned long' but the argument has type 'unsigned long long' [-Werror,-Wformat] 1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu >= %lu\n", keys_len, ARRAY_SIZE(expected_keys)); ``` for i686: ``` ../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Werror,-Wformat] 1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu >= %lu\n", keys_len, ARRAY_SIZE(expected_keys)); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109812

1 0

Re: [PATCH v14 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Elizabeth Figura (＠zfigura) July 14, 2025

July 14, 2025

On Mon Jul 14 17:59:28 2025 +0000, Connor McAdams wrote: > Ah, nevermind then. :) You can use %Iu for sizeof. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109811

1 0

Re: [PATCH v14 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Elizabeth Figura (＠zfigura) July 14, 2025

July 14, 2025

On Fri Jul 11 19:24:00 2025 +0000, Vibhav Pant wrote: > changed this line in [version 10 of the diff](/wine/wine/-/merge_requests/8515/diffs?diff_id=192559&start_sha=b78521e67e02e66a1c214df25354c14c1fd3ed65#5c8e393d12376e8f2a4f2aec734e275204aecb82_1291_1291) Personally I feel that writing a constant in an error message is redundant. You already know what the expected value is by looking at the test; it doesn't help to print it in the terminal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109810

1 0

[PATCH v17 0/8] MR6892: propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) July 14, 2025

July 14, 2025

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v17: propsys: Implement IPropertyDescription for several known system properties. propsys: Add IPropertyDescription stub for system defined properties. propsys/tests: Add conformance tests for PSGetNameFromPropertyKey. propsys: Add stubs for PSGetNameFromPropertyKey. propsys: Add stubs for PropertySystem. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

2 8

[PATCH v16 0/8] MR6892: propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) July 14, 2025

July 14, 2025

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v16: propsys: Implement IPropertyDescription for several known system properties. propsys: Add IPropertyDescription stub for system defined properties. propsys/tests: Add conformance tests for PSGetNameFromPropertyKey. propsys: Add stubs for PSGetNameFromPropertyKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

2 10

Re: [PATCH v2 0/1] MR8213: d2d1: Fix out-of-bound array access.
by Yuxuan Shui (＠yshui) July 14, 2025

July 14, 2025

@nsivov can you have a look? thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8213#note_109801

1 0