July 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v12 0/1] MR8467: conhost: Implement F1 and F3 support for history retrieval.
by eric pouech (＠epo) July 12, 2025

July 12, 2025

eric pouech (@epo) commented about programs/conhost/conhost.c: > +{ > + if (console->edit_line.history_index) > + { > + struct edit_line *ctx = &console->edit_line; > + unsigned int index = ctx->history_index - 1; > + WCHAR *line = console->history[index]->text; > + unsigned int len = console->history[index]->len / sizeof(WCHAR); > + > + if (len > ctx->cursor) > + { > + unsigned int ccount = (copycount > 0) ? copycount : len - ctx->cursor; > + > + if (ctx->cursor == ctx->len) > + { > + /* Clean the screen. */ > + edit_line_delete(console, ctx->cursor, ctx->len); since ctx->cursor == ctx->len, this does nothing the rest looks good to me -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8467#note_109659

1 0

[PATCH 0/1] MR8543: cmd: Fix out-of-bound access when handling tilde modifiers.
by Yuxuan Shui (＠yshui) July 12, 2025

July 12, 2025

wcschr(str, 0) returns the end of the string, not NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8543

3 2

Re: [PATCH v4 0/2] MR8511: ole32: Restore cursor in DoDragDrop.
by Roman Pišl July 12, 2025

July 12, 2025

On Sat Jul 12 12:15:36 2025 +0000, Huw Davies wrote: > Could we add a test for this? We have some existing tests, so it > shouldn't be too hard to add this. Test added and checked: https://testbot.winehq.org/JobDetails.pl?Key=159171#k301 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8511#note_109657

1 0

[PATCH 0/1] MR8546: ucrtbase/tests: Move cexp tests from msvcr120.
by Daniel Lehman (＠dlehman25) July 12, 2025

July 12, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8546

3 2

[PATCH v3 0/2] MR8511: ole32: Restore cursor in DoDragDrop.
by Roman Pišl July 12, 2025

July 12, 2025

The cursor is changed in give_feedback() but is not restored back. -- v3: ole32: Preserve cursor in DoDragDrop. ole32/tests: Test that cursor is preserved in DoDragDrop. https://gitlab.winehq.org/wine/wine/-/merge_requests/8511

1 2

[PATCH v2 0/2] MR8511: ole32: Restore cursor in DoDragDrop.
by Roman Pišl July 12, 2025

July 12, 2025

The cursor is changed in give_feedback() but is not restored back. -- v2: ole32: Preserve cursor in DoDragDrop. ole32/tests: Test that cursor is preserved in DoDragDrop. https://gitlab.winehq.org/wine/wine/-/merge_requests/8511

1 2

Re: [PATCH v3 0/1] MR8420: dsound: Make sure to null-terminate strings for callbacks. - approved
by Alexandre Julliard (＠julliard) July 11, 2025

July 11, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8420

1 0

Re: [PATCH v4 0/3] MR8544: sapi/xml: Parse the prosody SSML element. - approved
by Alexandre Julliard (＠julliard) July 11, 2025

July 11, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8544

1 0

Re: [PATCH v2 0/2] MR8550: winebus.sys: Mind potential udev_device_get_subsystem error, don't leak fd. - approved
by Alexandre Julliard (＠julliard) July 11, 2025

July 11, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8550

1 0

Re: [PATCH v2 0/1] MR8548: widl: Rename metadata stream type enum values to avoid conflict with Cygwin limits.h. - approved
by Alexandre Julliard (＠julliard) July 11, 2025

July 11, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8548

1 0